[PR PATCH] firefox: enable in i686

[PR PATCH] firefox: enable in i686

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

There is a new pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org firefox
https://github.com/void-linux/void-packages/pull/30455

firefox: enable in i686
<!-- Mark items with [x] where applicable -->
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages (on i686) but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, i686

references #30031

[ci skip]

A patch file from https://github.com/void-linux/void-packages/pull/30455.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firefox-30455.patch --]
[-- Type: text/x-diff, Size: 849 bytes --]

From 2b85023aa82d6f7ffbbe065592ee416e9e8c54c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Fri, 23 Apr 2021 18:23:51 +0200
Subject: [PATCH] firefox: enable in i686

---
 srcpkgs/firefox/template | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/srcpkgs/firefox/template b/srcpkgs/firefox/template
index fdc688c6089e..338a2bb5b9e8 100644
--- a/srcpkgs/firefox/template
+++ b/srcpkgs/firefox/template
@@ -46,10 +46,6 @@ if [ "$XBPS_WORDSIZE" = "32" ]; then
 	nodebug=yes
 fi
 
-if [ "$XBPS_TARGET_MACHINE" = i686 ]; then
-	broken="out of memory allocating 65536 bytes after a total of 1181696000 bytes"
-fi
-
 # we need this because cargo verifies checksums of all files in vendor
 # crates when it builds and gives us no way to override or update the
 # file sanely... so just clear out the file list

Re: firefox: enable in i686

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30455#issuecomment-825807849

Comment:
Is the OOM non deterministic, then? We had it fail a lot of times on builders :/

Re: firefox: enable in i686

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/30455#issuecomment-825809737

Comment:
87 was failing for me too, recent update to 88 passed on first try.

Re: firefox: enable in i686

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30455#issuecomment-825829243

Comment:
Ah, nice!

Re: [PR PATCH] [Merged]: firefox: enable in i686

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

There's a merged pull request on the void-packages repository

firefox: enable in i686
https://github.com/void-linux/void-packages/pull/30455

Description:
<!-- Mark items with [x] where applicable -->
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages (on i686) but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, i686

references #30031

[ci skip]