[PR PATCH] New package: mpvpaper-1.1

[PR PATCH] New package: mpvpaper-1.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

There is a new pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages mpvpaper
https://github.com/void-linux/void-packages/pull/29962

New package: mpvpaper-1.1
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29962.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpvpaper-29962.patch --]
[-- Type: text/x-diff, Size: 2055 bytes --]

From e4b611ca3a33d6b9258e1a639b70c0c2539444b1 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sat, 3 Apr 2021 01:31:05 +0300
Subject: [PATCH] New package: mpvpaper-1.1

---
 srcpkgs/mpvpaper/patches/define-uint.patch | 25 ++++++++++++++++++++++
 srcpkgs/mpvpaper/template                  | 14 ++++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 srcpkgs/mpvpaper/patches/define-uint.patch
 create mode 100644 srcpkgs/mpvpaper/template

diff --git a/srcpkgs/mpvpaper/patches/define-uint.patch b/srcpkgs/mpvpaper/patches/define-uint.patch
new file mode 100644
index 000000000000..ea08c05d1da1
--- /dev/null
+++ b/srcpkgs/mpvpaper/patches/define-uint.patch
@@ -0,0 +1,25 @@
+diff --git src/holder.c src/holder.c
+index 09d425e..32027b3 100644
+--- src/holder.c
++++ src/holder.c
+@@ -12,6 +12,8 @@
+ #include "wlr-layer-shell-unstable-v1-client-protocol.h"
+ #include "xdg-output-unstable-v1-client-protocol.h"
+ 
++typedef unsigned int uint;
++
+ struct wl_state {
+     struct wl_display *display;
+     struct wl_compositor *compositor;
+diff --git src/main.c src/main.c
+index cbe559c..39f504c 100644
+--- src/main.c
++++ src/main.c
+@@ -21,6 +21,7 @@
+ 
+ #include <cflogprinter.h>
+ 
++typedef unsigned int uint;
+ 
+ struct wl_state {
+     struct wl_display *display;
diff --git a/srcpkgs/mpvpaper/template b/srcpkgs/mpvpaper/template
new file mode 100644
index 000000000000..5fc014ac0b95
--- /dev/null
+++ b/srcpkgs/mpvpaper/template
@@ -0,0 +1,14 @@
+# Template file for 'mpvpaper'
+pkgname=mpvpaper
+version=1.1
+revision=1
+build_style=meson
+hostmakedepends="pkg-config"
+makedepends="mpv-devel wlroots-devel"
+depends="mpv wlroots"
+short_desc="Video wallpaper setter for wlroots based wayland compositors"
+maintainer="FollieHiyuki <folliekazetani@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/GhostNaN/mpvpaper"
+distfiles="https://github.com/GhostNaN/mpvpaper/archive/${version}.tar.gz"
+checksum=dc774d3ec0a14cc955af6426427870163bab858f5878ada71706473884359a33

Re: New package: mpvpaper-1.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#issuecomment-812745842

Comment:
Needs `wayland-devel` in host.

I'd like to wait for a wlroots release before merging this, to see how they work with it.

Re: [PR PATCH] [Updated] New package: mpvpaper-1.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages mpvpaper
https://github.com/void-linux/void-packages/pull/29962

New package: mpvpaper-1.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29962.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpvpaper-29962.patch --]
[-- Type: text/x-diff, Size: 2069 bytes --]

From d48c499781c516ee434f2236443972a6ea8b2c60 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sat, 3 Apr 2021 01:31:05 +0300
Subject: [PATCH] New package: mpvpaper-1.1

---
 srcpkgs/mpvpaper/patches/define-uint.patch | 25 ++++++++++++++++++++++
 srcpkgs/mpvpaper/template                  | 14 ++++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 srcpkgs/mpvpaper/patches/define-uint.patch
 create mode 100644 srcpkgs/mpvpaper/template

diff --git a/srcpkgs/mpvpaper/patches/define-uint.patch b/srcpkgs/mpvpaper/patches/define-uint.patch
new file mode 100644
index 000000000000..ea08c05d1da1
--- /dev/null
+++ b/srcpkgs/mpvpaper/patches/define-uint.patch
@@ -0,0 +1,25 @@
+diff --git src/holder.c src/holder.c
+index 09d425e..32027b3 100644
+--- src/holder.c
++++ src/holder.c
+@@ -12,6 +12,8 @@
+ #include "wlr-layer-shell-unstable-v1-client-protocol.h"
+ #include "xdg-output-unstable-v1-client-protocol.h"
+ 
++typedef unsigned int uint;
++
+ struct wl_state {
+     struct wl_display *display;
+     struct wl_compositor *compositor;
+diff --git src/main.c src/main.c
+index cbe559c..39f504c 100644
+--- src/main.c
++++ src/main.c
+@@ -21,6 +21,7 @@
+ 
+ #include <cflogprinter.h>
+ 
++typedef unsigned int uint;
+ 
+ struct wl_state {
+     struct wl_display *display;
diff --git a/srcpkgs/mpvpaper/template b/srcpkgs/mpvpaper/template
new file mode 100644
index 000000000000..792a0ee83385
--- /dev/null
+++ b/srcpkgs/mpvpaper/template
@@ -0,0 +1,14 @@
+# Template file for 'mpvpaper'
+pkgname=mpvpaper
+version=1.1
+revision=1
+build_style=meson
+hostmakedepends="pkg-config wayland-devel"
+makedepends="mpv-devel wlroots-devel"
+depends="mpv wlroots"
+short_desc="Video wallpaper setter for wlroots based wayland compositors"
+maintainer="FollieHiyuki <folliekazetani@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/GhostNaN/mpvpaper"
+distfiles="https://github.com/GhostNaN/mpvpaper/archive/${version}.tar.gz"
+checksum=dc774d3ec0a14cc955af6426427870163bab858f5878ada71706473884359a33

Re: New package: mpvpaper-1.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#issuecomment-823410252

Comment:
I tested briefly on hikari, river, sway and wayfire.
Seems to work fine with wlroots-0.13.0.

Re: New package: mpvpaper-1.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#issuecomment-827290957

Comment:
@ericonr good to merge?

Re: [PR REVIEW] New package: mpvpaper-1.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#discussion_r622587583

Comment:
It links against `libmpv`, so `mpv` in `depends` isn't needed... But does it actually touch `wlroots`?

Re: [PR PATCH] [Updated] New package: mpvpaper-1.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages mpvpaper
https://github.com/void-linux/void-packages/pull/29962

New package: mpvpaper-1.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29962.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpvpaper-29962.patch --]
[-- Type: text/x-diff, Size: 2045 bytes --]

From 6a3a8e768d4232b786fb813973a054f62ce451a2 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sat, 3 Apr 2021 01:31:05 +0300
Subject: [PATCH] New package: mpvpaper-1.1

---
 srcpkgs/mpvpaper/patches/define-uint.patch | 25 ++++++++++++++++++++++
 srcpkgs/mpvpaper/template                  | 13 +++++++++++
 2 files changed, 38 insertions(+)
 create mode 100644 srcpkgs/mpvpaper/patches/define-uint.patch
 create mode 100644 srcpkgs/mpvpaper/template

diff --git a/srcpkgs/mpvpaper/patches/define-uint.patch b/srcpkgs/mpvpaper/patches/define-uint.patch
new file mode 100644
index 000000000000..ea08c05d1da1
--- /dev/null
+++ b/srcpkgs/mpvpaper/patches/define-uint.patch
@@ -0,0 +1,25 @@
+diff --git src/holder.c src/holder.c
+index 09d425e..32027b3 100644
+--- src/holder.c
++++ src/holder.c
+@@ -12,6 +12,8 @@
+ #include "wlr-layer-shell-unstable-v1-client-protocol.h"
+ #include "xdg-output-unstable-v1-client-protocol.h"
+ 
++typedef unsigned int uint;
++
+ struct wl_state {
+     struct wl_display *display;
+     struct wl_compositor *compositor;
+diff --git src/main.c src/main.c
+index cbe559c..39f504c 100644
+--- src/main.c
++++ src/main.c
+@@ -21,6 +21,7 @@
+ 
+ #include <cflogprinter.h>
+ 
++typedef unsigned int uint;
+ 
+ struct wl_state {
+     struct wl_display *display;
diff --git a/srcpkgs/mpvpaper/template b/srcpkgs/mpvpaper/template
new file mode 100644
index 000000000000..d07e08e065dd
--- /dev/null
+++ b/srcpkgs/mpvpaper/template
@@ -0,0 +1,13 @@
+# Template file for 'mpvpaper'
+pkgname=mpvpaper
+version=1.1
+revision=1
+build_style=meson
+hostmakedepends="pkg-config wayland-devel"
+makedepends="mpv-devel wlroots-devel"
+short_desc="Video wallpaper setter for wlroots based wayland compositors"
+maintainer="FollieHiyuki <folliekazetani@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/GhostNaN/mpvpaper"
+distfiles="https://github.com/GhostNaN/mpvpaper/archive/${version}.tar.gz"
+checksum=dc774d3ec0a14cc955af6426427870163bab858f5878ada71706473884359a33

Re: [PR REVIEW] New package: mpvpaper-1.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

New review comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#discussion_r622654399

Comment:
Yeah right `wlroots` and `mpv` don't seem to be explicitly needed in depends.

But it uses xdg-output-unstable-v1 and wlr-layer-shell-unstable-v1 so shouldn't we specify `wlroots` in depends as a safe guard (since it only works in wlroots based compositors)?

Re: [PR PATCH] [Updated] New package: mpvpaper-1.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages mpvpaper
https://github.com/void-linux/void-packages/pull/29962

New package: mpvpaper-1.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29962.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpvpaper-29962.patch --]
[-- Type: text/x-diff, Size: 2045 bytes --]

From 4003bca0a6eba8999be26234e3b22202ed86de1c Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sat, 3 Apr 2021 01:31:05 +0300
Subject: [PATCH] New package: mpvpaper-1.1

---
 srcpkgs/mpvpaper/patches/define-uint.patch | 25 ++++++++++++++++++++++
 srcpkgs/mpvpaper/template                  | 13 +++++++++++
 2 files changed, 38 insertions(+)
 create mode 100644 srcpkgs/mpvpaper/patches/define-uint.patch
 create mode 100644 srcpkgs/mpvpaper/template

diff --git a/srcpkgs/mpvpaper/patches/define-uint.patch b/srcpkgs/mpvpaper/patches/define-uint.patch
new file mode 100644
index 000000000000..ea08c05d1da1
--- /dev/null
+++ b/srcpkgs/mpvpaper/patches/define-uint.patch
@@ -0,0 +1,25 @@
+diff --git src/holder.c src/holder.c
+index 09d425e..32027b3 100644
+--- src/holder.c
++++ src/holder.c
+@@ -12,6 +12,8 @@
+ #include "wlr-layer-shell-unstable-v1-client-protocol.h"
+ #include "xdg-output-unstable-v1-client-protocol.h"
+ 
++typedef unsigned int uint;
++
+ struct wl_state {
+     struct wl_display *display;
+     struct wl_compositor *compositor;
+diff --git src/main.c src/main.c
+index cbe559c..39f504c 100644
+--- src/main.c
++++ src/main.c
+@@ -21,6 +21,7 @@
+ 
+ #include <cflogprinter.h>
+ 
++typedef unsigned int uint;
+ 
+ struct wl_state {
+     struct wl_display *display;
diff --git a/srcpkgs/mpvpaper/template b/srcpkgs/mpvpaper/template
new file mode 100644
index 000000000000..e1c6b7eebae1
--- /dev/null
+++ b/srcpkgs/mpvpaper/template
@@ -0,0 +1,13 @@
+# Template file for 'mpvpaper'
+pkgname=mpvpaper
+version=1.1
+revision=1
+build_style=meson
+hostmakedepends="pkg-config wayland-devel"
+makedepends="mpv-devel wlroots-devel"
+short_desc="Video wallpaper setter for wlroots based Wayland compositors"
+maintainer="FollieHiyuki <folliekazetani@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/GhostNaN/mpvpaper"
+distfiles="https://github.com/GhostNaN/mpvpaper/archive/${version}.tar.gz"
+checksum=dc774d3ec0a14cc955af6426427870163bab858f5878ada71706473884359a33

Re: [PR REVIEW] New package: mpvpaper-1.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#discussion_r623127558

Comment:
I don't think so. You can implement wlr protocols without being wlroots based, even.

Re: [PR REVIEW] New package: mpvpaper-1.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#discussion_r623127864

Comment:
I understand the need for `wlroots-devel`, then.

Re: [PR REVIEW] New package: mpvpaper-1.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#discussion_r623127864

Comment:
I understand the need for `wlroots-devel`, though.

Re: New package: mpvpaper-1.1

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/29962#issuecomment-1127140523

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: mpvpaper-1.1

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

There's a closed pull request on the void-packages repository

New package: mpvpaper-1.1
https://github.com/void-linux/void-packages/pull/29962

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->