[PR PATCH] New package: hashcash-1.23

[PR PATCH] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

There is a new pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1003 bytes --]

From 0b66b245c520878767e00d4760d8050a7ad25f52 Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..ff52ec4a8e4
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,14 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+build_style=gnu-makefile
+hostmakedepends="make"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999
+make_build_args+=" hashcash docs"
+make_install_args+=" install"

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1021 bytes --]

From e7c853ce171a9a720c378a342143ba2b08ecc8ed Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..46144409801
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+hostmakedepends="make"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999
+make_build_args+=" hashcash docs"
+make_install_args+=" install"

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567890194

Comment:
This is unnecessary *and* breaks the masterdir.

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567889989

Comment:
You should just set these, they don't have an initial value. Also, put this directly below `build_style`.

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567889343

Comment:
Why?

Re: New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-770921463

Comment:
Also, this is bad code

```
array.c:13:33: warning: implicit declaration of function 'die_msg' [-Wimplicit-function-declaration]
   13 |     if ( array->elt == NULL ) { die_msg( "out of memory" ); }
      |                                 ^~~~~~~
sdb.c: In function 'sdb_cb_token_matcher':
sdb.c:319:3: warning: implicit declaration of function 'die_msg' [-Wimplicit-function-declaration]
  319 |   die_msg( re_err );
      |   ^~~~~~~
```

And conflicts with `outils`

Finally, what's it useful for standalone?

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567895061

Comment:
@ericonr I added this line because this package fails to be built with `musl` lib

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 992 bytes --]

From f4d12806c7ae430d3fc3d2c29dee48bd799ca500 Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..246a9cf3e64
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,14 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+make_build_args="hashcash docs"
+make_install_args="install"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

New comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-770928553

Comment:
@ericonr thanks, I've fixed you review comments.

> Also, this is bad code

I'm not the author of this package, I'm just the user. I added it here, because it's missed in Void repositories, and I'm using Void now. FYI it's available in other distro's main repos (e.g. Ubuntu stable has this package). Maybe I can add a patch to remove this code if you think it's critical.

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567902602

Comment:
What kind of errors did you get?

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567906658

Comment:
```
=> hashcash-1.23_1: running do_install ...
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe         -c -o sha1.o sha1.c
cc sha1.o libsha1.o -o sha1 -Wl,-z,relro -Wl,-z,now -Wl,--as-needed    
```

It's building sha1 during install.

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567910726

Comment:
I tried to build it in `voidlinux/masterdir-x86_64-musl` Docker the error was:
```
In file included from array.c:5:
array.h:32:5: error: unknown type name 'time_t'
   32 |     time_t expires_before;
      |     ^~~~~~
```

Also, CI on musl also fails.

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567912007

Comment:
Yes, in `Makefile` it has an option to build either with openssl or with embedded sha1 implementation.

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567918267

Comment:
What I meant is that this should be moved to `do_build`. And generally speaking I'd expect openssl/libressl SHA1 to perform better.

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1038 bytes --]

From bad76bf16e5b0a45bfa9ca69a124ad176a35b4f2 Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..07225f52d63
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,14 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+# TODO: use openssl/libressl instead of embedded SHA1 implementation
+make_build_args="hashcash docs sha1"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r567928760

Comment:
Sorry, I missed that. Fixed in a new commit: https://github.com/void-linux/void-packages/pull/28379/commits/bad76bf16e5b0a45bfa9ca69a124ad176a35b4f2

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1004 bytes --]

From e4b9f866df7efb642257ac0ddfe90a09dd8f2f1f Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..d1d313e6f13
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,14 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+hostmakedepends="libressl-devel"
+make_build_args="generic-openssl docs"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1025 bytes --]

From 3b86884358f33411e8b0b714a5e0ef29ce05a85f Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..9d76e450da9
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+make_build_args="generic-openssl docs"
+makedepends="libressl-devel"
+depends="openssl>=3.0"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-771130183

Comment:
@ericonr I added libressl-devel make dependency and openssl runtime dependency in https://github.com/void-linux/void-packages/pull/28379/commits/3b86884358f33411e8b0b714a5e0ef29ce05a85f but it breaks aarch64 and armv7 (in CI checks). Is it better than using embedded sha1 implementation?

Re: New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-771153632

Comment:
```
LIBCRYPTO=/usr/lib/libcrypto.a
```

You have to override this value from their makefile. Something like `make_build_args="LIBCRYPTO=$XBPS_CROSS_BASE/usr/lib/libcrypto.a"`

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1072 bytes --]

From baecd695322b91bdb5ce15d75e8f0e1a32c0604c Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..c457bd4ee53
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=$XBPS_CROSS_BASE/usr/lib/libcrypto.a generic-openssl docs"
+makedepends="libressl-devel"
+depends="openssl>=3.0"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-771377985

Comment:
> ```
> LIBCRYPTO=/usr/lib/libcrypto.a
> ```
> 
> You have to override this value from their makefile. Something like `make_build_args="LIBCRYPTO=$XBPS_CROSS_BASE/usr/lib/libcrypto.a"`

@ericonr thanks, that's fixed the problem

Re: [PR REVIEW] New package: hashcash-1.23

[sgn]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568570025

Comment:
Sorry if I was missing anything, but what's wrong with `LIBCRYPTO=-lcrypto`?

Re: [PR REVIEW] New package: hashcash-1.23

[sgn]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568570262

Comment:
I don't think we have `openssl` for now.

Re: [PR REVIEW] New package: hashcash-1.23

[sgn]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568569400

Comment:
Simply add `#include <time.h>` into `array.h` fix the problem.

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1834 bytes --]

From 3cf115a49b39c1c69bdf3559233aaed1ce5b0a87 Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 14 ++++++++++++++
 srcpkgs/hashcash/template           | 15 +++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..e4ab8ab7a67
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,14 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
+Common subdirectories: hashcash-1.23/contrib and hashcash-1.23-p/contrib
+Common subdirectories: hashcash-1.23/debian and hashcash-1.23-p/debian
+Common subdirectories: hashcash-1.23/test and hashcash-1.23-p/test
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..3969e96aa1b
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+depends="openssl>=3.0"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568577169

Comment:
@sgn If I understand correctly, libressl provides openssl>=3 API, so if we have a dependency on openssl, then both openssl and libressl implementations work.

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1834 bytes --]

From 598712dc0cd851c9b7ba627d45f07ed98df2da7e Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 14 ++++++++++++++
 srcpkgs/hashcash/template           | 15 +++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..e4ab8ab7a67
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,14 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
+Common subdirectories: hashcash-1.23/contrib and hashcash-1.23-p/contrib
+Common subdirectories: hashcash-1.23/debian and hashcash-1.23-p/debian
+Common subdirectories: hashcash-1.23/test and hashcash-1.23-p/test
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..3969e96aa1b
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="~*-musl"
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+depends="openssl>=3.0"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: [PR REVIEW] New package: hashcash-1.23

[sgn]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568578450

Comment:
OK, libressl provides `openssl-$version`. I think we can just write `libressl` there. Or `openssl`.

Re: New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-771615915

Comment:
@sgn thanks for review, I've fixed and answered your comments

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1611 bytes --]

From 4d6453004f9c579f88e57849045676cdb74b13bf Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 11 +++++++++++
 srcpkgs/hashcash/template           | 15 +++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..5c8cf15b38e
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,11 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..0b16429a24e
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="*"
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+depends="openssl>=3.0"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568587582

Comment:
Does this command call the openssl executable? Otherwise this shouldn't be here. Also you can't depend on the openssl package while it doesn't exist.

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568587800

Comment:
It wants static linking, idk why.

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1612 bytes --]

From 21dae205e239e74c060ea28005d42d27fb7aa460 Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 11 +++++++++++
 srcpkgs/hashcash/template           | 15 +++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..5c8cf15b38e
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,11 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..30ea32ac5e1
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+archs="*"
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+depends="libressl>=3.0"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568590352

Comment:
@sgn @ericonr OK, I renamed to `libressl>=3.0`

Re: New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-771625907

Comment:
You still haven't added the conflict with outils, and this doesn't need an archs line anymore.

> I'm not the author of this package, I'm just the user.

Yes, but we are still responsible for the quality of upstream software we accept into our repos. And I still don't understand what this package is useful for. That other distros ship a certain package doesn't automatically make it clear a certain bar.

Re: [PR REVIEW] New package: hashcash-1.23

[sgn]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568591147

Comment:
Now, it's time to remove it entirely.

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568591512

Comment:
No, no version specification. And I don't think this calls the libressl executable, so why is it added as a dependency?

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1621 bytes --]

From ed7bc77dd76b02722d0e4e600381a0e437894e8c Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 11 +++++++++++
 srcpkgs/hashcash/template           | 15 +++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..5c8cf15b38e
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,11 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..3435e75d91f
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,15 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+depends="libressl>=3.0"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999
+conflicts="outils"

Re: New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

New comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#issuecomment-771631644

Comment:
@sgn I removed architecture line, @ericonr and added conflict with outils.

> And I still don't understand what this package is useful for

This tool is useful for some network chats or websites, which ask users to solve a hash-task as a proof of work.

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568603139

Comment:
@ericonr according to manual, it should be package name, not executable binary: https://github.com/void-linux/void-packages/blob/master/Manual.md#optional-variables and since I can be sure it's working with libressl 3d version I added >= 3.0. Do you think I should remove version constraint?

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568612065

Comment:
The only relevant thing in the `libressl` package is the `openssl` executable, equivalent to what an `openssl` package would provide. Since this program doesn't call that executable, why is it a dependency?

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r568625052

Comment:
@ericonr this package depends on sha1 implementation of openssl (`openssl/sha1.`) which is provided by libressl, this is why I added `libressl-devel` as build dependency and `libressl` as runtime dependency

Re: [PR REVIEW] New package: hashcash-1.23

[abenson]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r569530895

Comment:
`xbps-src` will correctly detect the right package to add to `depends`, so this is unnecessary.

Re: [PR REVIEW] New package: hashcash-1.23

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r569535743

Comment:
(and the correct package is `libcryptoXX`, not `libressl`.

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

There is an updated pull request by abenson against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1595 bytes --]

From e2fe9dd5558f1f2793335f9c56a350f40221234a Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 11 +++++++++++
 srcpkgs/hashcash/template           | 14 ++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..5c8cf15b38e
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,11 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..5e325ef2feb
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,14 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999
+conflicts="outils"

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1595 bytes --]

From ac817e081e743bfb027c1ac118c0a9281385fbef Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 11 +++++++++++
 srcpkgs/hashcash/template           | 14 ++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..5c8cf15b38e
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,11 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..5e325ef2feb
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,14 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999
+conflicts="outils"

Re: [PR PATCH] [Updated] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

There is an updated pull request by g4s8 against master on the void-packages repository

https://github.com/g4s8/void-packages hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

New package: hashcash-1.23
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28379.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hashcash-1.23-28379.patch --]
[-- Type: text/x-diff, Size: 1595 bytes --]

From edad5fb1071b140a26bbadc2806ccdb95bb467c5 Mon Sep 17 00:00:00 2001
From: Kirill <g4s8.public@gmail.com>
Date: Mon, 1 Feb 2021 13:50:29 +0300
Subject: [PATCH] New package: hashcash-1.23

---
 srcpkgs/hashcash/patches/musl.patch | 11 +++++++++++
 srcpkgs/hashcash/template           | 14 ++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 srcpkgs/hashcash/patches/musl.patch
 create mode 100644 srcpkgs/hashcash/template

diff --git a/srcpkgs/hashcash/patches/musl.patch b/srcpkgs/hashcash/patches/musl.patch
new file mode 100644
index 00000000000..5c8cf15b38e
--- /dev/null
+++ b/srcpkgs/hashcash/patches/musl.patch
@@ -0,0 +1,11 @@
+--- array.h	2011-03-31 15:35:12.000000000 +0400
++++ array.h	2021-02-02 15:45:43.232048145 +0300
+@@ -3,6 +3,8 @@
+ #if !defined( _array_h )
+ #define _array_h
+ 
++#include <time.h>
++
+ #if defined( __cplusplus )
+ extern "C" {
+ #endif
diff --git a/srcpkgs/hashcash/template b/srcpkgs/hashcash/template
new file mode 100644
index 00000000000..5e325ef2feb
--- /dev/null
+++ b/srcpkgs/hashcash/template
@@ -0,0 +1,14 @@
+# Template file for 'hashcash'
+pkgname=hashcash
+version=1.23
+revision=1
+build_style=gnu-makefile
+make_build_args="LIBCRYPTO=-lcrypto generic-openssl docs"
+makedepends="libressl-devel"
+short_desc="Hashcash proof-of-work algorithm"
+maintainer="Kirill Che. <g4s8.public@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.hashcash.org"
+distfiles="http://www.hashcash.org/source/hashcash-${version}-pr.tgz"
+checksum=03a85b6a8a84be93f76a7297fccd5f61dcb8255de25f3fbd77c26be3ef9be999
+conflicts="outils"

Re: [PR REVIEW] New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New review comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/pull/28379#discussion_r569546205

Comment:
@abenson @ericonr OK, so I've removed the runtime dependency line, is it good now? edad5fb1071b140a26bbadc2806ccdb95bb467c5

Re: [PR PATCH] [Closed]: New package: hashcash-1.23

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

There's a closed pull request on the void-packages repository

New package: hashcash-1.23
https://github.com/void-linux/void-packages/pull/28379

Description:
<!-- Mark items with [x] where applicable -->
Added new `hashcash` package for www.hashcash.org/ 
It's currently available in default Debian and Ubuntu repositories, but not in Void repo.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl