[PR PATCH] spice: update to 0.15.0

[PR PATCH] spice: update to 0.15.0

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

There is a new pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages update/spice/0.15.0
https://github.com/void-linux/void-packages/pull/30784

spice: update to 0.15.0
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30784.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/spice/0.15.0-30784.patch --]
[-- Type: text/x-diff, Size: 1319 bytes --]

From ddd97f38910808b207d1a34d589629993026474c Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Mon, 10 May 2021 18:45:23 +0200
Subject: [PATCH] spice: update to 0.15.0

---
 srcpkgs/spice/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/spice/template b/srcpkgs/spice/template
index 2d771932ea74..fc5bafb97273 100644
--- a/srcpkgs/spice/template
+++ b/srcpkgs/spice/template
@@ -1,7 +1,7 @@
 # Template file for 'spice'
 pkgname=spice
-version=0.14.3
-revision=4
+version=0.15.0
+revision=1
 build_style=gnu-configure
 configure_args="--disable-tunnel --disable-opengl --enable-smartcard
  --with-sasl --disable-static --enable-xinerama --disable-celt051"
@@ -14,8 +14,8 @@ short_desc="Implements the SPICE protocol"
 maintainer="Anachron <gith@cron.world>"
 license="LGPL-2.1-or-later"
 homepage="http://www.spice-space.org"
-distfiles="http://www.spice-space.org/download/releases/spice-${version}.tar.bz2"
-checksum=551d4be4a07667cf0543f3c895beb6da8a93ef5a9829f2ae47817be5e616a114
+distfiles="https://www.spice-space.org/download/releases/spice-server/spice-${version}.tar.bz2"
+checksum=b320cf8f4bd2852750acb703c15b72856027e5a8554f8217dfbb3cc09deba0f5
 
 if [ "$XBPS_TARGET_ENDIAN" != "le" ]; then
 	broken="SPICE server only works on little endian architectures"

Re: [PR PATCH] [Updated] spice: update to 0.15.0

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages update/spice/0.15.0
https://github.com/void-linux/void-packages/pull/30784

spice: update to 0.15.0
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30784.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/spice/0.15.0-30784.patch --]
[-- Type: text/x-diff, Size: 1584 bytes --]

From 4654efd69a5dd8d668848446279a8b28a25fe5ec Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Mon, 10 May 2021 18:45:23 +0200
Subject: [PATCH] spice: update to 0.15.0

---
 srcpkgs/spice/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/spice/template b/srcpkgs/spice/template
index 2d771932ea74..b0a2c1e6af7f 100644
--- a/srcpkgs/spice/template
+++ b/srcpkgs/spice/template
@@ -1,7 +1,7 @@
 # Template file for 'spice'
 pkgname=spice
-version=0.14.3
-revision=4
+version=0.15.0
+revision=1
 build_style=gnu-configure
 configure_args="--disable-tunnel --disable-opengl --enable-smartcard
  --with-sasl --disable-static --enable-xinerama --disable-celt051"
@@ -10,12 +10,13 @@ makedepends="spice-protocol libjpeg-turbo-devel pixman-devel
  openssl-devel opus-devel alsa-lib-devel libXfixes-devel libXrender-devel
  libXrandr-devel libsasl-devel libXinerama-devel libglib-devel libcacard-devel
  nss-devel"
+checkdepends="glib-networking"
 short_desc="Implements the SPICE protocol"
 maintainer="Anachron <gith@cron.world>"
 license="LGPL-2.1-or-later"
 homepage="http://www.spice-space.org"
-distfiles="http://www.spice-space.org/download/releases/spice-${version}.tar.bz2"
-checksum=551d4be4a07667cf0543f3c895beb6da8a93ef5a9829f2ae47817be5e616a114
+distfiles="https://www.spice-space.org/download/releases/spice-server/spice-${version}.tar.bz2"
+checksum=b320cf8f4bd2852750acb703c15b72856027e5a8554f8217dfbb3cc09deba0f5
 
 if [ "$XBPS_TARGET_ENDIAN" != "le" ]; then
 	broken="SPICE server only works on little endian architectures"

Re: spice: update to 0.15.0

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/30784#issuecomment-836997684

Comment:
spice depends on a TLS backend being available for check stage so added `glib-networking`

Re: spice: update to 0.15.0

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/30784#issuecomment-837125911

Comment:
spice has a `test-sasl.c` test, that calls `getnameinfo` (in `server/red-stream.cpp`) with `NI_NUMERICHOST | NI_NUMERICSERV` on a socket that is `AF_LOCAL` and `SOCK_STREAM`, which on glibc returns `localhost` and `` (empty string), however on musl this just errors out, thus the test fails on musl

Re: [PR PATCH] [Updated] spice: update to 0.15.0

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages update/spice/0.15.0
https://github.com/void-linux/void-packages/pull/30784

spice: update to 0.15.0
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30784.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/spice/0.15.0-30784.patch --]
[-- Type: text/x-diff, Size: 1795 bytes --]

From 8e8b4fe28da8174694924fe86ce5ebb5d47dcae2 Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Mon, 10 May 2021 18:45:23 +0200
Subject: [PATCH] spice: update to 0.15.0

---
 srcpkgs/spice/template | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/spice/template b/srcpkgs/spice/template
index 2d771932ea74..a92572bec32b 100644
--- a/srcpkgs/spice/template
+++ b/srcpkgs/spice/template
@@ -1,7 +1,7 @@
 # Template file for 'spice'
 pkgname=spice
-version=0.14.3
-revision=4
+version=0.15.0
+revision=1
 build_style=gnu-configure
 configure_args="--disable-tunnel --disable-opengl --enable-smartcard
  --with-sasl --disable-static --enable-xinerama --disable-celt051"
@@ -10,17 +10,23 @@ makedepends="spice-protocol libjpeg-turbo-devel pixman-devel
  openssl-devel opus-devel alsa-lib-devel libXfixes-devel libXrender-devel
  libXrandr-devel libsasl-devel libXinerama-devel libglib-devel libcacard-devel
  nss-devel"
+checkdepends="glib-networking"
 short_desc="Implements the SPICE protocol"
 maintainer="Anachron <gith@cron.world>"
 license="LGPL-2.1-or-later"
 homepage="http://www.spice-space.org"
-distfiles="http://www.spice-space.org/download/releases/spice-${version}.tar.bz2"
-checksum=551d4be4a07667cf0543f3c895beb6da8a93ef5a9829f2ae47817be5e616a114
+distfiles="https://www.spice-space.org/download/releases/spice-server/spice-${version}.tar.bz2"
+checksum=b320cf8f4bd2852750acb703c15b72856027e5a8554f8217dfbb3cc09deba0f5
 
 if [ "$XBPS_TARGET_ENDIAN" != "le" ]; then
 	broken="SPICE server only works on little endian architectures"
 fi
 
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+  # tests depend on odd behaviour of glibc
+  make_check=no
+fi
+
 post_extract() {
 	sed -i 's/armv6hl/arm/g' configure	# "detects" cpu from triplet.
 }

Re: [PR REVIEW] spice: update to 0.15.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30784#discussion_r629632559

Comment:
Please document what the odd behavior is. If it gets too long, it can happen in the commit message; it should at least be tracked.

Re: [PR PATCH] [Updated] spice: update to 0.15.0

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages update/spice/0.15.0
https://github.com/void-linux/void-packages/pull/30784

spice: update to 0.15.0
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30784.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/spice/0.15.0-30784.patch --]
[-- Type: text/x-diff, Size: 1984 bytes --]

From d673463d1b5abf695af70a40b33aac2a3ba24799 Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Mon, 10 May 2021 18:45:23 +0200
Subject: [PATCH] spice: update to 0.15.0

---
 srcpkgs/spice/template | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/spice/template b/srcpkgs/spice/template
index 2d771932ea74..7f67e27c1ac9 100644
--- a/srcpkgs/spice/template
+++ b/srcpkgs/spice/template
@@ -1,7 +1,7 @@
 # Template file for 'spice'
 pkgname=spice
-version=0.14.3
-revision=4
+version=0.15.0
+revision=1
 build_style=gnu-configure
 configure_args="--disable-tunnel --disable-opengl --enable-smartcard
  --with-sasl --disable-static --enable-xinerama --disable-celt051"
@@ -10,17 +10,26 @@ makedepends="spice-protocol libjpeg-turbo-devel pixman-devel
  openssl-devel opus-devel alsa-lib-devel libXfixes-devel libXrender-devel
  libXrandr-devel libsasl-devel libXinerama-devel libglib-devel libcacard-devel
  nss-devel"
+checkdepends="glib-networking"
 short_desc="Implements the SPICE protocol"
 maintainer="Anachron <gith@cron.world>"
 license="LGPL-2.1-or-later"
 homepage="http://www.spice-space.org"
-distfiles="http://www.spice-space.org/download/releases/spice-${version}.tar.bz2"
-checksum=551d4be4a07667cf0543f3c895beb6da8a93ef5a9829f2ae47817be5e616a114
+distfiles="https://www.spice-space.org/download/releases/spice-server/spice-${version}.tar.bz2"
+checksum=b320cf8f4bd2852750acb703c15b72856027e5a8554f8217dfbb3cc09deba0f5
 
 if [ "$XBPS_TARGET_ENDIAN" != "le" ]; then
 	broken="SPICE server only works on little endian architectures"
 fi
 
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+	# tests depend on odd behaviour of glibc
+	# in this case being that calling getnameinfo on an AF_LOCAL socket
+	# will return successfully, with either hostname or "localhost"
+	# musl errors out instead, thus failing the tests
+	make_check=no
+fi
+
 post_extract() {
 	sed -i 's/armv6hl/arm/g' configure	# "detects" cpu from triplet.
 }

Re: [PR REVIEW] spice: update to 0.15.0

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/30784#discussion_r629661061

Comment:
is this better?

Re: [PR PATCH] [Merged]: spice: update to 0.15.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

There's a merged pull request on the void-packages repository

spice: update to 0.15.0
https://github.com/void-linux/void-packages/pull/30784

Description:
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR