Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mpdscribble: update to 0.23,
@ 2021-05-14 16:52 mobinmob
  2021-05-14 18:09 ` [PR REVIEW] " ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: mobinmob @ 2021-05-14 16:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages mpdscribble
https://github.com/void-linux/void-packages/pull/30877

mpdscribble: update to 0.23,
- change build system to meson (upstream change),
- add boost-devel and libgcrypt-devel to makedepends (new deps),
- drop glib-devel from makedepends (dropped upstream),
- add changelog.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30877.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpdscribble-30877.patch --]
[-- Type: text/x-diff, Size: 1715 bytes --]

From 022d4662946e6329ae3495ef2dd1745082d42a09 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 14 May 2021 19:41:49 +0300
Subject: [PATCH] mpdscribble: update to 0.23, - change build system to meson
 (upstream change), - add boost-devel and libgcrypt-devel to makedepends (new
 deps), - drop glib-devel from makedepends (dropped upstream), - add
 changelog.

---
 srcpkgs/mpdscribble/template | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/mpdscribble/template b/srcpkgs/mpdscribble/template
index 94b53fb39148..bbea97a9c14f 100644
--- a/srcpkgs/mpdscribble/template
+++ b/srcpkgs/mpdscribble/template
@@ -1,16 +1,17 @@
 # Template file for 'mpdscribble'
 pkgname=mpdscribble
-version=0.22
-revision=6
-build_style=gnu-configure
+version=0.23
+revision=1
+build_style=meson
 hostmakedepends="pkg-config"
-makedepends="libmpdclient-devel glib-devel libcurl-devel"
+makedepends="libmpdclient-devel libcurl-devel boost-devel libgcrypt-devel"
 short_desc="MPD audio scrobbler (e.g. last.fm)"
 maintainer="Georg Schabel <gescha@posteo.de>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/MusicPlayerDaemon/mpdscribble"
-distfiles="http://www.musicpd.org/download/${pkgname}/${version}/${pkgname}-${version}.tar.bz2"
-checksum=1cde2b5f8c70f0e3e6f059d01bf0b0f2eac2b29fbcd14b01a8a5103e603feb41
+changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/mpdscribble/v0.23/NEWS"
+distfiles="https://www.musicpd.org/download/mpdscribble/${version}/mpdscribble-${version}.tar.xz"
+checksum=a3387ed9140eb2fca1ccaf9f9d2d9b5a6326a72c9bcd4119429790c534fec668
 
 conf_files="/etc/${pkgname}.conf"
 make_dirs="/var/cache/mpdscribble/ 0755 root root"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] mpdscribble: update to 0.23,
  2021-05-14 16:52 [PR PATCH] mpdscribble: update to 0.23, mobinmob
@ 2021-05-14 18:09 ` ericonr
  2021-05-15 11:19 ` [PR PATCH] [Updated] " mobinmob
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-05-14 18:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30877#discussion_r632706990

Comment:
Either use the `master` branch (preferable) or `v${version}`

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] mpdscribble: update to 0.23,
  2021-05-14 16:52 [PR PATCH] mpdscribble: update to 0.23, mobinmob
  2021-05-14 18:09 ` [PR REVIEW] " ericonr
@ 2021-05-15 11:19 ` mobinmob
  2021-05-15 11:20 ` [PR REVIEW] " mobinmob
  2021-05-15 15:05 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: mobinmob @ 2021-05-15 11:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1794 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages mpdscribble
https://github.com/void-linux/void-packages/pull/30877

mpdscribble: update to 0.23,
- change build system to meson (upstream change),
- add boost-devel and libgcrypt-devel to makedepends (new deps),
- drop glib-devel from makedepends (dropped upstream),
- add changelog.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30877.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpdscribble-30877.patch --]
[-- Type: text/x-diff, Size: 1716 bytes --]

From 9ec2f949ff25990476c19d9d185b0001f50fffda Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 14 May 2021 19:41:49 +0300
Subject: [PATCH] mpdscribble: update to 0.23, - change build system to meson
 (upstream change), - add boost-devel and libgcrypt-devel to makedepends (new
 deps), - drop glib-devel from makedepends (dropped upstream), - add
 changelog.

---
 srcpkgs/mpdscribble/template | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/mpdscribble/template b/srcpkgs/mpdscribble/template
index 94b53fb39148..7a33d2bb607a 100644
--- a/srcpkgs/mpdscribble/template
+++ b/srcpkgs/mpdscribble/template
@@ -1,16 +1,17 @@
 # Template file for 'mpdscribble'
 pkgname=mpdscribble
-version=0.22
-revision=6
-build_style=gnu-configure
+version=0.23
+revision=1
+build_style=meson
 hostmakedepends="pkg-config"
-makedepends="libmpdclient-devel glib-devel libcurl-devel"
+makedepends="libmpdclient-devel libcurl-devel boost-devel libgcrypt-devel"
 short_desc="MPD audio scrobbler (e.g. last.fm)"
 maintainer="Georg Schabel <gescha@posteo.de>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/MusicPlayerDaemon/mpdscribble"
-distfiles="http://www.musicpd.org/download/${pkgname}/${version}/${pkgname}-${version}.tar.bz2"
-checksum=1cde2b5f8c70f0e3e6f059d01bf0b0f2eac2b29fbcd14b01a8a5103e603feb41
+changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/mpdscribble/master/NEWS"
+distfiles="https://www.musicpd.org/download/mpdscribble/${version}/mpdscribble-${version}.tar.xz"
+checksum=a3387ed9140eb2fca1ccaf9f9d2d9b5a6326a72c9bcd4119429790c534fec668
 
 conf_files="/etc/${pkgname}.conf"
 make_dirs="/var/cache/mpdscribble/ 0755 root root"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] mpdscribble: update to 0.23,
  2021-05-14 16:52 [PR PATCH] mpdscribble: update to 0.23, mobinmob
  2021-05-14 18:09 ` [PR REVIEW] " ericonr
  2021-05-15 11:19 ` [PR PATCH] [Updated] " mobinmob
@ 2021-05-15 11:20 ` mobinmob
  2021-05-15 15:05 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: mobinmob @ 2021-05-15 11:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/30877#discussion_r632932889

Comment:
Done, thanx!

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: mpdscribble: update to 0.23,
  2021-05-14 16:52 [PR PATCH] mpdscribble: update to 0.23, mobinmob
                   ` (2 preceding siblings ...)
  2021-05-15 11:20 ` [PR REVIEW] " mobinmob
@ 2021-05-15 15:05 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-05-15 15:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]

There's a merged pull request on the void-packages repository

mpdscribble: update to 0.23,
https://github.com/void-linux/void-packages/pull/30877

Description:
- change build system to meson (upstream change),
- add boost-devel and libgcrypt-devel to makedepends (new deps),
- drop glib-devel from makedepends (dropped upstream),
- add changelog.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-15 15:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 16:52 [PR PATCH] mpdscribble: update to 0.23, mobinmob
2021-05-14 18:09 ` [PR REVIEW] " ericonr
2021-05-15 11:19 ` [PR PATCH] [Updated] " mobinmob
2021-05-15 11:20 ` [PR REVIEW] " mobinmob
2021-05-15 15:05 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).