* Re: [PR PATCH] [Updated] Trim down lua*-devel dependencies
2021-05-19 2:51 [PR PATCH] Trim down lua*-devel dependencies ericonr
@ 2021-05-19 2:58 ` ericonr
2021-05-19 10:24 ` q66
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-05-19 2:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages luadeps
https://github.com/void-linux/void-packages/pull/30982
Trim down lua*-devel dependencies
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
@q66
A patch file from https://github.com/void-linux/void-packages/pull/30982.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-luadeps-30982.patch --]
[-- Type: text/x-diff, Size: 4678 bytes --]
From 2751e237df7df9ec17ecd5c5b0ae15459727c5d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:46:49 -0300
Subject: [PATCH 1/4] lua53: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua53-devel doesn't need to depend on their devel packages.
The package has listed these dependencies explicitly since at least
f0105c662bd1be3c1e84271fb6a63da7e6bf3752 (2013), so it being there until
today seems to be more of a historical artifact then for an actual
reason.
---
srcpkgs/lua53/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/lua53/template b/srcpkgs/lua53/template
index 098d700bac82..0761abc9bc17 100644
--- a/srcpkgs/lua53/template
+++ b/srcpkgs/lua53/template
@@ -1,7 +1,7 @@
# Template file for 'lua53'
pkgname=lua53
version=5.3.5
-revision=6
+revision=7
wrksrc=lua-${version}
makedepends="ncurses-devel readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.3.x)"
@@ -58,7 +58,7 @@ do_install() {
}
lua53-devel_package() {
- depends="${makedepends} lua53>=${version}_${revision}"
+ depends="lua53>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.3
From 3251af71bc766d47ee538ca746ea26ec74d74191 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:49:10 -0300
Subject: [PATCH 2/4] lua51: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua51-devel doesn't need to depend on their devel packages.
---
srcpkgs/lua51/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/lua51/template b/srcpkgs/lua51/template
index 12da0983a617..7aad299f0757 100644
--- a/srcpkgs/lua51/template
+++ b/srcpkgs/lua51/template
@@ -1,7 +1,7 @@
# Template file for 'lua51'
pkgname=lua51
version=5.1.5
-revision=12
+revision=13
wrksrc="lua-${version}"
makedepends="ncurses-devel readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.1.x)"
@@ -52,7 +52,7 @@ do_install() {
}
lua51-devel_package() {
- depends="${makedepends} lua51>=${version}_${revision}"
+ depends="lua51>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.1
From 515690214e3f5454757fb6593fd0157e30fb2ab9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:49:34 -0300
Subject: [PATCH 3/4] lua52: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua52-devel doesn't need to depend on their devel packages.
---
srcpkgs/lua52/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/lua52/template b/srcpkgs/lua52/template
index b26e54aba8c5..ecdf8e35b1c0 100644
--- a/srcpkgs/lua52/template
+++ b/srcpkgs/lua52/template
@@ -1,7 +1,7 @@
# Template file for 'lua52'
pkgname=lua52
version=5.2.4
-revision=11
+revision=12
wrksrc=lua-${version}
makedepends="ncurses-devel readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.2.x)"
@@ -52,7 +52,7 @@ do_install() {
}
lua52-devel_package() {
- depends="${makedepends} lua52>=${version}_${revision}"
+ depends="lua52>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.2
From 744cd2b9e2bd3c27a3bb09d1b1086fca50d6b1cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:49:53 -0300
Subject: [PATCH 4/4] lua54: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua54-devel doesn't need to depend on their devel packages.
---
srcpkgs/lua54/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/lua54/template b/srcpkgs/lua54/template
index 47d4425cd63f..a897183fa2ed 100644
--- a/srcpkgs/lua54/template
+++ b/srcpkgs/lua54/template
@@ -1,7 +1,7 @@
# Template file for 'lua54'
pkgname=lua54
version=5.4.3
-revision=1
+revision=2
wrksrc=lua-${version}
makedepends="ncurses-devel readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.4.x)"
@@ -53,7 +53,7 @@ do_install() {
}
lua54-devel_package() {
- depends="${makedepends} lua54>=${version}_${revision}"
+ depends="lua54>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.4
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Trim down lua*-devel dependencies
2021-05-19 2:51 [PR PATCH] Trim down lua*-devel dependencies ericonr
2021-05-19 2:58 ` [PR PATCH] [Updated] " ericonr
@ 2021-05-19 10:24 ` q66
2021-05-19 12:08 ` ericonr
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: q66 @ 2021-05-19 10:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/30982#issuecomment-843965426
Comment:
you should also be able to drop ncurses from 5.3+
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Trim down lua*-devel dependencies
2021-05-19 2:51 [PR PATCH] Trim down lua*-devel dependencies ericonr
2021-05-19 2:58 ` [PR PATCH] [Updated] " ericonr
2021-05-19 10:24 ` q66
@ 2021-05-19 12:08 ` ericonr
2021-05-19 12:24 ` sgn
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-05-19 12:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30982#issuecomment-844040539
Comment:
It would seem 5.2 dropped any reference to curses from their stuff already, any reason you're starting with 5.3?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Trim down lua*-devel dependencies
2021-05-19 2:51 [PR PATCH] Trim down lua*-devel dependencies ericonr
` (2 preceding siblings ...)
2021-05-19 12:08 ` ericonr
@ 2021-05-19 12:24 ` sgn
2021-05-19 12:45 ` q66
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2021-05-19 12:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/30982#issuecomment-844053501
Comment:
No need to callout f0105c662bd1be3c1e84271fb6a63da7e6bf3752 in lua53, the depends was there before that.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Trim down lua*-devel dependencies
2021-05-19 2:51 [PR PATCH] Trim down lua*-devel dependencies ericonr
` (3 preceding siblings ...)
2021-05-19 12:24 ` sgn
@ 2021-05-19 12:45 ` q66
2021-05-20 3:10 ` [PR PATCH] [Updated] " ericonr
2021-05-20 3:47 ` [PR PATCH] [Merged]: " ericonr
6 siblings, 0 replies; 8+ messages in thread
From: q66 @ 2021-05-19 12:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/30982#issuecomment-844070493
Comment:
hm, yeah i guess 5.2+
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] Trim down lua*-devel dependencies
2021-05-19 2:51 [PR PATCH] Trim down lua*-devel dependencies ericonr
` (4 preceding siblings ...)
2021-05-19 12:45 ` q66
@ 2021-05-20 3:10 ` ericonr
2021-05-20 3:47 ` [PR PATCH] [Merged]: " ericonr
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-05-20 3:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages luadeps
https://github.com/void-linux/void-packages/pull/30982
Trim down lua*-devel dependencies
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
@q66
A patch file from https://github.com/void-linux/void-packages/pull/30982.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-luadeps-30982.patch --]
[-- Type: text/x-diff, Size: 5492 bytes --]
From 55bfa4d8325df5eccb987a16dd3333ce535dbcd3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:49:10 -0300
Subject: [PATCH 1/4] lua51: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua51-devel doesn't need to depend on their devel packages.
---
srcpkgs/lua51/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/lua51/template b/srcpkgs/lua51/template
index 12da0983a617..7aad299f0757 100644
--- a/srcpkgs/lua51/template
+++ b/srcpkgs/lua51/template
@@ -1,7 +1,7 @@
# Template file for 'lua51'
pkgname=lua51
version=5.1.5
-revision=12
+revision=13
wrksrc="lua-${version}"
makedepends="ncurses-devel readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.1.x)"
@@ -52,7 +52,7 @@ do_install() {
}
lua51-devel_package() {
- depends="${makedepends} lua51>=${version}_${revision}"
+ depends="lua51>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.1
From d26cbcc85c3863183f4576693c4feb9f5121106c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:49:34 -0300
Subject: [PATCH 2/4] lua52: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua52-devel doesn't need to depend on their devel packages.
While we are here, remove ncurses-devel from makedepends, since it's no
longer used by the lua build system (this doesn't make a huge
difference, because readline-devel still pulls it in).
---
srcpkgs/lua52/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/lua52/template b/srcpkgs/lua52/template
index b26e54aba8c5..f53cb345ebca 100644
--- a/srcpkgs/lua52/template
+++ b/srcpkgs/lua52/template
@@ -1,9 +1,9 @@
# Template file for 'lua52'
pkgname=lua52
version=5.2.4
-revision=11
+revision=12
wrksrc=lua-${version}
-makedepends="ncurses-devel readline-devel"
+makedepends="readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.2.x)"
maintainer="q66 <daniel@octaforge.org>"
license="MIT"
@@ -52,7 +52,7 @@ do_install() {
}
lua52-devel_package() {
- depends="${makedepends} lua52>=${version}_${revision}"
+ depends="lua52>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.2
From 2b51e1ff32fe3eddb00d00c90201860dd111339e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:46:49 -0300
Subject: [PATCH 3/4] lua53: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua53-devel doesn't need to depend on their devel packages.
The package has listed these dependencies explicitly for a long time (at
least before 2013), so it being there until today seems to be more of a
historical artifact then for an actual reason.
While we are here, remove ncurses-devel from makedepends, since it's no
longer used by the lua build system (this doesn't make a huge
difference, because readline-devel still pulls it in).
53
---
srcpkgs/lua53/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/lua53/template b/srcpkgs/lua53/template
index 098d700bac82..7a923690a566 100644
--- a/srcpkgs/lua53/template
+++ b/srcpkgs/lua53/template
@@ -1,9 +1,9 @@
# Template file for 'lua53'
pkgname=lua53
version=5.3.5
-revision=6
+revision=7
wrksrc=lua-${version}
-makedepends="ncurses-devel readline-devel"
+makedepends="readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.3.x)"
maintainer="q66 <daniel@octaforge.org>"
license="MIT"
@@ -58,7 +58,7 @@ do_install() {
}
lua53-devel_package() {
- depends="${makedepends} lua53>=${version}_${revision}"
+ depends="lua53>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.3
From 8248c727a86ad614560db61da2d8ab29d8c9eb23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Tue, 18 May 2021 23:49:53 -0300
Subject: [PATCH 4/4] lua54: -devel only depends on self.
Only the lua binary depends on libreadline and ncurses, not the library,
so lua54-devel doesn't need to depend on their devel packages.
While we are here, remove ncurses-devel from makedepends, since it's no
longer used by the lua build system (this doesn't make a huge
difference, because readline-devel still pulls it in).
---
srcpkgs/lua54/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/lua54/template b/srcpkgs/lua54/template
index 47d4425cd63f..1abbe11246f1 100644
--- a/srcpkgs/lua54/template
+++ b/srcpkgs/lua54/template
@@ -1,9 +1,9 @@
# Template file for 'lua54'
pkgname=lua54
version=5.4.3
-revision=1
+revision=2
wrksrc=lua-${version}
-makedepends="ncurses-devel readline-devel"
+makedepends="readline-devel"
short_desc="Powerful, fast, lightweight, embeddable scripting language (5.4.x)"
maintainer="q66 <daniel@octaforge.org>"
license="MIT"
@@ -53,7 +53,7 @@ do_install() {
}
lua54-devel_package() {
- depends="${makedepends} lua54>=${version}_${revision}"
+ depends="lua54>=${version}_${revision}"
short_desc+=" - development files"
alternatives="
lua-devel:lua:/usr/share/doc/lua5.4
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Merged]: Trim down lua*-devel dependencies
2021-05-19 2:51 [PR PATCH] Trim down lua*-devel dependencies ericonr
` (5 preceding siblings ...)
2021-05-20 3:10 ` [PR PATCH] [Updated] " ericonr
@ 2021-05-20 3:47 ` ericonr
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-05-20 3:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]
There's a merged pull request on the void-packages repository
Trim down lua*-devel dependencies
https://github.com/void-linux/void-packages/pull/30982
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
@q66
^ permalink raw reply [flat|nested] 8+ messages in thread