Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] socklog-void: remove INSTALL.msg.
@ 2021-04-08  2:26 ericonr
  2021-05-09 22:52 ` [PR PATCH] [Updated] " ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: ericonr @ 2021-04-08  2:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages sock
https://github.com/void-linux/void-packages/pull/30087

socklog-void: remove INSTALL.msg.
All this information is already listed in
https://docs.voidlinux.org/config/services/logging.html

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30087.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sock-30087.patch --]
[-- Type: text/x-diff, Size: 1498 bytes --]

From 9ccb936ec3973f0cd18d95a89546c6ef78dc1569 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Wed, 7 Apr 2021 23:25:49 -0300
Subject: [PATCH] socklog-void: remove INSTALL.msg.

All this information is already listed in
https://docs.voidlinux.org/config/services/logging.html
---
 srcpkgs/socklog-void/INSTALL.msg | 13 -------------
 srcpkgs/socklog-void/template    |  2 +-
 2 files changed, 1 insertion(+), 14 deletions(-)
 delete mode 100644 srcpkgs/socklog-void/INSTALL.msg

diff --git a/srcpkgs/socklog-void/INSTALL.msg b/srcpkgs/socklog-void/INSTALL.msg
deleted file mode 100644
index 7199e4dfa034..000000000000
--- a/srcpkgs/socklog-void/INSTALL.msg
+++ /dev/null
@@ -1,13 +0,0 @@
-To enable socklog-void, start the following runit services, and
-ensure no other syslogd is running:
-
-    * socklog-unix
-    * nanoklogd
-
-Logs reside in /var/log/socklog/*, use svlogtail for simple access.
-
-To access logs as ordinary user, add yourself to group socklog:
-
-    $ sudo usermod -a -G socklog $USER
-
-and then re-login to make it effective.
diff --git a/srcpkgs/socklog-void/template b/srcpkgs/socklog-void/template
index 7bf186780174..637184d1862b 100644
--- a/srcpkgs/socklog-void/template
+++ b/srcpkgs/socklog-void/template
@@ -1,7 +1,7 @@
 # Template file for 'socklog-void'
 pkgname=socklog-void
 version=20200115
-revision=1
+revision=2
 build_style=gnu-makefile
 system_groups="socklog"
 make_dirs="/var/log/socklog 2750 root socklog"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] socklog-void: remove INSTALL.msg.
  2021-04-08  2:26 [PR PATCH] socklog-void: remove INSTALL.msg ericonr
@ 2021-05-09 22:52 ` ericonr
  2021-05-09 22:53 ` ericonr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-05-09 22:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages sock
https://github.com/void-linux/void-packages/pull/30087

socklog-void: remove INSTALL.msg.
All this information is already listed in
https://docs.voidlinux.org/config/services/logging.html

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30087.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sock-30087.patch --]
[-- Type: text/x-diff, Size: 1617 bytes --]

From b4e5ee209c14999d8c8e7040f69203b28013279f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Wed, 7 Apr 2021 23:25:49 -0300
Subject: [PATCH] socklog-void: remove INSTALL.msg.

All this information is already listed in [1]
as of commit [2].

[1] https://docs.voidlinux.org/config/services/logging.html
[2] https://github.com/void-linux/void-docs/commit/65fe7f527eb5308ade3e8387ff49b4debb507c12
---
 srcpkgs/socklog-void/INSTALL.msg | 13 -------------
 srcpkgs/socklog-void/template    |  2 +-
 2 files changed, 1 insertion(+), 14 deletions(-)
 delete mode 100644 srcpkgs/socklog-void/INSTALL.msg

diff --git a/srcpkgs/socklog-void/INSTALL.msg b/srcpkgs/socklog-void/INSTALL.msg
deleted file mode 100644
index 7199e4dfa034..000000000000
--- a/srcpkgs/socklog-void/INSTALL.msg
+++ /dev/null
@@ -1,13 +0,0 @@
-To enable socklog-void, start the following runit services, and
-ensure no other syslogd is running:
-
-    * socklog-unix
-    * nanoklogd
-
-Logs reside in /var/log/socklog/*, use svlogtail for simple access.
-
-To access logs as ordinary user, add yourself to group socklog:
-
-    $ sudo usermod -a -G socklog $USER
-
-and then re-login to make it effective.
diff --git a/srcpkgs/socklog-void/template b/srcpkgs/socklog-void/template
index 7bf186780174..637184d1862b 100644
--- a/srcpkgs/socklog-void/template
+++ b/srcpkgs/socklog-void/template
@@ -1,7 +1,7 @@
 # Template file for 'socklog-void'
 pkgname=socklog-void
 version=20200115
-revision=1
+revision=2
 build_style=gnu-makefile
 system_groups="socklog"
 make_dirs="/var/log/socklog 2750 root socklog"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: socklog-void: remove INSTALL.msg.
  2021-04-08  2:26 [PR PATCH] socklog-void: remove INSTALL.msg ericonr
  2021-05-09 22:52 ` [PR PATCH] [Updated] " ericonr
@ 2021-05-09 22:53 ` ericonr
  2021-05-09 22:54 ` the-maldridge
  2021-05-22  2:34 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-05-09 22:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30087#issuecomment-835920562

Comment:
@void-linux/pkg-committers anyone against?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: socklog-void: remove INSTALL.msg.
  2021-04-08  2:26 [PR PATCH] socklog-void: remove INSTALL.msg ericonr
  2021-05-09 22:52 ` [PR PATCH] [Updated] " ericonr
  2021-05-09 22:53 ` ericonr
@ 2021-05-09 22:54 ` the-maldridge
  2021-05-22  2:34 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: the-maldridge @ 2021-05-09 22:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/30087#issuecomment-835921258

Comment:
Seems fine to me.  I've always thought the log message was a little weird since anyone using socklog probably has a decent idea of what they're doing.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: socklog-void: remove INSTALL.msg.
  2021-04-08  2:26 [PR PATCH] socklog-void: remove INSTALL.msg ericonr
                   ` (2 preceding siblings ...)
  2021-05-09 22:54 ` the-maldridge
@ 2021-05-22  2:34 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-05-22  2:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

There's a merged pull request on the void-packages repository

socklog-void: remove INSTALL.msg.
https://github.com/void-linux/void-packages/pull/30087

Description:
All this information is already listed in
https://docs.voidlinux.org/config/services/logging.html

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-22  2:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08  2:26 [PR PATCH] socklog-void: remove INSTALL.msg ericonr
2021-05-09 22:52 ` [PR PATCH] [Updated] " ericonr
2021-05-09 22:53 ` ericonr
2021-05-09 22:54 ` the-maldridge
2021-05-22  2:34 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).