* Re: [PR PATCH] [Updated] [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
@ 2021-05-25 2:09 ` noarchwastaken
2021-05-25 2:11 ` noarchwastaken
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: noarchwastaken @ 2021-05-25 2:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]
There is an updated pull request by noarchwastaken against master on the void-packages repository
https://github.com/noarchwastaken/void-packages linux-firmware-20210518
https://github.com/void-linux/void-packages/pull/31105
[RFC] linux-firmware: pull from commit hash instead of tag
This would enable faster support for new hardware, and avoid waiting for (possibly) two months just for `linux-firmware` to tag.
One can ask for hardware support with firmware not tagged yet but present in master, and we can update the commit hash to pull in that new firmware.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31105.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-firmware-20210518-31105.patch --]
[-- Type: text/x-diff, Size: 1427 bytes --]
From a41ff02cf72fe622afe4df080fadab6f88deffd0 Mon Sep 17 00:00:00 2001
From: noarchwastaken <noarch@n0ar.ch>
Date: Mon, 24 May 2021 21:51:53 -0400
Subject: [PATCH] linux-firmware: update to 20210518.
---
srcpkgs/linux-firmware/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/linux-firmware/template b/srcpkgs/linux-firmware/template
index 66358c052182..5a9945cdce7d 100644
--- a/srcpkgs/linux-firmware/template
+++ b/srcpkgs/linux-firmware/template
@@ -1,14 +1,16 @@
# Template file for 'linux-firmware'
pkgname=linux-firmware
-version=20210511
+version=20210518
revision=1
+_commit=f8462923ed8fc874f770b8c6dfad49d39b381f14
depends="${pkgname}-amd>=${version}_${revision} ${pkgname}-network>=${version}_${revision}"
short_desc="Binary firmware blobs for the Linux kernel"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="See /usr/share/licenses/${pkgname}"
homepage="https://www.kernel.org/"
-distfiles="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=4c38e6a15775e2911e60898804f1d5720f8e3992a79487a5c1b2250df49a11c4
+distfiles="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/snapshot/${pkgname}-${_commit}.tar.gz"
+wrksrc="${pkgname}-${_commit}"
+checksum=d88e207528b49e7ddc75cd370f8b7733f0e62ef586bb0d8b8778264fd60837a0
python_version=3
nostrip=yes
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Updated] [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
2021-05-25 2:09 ` [PR PATCH] [Updated] " noarchwastaken
@ 2021-05-25 2:11 ` noarchwastaken
2021-05-25 3:36 ` abenson
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: noarchwastaken @ 2021-05-25 2:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]
There is an updated pull request by noarchwastaken against master on the void-packages repository
https://github.com/noarchwastaken/void-packages linux-firmware-20210518
https://github.com/void-linux/void-packages/pull/31105
[RFC] linux-firmware: pull from commit hash instead of tag
This would enable faster support for new hardware, and avoid waiting for (possibly) two months just for `linux-firmware` to tag.
One can ask for hardware support with firmware not tagged yet but present in master, and we can update the commit hash to pull in that new firmware.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31105.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-firmware-20210518-31105.patch --]
[-- Type: text/x-diff, Size: 1430 bytes --]
From 497e5214bf05ffd70eb45c646ed75dce207148f2 Mon Sep 17 00:00:00 2001
From: noarchwastaken <noarch@n0ar.ch>
Date: Mon, 24 May 2021 21:51:53 -0400
Subject: [PATCH] linux-firmware: update to 20210518.
---
srcpkgs/linux-firmware/template | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/linux-firmware/template b/srcpkgs/linux-firmware/template
index 66358c052182..3e6728b8d572 100644
--- a/srcpkgs/linux-firmware/template
+++ b/srcpkgs/linux-firmware/template
@@ -1,14 +1,17 @@
# Template file for 'linux-firmware'
pkgname=linux-firmware
-version=20210511
+version=20210518
revision=1
+_commit=f8462923ed8fc874f770b8c6dfad49d39b381f14
+wrksrc="${pkgname}-${_commit}"
depends="${pkgname}-amd>=${version}_${revision} ${pkgname}-network>=${version}_${revision}"
short_desc="Binary firmware blobs for the Linux kernel"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="See /usr/share/licenses/${pkgname}"
homepage="https://www.kernel.org/"
-distfiles="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=4c38e6a15775e2911e60898804f1d5720f8e3992a79487a5c1b2250df49a11c4
+distfiles="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/snapshot/${pkgname}-${_commit}.tar.gz"
+
+checksum=d88e207528b49e7ddc75cd370f8b7733f0e62ef586bb0d8b8778264fd60837a0
python_version=3
nostrip=yes
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
2021-05-25 2:09 ` [PR PATCH] [Updated] " noarchwastaken
2021-05-25 2:11 ` noarchwastaken
@ 2021-05-25 3:36 ` abenson
2021-05-25 3:36 ` [PR REVIEW] " abenson
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: abenson @ 2021-05-25 3:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#issuecomment-847504051
Comment:
I'm not sure. I think in general we prefer to stick to tags.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (2 preceding siblings ...)
2021-05-25 3:36 ` abenson
@ 2021-05-25 3:36 ` abenson
2021-05-25 3:42 ` [PR PATCH] [Updated] " noarchwastaken
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: abenson @ 2021-05-25 3:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#discussion_r638428571
Comment:
Remove the space here
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Updated] [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (3 preceding siblings ...)
2021-05-25 3:36 ` [PR REVIEW] " abenson
@ 2021-05-25 3:42 ` noarchwastaken
2021-05-25 3:48 ` ericonr
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: noarchwastaken @ 2021-05-25 3:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1973 bytes --]
There is an updated pull request by noarchwastaken against master on the void-packages repository
https://github.com/noarchwastaken/void-packages linux-firmware-20210518
https://github.com/void-linux/void-packages/pull/31105
[RFC] linux-firmware: pull from commit hash instead of tag
This would enable faster support for new hardware, and avoid waiting for (possibly) two months just for `linux-firmware` to tag.
One can ask for hardware support with firmware not tagged yet but present in master, and we can update the commit hash along with the date of the commit to pull in that new firmware.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31105.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-firmware-20210518-31105.patch --]
[-- Type: text/x-diff, Size: 1427 bytes --]
From c20eeaedc8396ad549d4a31d746e2ceca3cf2481 Mon Sep 17 00:00:00 2001
From: noarchwastaken <noarch@n0ar.ch>
Date: Mon, 24 May 2021 21:51:53 -0400
Subject: [PATCH] linux-firmware: update to 20210518.
---
srcpkgs/linux-firmware/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/linux-firmware/template b/srcpkgs/linux-firmware/template
index 66358c052182..1c456ef3e206 100644
--- a/srcpkgs/linux-firmware/template
+++ b/srcpkgs/linux-firmware/template
@@ -1,14 +1,16 @@
# Template file for 'linux-firmware'
pkgname=linux-firmware
-version=20210511
+version=20210518
revision=1
+_commit=f8462923ed8fc874f770b8c6dfad49d39b381f14
+wrksrc="${pkgname}-${_commit}"
depends="${pkgname}-amd>=${version}_${revision} ${pkgname}-network>=${version}_${revision}"
short_desc="Binary firmware blobs for the Linux kernel"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="See /usr/share/licenses/${pkgname}"
homepage="https://www.kernel.org/"
-distfiles="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=4c38e6a15775e2911e60898804f1d5720f8e3992a79487a5c1b2250df49a11c4
+distfiles="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/snapshot/${pkgname}-${_commit}.tar.gz"
+checksum=d88e207528b49e7ddc75cd370f8b7733f0e62ef586bb0d8b8778264fd60837a0
python_version=3
nostrip=yes
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (4 preceding siblings ...)
2021-05-25 3:42 ` [PR PATCH] [Updated] " noarchwastaken
@ 2021-05-25 3:48 ` ericonr
2021-05-25 5:46 ` CameronNemo
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-05-25 3:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#issuecomment-847507574
Comment:
I agree with @abenson. If we add this option in order to enable better hw support, I'd rather that the commit hash mode be optional, and we should always favor using the proper tags. Maybe something like `_commit=$version` and optionally one can change `_commit=commit_hash`.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (5 preceding siblings ...)
2021-05-25 3:48 ` ericonr
@ 2021-05-25 5:46 ` CameronNemo
2021-05-25 8:37 ` fosslinux
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: CameronNemo @ 2021-05-25 5:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#issuecomment-847553521
Comment:
firmware is one of the largest updates on some of my systems. Would be a bit annoying if it was constantly bumped.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (6 preceding siblings ...)
2021-05-25 5:46 ` CameronNemo
@ 2021-05-25 8:37 ` fosslinux
2021-05-25 13:21 ` noarchwastaken
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: fosslinux @ 2021-05-25 8:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#issuecomment-847672608
Comment:
I really don't like grabbing arbitrary commits, which are much more likely to be buggy/unstable. Releases/tags generally exist for a reason, I don't see why linux-firmware is an exception. Also we generally don't package git master versions of packages.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (7 preceding siblings ...)
2021-05-25 8:37 ` fosslinux
@ 2021-05-25 13:21 ` noarchwastaken
2021-05-25 13:35 ` noarchwastaken
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: noarchwastaken @ 2021-05-25 13:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
New comment by noarchwastaken on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#issuecomment-847865010
Comment:
> I really don't like grabbing arbitrary commits, which are much more likely to be buggy/unstable. Releases/tags generally exist for a reason, I don't see why linux-firmware is an exception. Also we generally don't package git master versions of packages.
I do see `linux-firmware` to be an exception though, it's simply a collection of non-free blobs, and it doesn't seem like that there's a "stabilizing" process anywhere.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (8 preceding siblings ...)
2021-05-25 13:21 ` noarchwastaken
@ 2021-05-25 13:35 ` noarchwastaken
2022-04-15 16:09 ` tibequadorian
2022-04-15 16:50 ` [PR PATCH] [Closed]: " paper42
11 siblings, 0 replies; 13+ messages in thread
From: noarchwastaken @ 2021-05-25 13:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
New comment by noarchwastaken on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#issuecomment-847875600
Comment:
We can also consider backporting important updates instead of pulling from commits:
https://github.com/archlinux/svntogit-packages/commit/efd0038415c34c1e9aa2d605152b5471c04a2fdd
For example, this commit in Arch `linux-firmware` backports a bluetooth fix (apparently), enables support for RX 6700 series GPU (which many may buy because there's no choice today anyways) and a computing chip from AMD.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (9 preceding siblings ...)
2021-05-25 13:35 ` noarchwastaken
@ 2022-04-15 16:09 ` tibequadorian
2022-04-15 16:50 ` [PR PATCH] [Closed]: " paper42
11 siblings, 0 replies; 13+ messages in thread
From: tibequadorian @ 2022-04-15 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/31105#issuecomment-1100202062
Comment:
Can this be closed? This PR is very outdated and didn't get much approval either.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Closed]: [RFC] linux-firmware: pull from commit hash instead of tag
2021-05-25 2:07 [PR PATCH] [RFC] linux-firmware: pull from commit hash instead of tag noarchwastaken
` (10 preceding siblings ...)
2022-04-15 16:09 ` tibequadorian
@ 2022-04-15 16:50 ` paper42
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2022-04-15 16:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]
There's a closed pull request on the void-packages repository
[RFC] linux-firmware: pull from commit hash instead of tag
https://github.com/void-linux/void-packages/pull/31105
Description:
This would enable faster support for new hardware, and avoid waiting for (possibly) two months just for `linux-firmware` to tag.
One can ask for hardware support with firmware not tagged yet but present in master, and we can update the commit hash along with the date of the commit to pull in that new firmware.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 13+ messages in thread