From: noarchwastaken <noarchwastaken@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: drawio-desktop-14.6.13
Date: Sat, 29 May 2021 05:46:37 +0200 [thread overview]
Message-ID: <20210529034637.hZIiPjbAObkwCBnepB9tgwsR7CIfU1bE3SyCukfGXkU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31195@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]
New comment by noarchwastaken on void-packages repository
https://github.com/void-linux/void-packages/pull/31195#issuecomment-850763042
Comment:
> All these `find` and `for` loops make that template quite ugly to read imo.
Most of these are just to keep the destdir clean; [The AUR package](https://aur.archlinux.org/packages/drawio-desktop/) that I'm referencing from is pretty cursed in some places, I tweaked it significantly but kept the cleanup process.
I'm pretty sure everything will work fine without the cleanup; but the size of the produced package might be a tiny bit bigger.
Your opinion on removing that bit for extra readability?
> Maybe electron builder can be abused to provide a more usable directory structure.
I had a peek at your `Rocket.Chat-Desktop` package, it seems like Rocket.Chat supports `electron-builder` OOTB so you can simply `yarn run electron-builder ...` to build it.
However `draw.io` doesn't seem to support it, so I might have to write an `electron-builder.json` and so on...
> Regarding naming an so, you could just take a look at the official '.deb' or '.rpm' and copy the naming from there.
The official `.deb` and `.rpm` are pretty much just uncompressed appimage, installed in `/opt`. They still use `drawio`, so I think I'm fine here.
next prev parent reply other threads:[~2021-05-29 3:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 19:52 [PR PATCH] " noarchwastaken
2021-05-28 20:29 ` [PR PATCH] [Updated] " noarchwastaken
2021-05-28 20:38 ` noarchwastaken
2021-05-28 20:59 ` noarchwastaken
2021-05-28 21:12 ` noarchwastaken
2021-05-29 1:41 ` Johnnynator
2021-05-29 3:46 ` noarchwastaken [this message]
2021-05-30 4:58 ` [PR PATCH] [Updated] " noarchwastaken
2021-06-13 3:01 ` noarchwastaken
2021-06-13 3:03 ` noarchwastaken
2021-06-13 3:04 ` noarchwastaken
2021-06-13 3:14 ` [PR PATCH] [Updated] " noarchwastaken
2021-06-13 3:51 ` noarchwastaken
2022-05-21 1:59 ` github-actions
2022-06-04 2:08 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210529034637.hZIiPjbAObkwCBnepB9tgwsR7CIfU1bE3SyCukfGXkU@z \
--to=noarchwastaken@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).