[PR PATCH] nnn: add desktop entry

[PR PATCH] nnn: add desktop entry

[anubhavkini]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

There is a new pull request by anubhavkini against master on the void-packages repository

https://github.com/anubhavkini/void-packages nnn
https://github.com/void-linux/void-packages/pull/31204

nnn: add desktop entry
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31204.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-31204.patch --]
[-- Type: text/x-diff, Size: 818 bytes --]

From 693957c7dbe757bb5f00441bb560333724915db8 Mon Sep 17 00:00:00 2001
From: Anubhav Kini <anubhavkini@gmail.com>
Date: Sat, 29 May 2021 16:25:29 +0530
Subject: [PATCH] nnn: add desktop entry

---
 srcpkgs/nnn/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index 467ad2ec0dea..6d84a231dc9b 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,7 +1,7 @@
 # Template file for 'nnn'
 pkgname=nnn
 version=4.0
-revision=1
+revision=2
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
 makedepends="ncurses-devel readline-devel"
@@ -21,5 +21,7 @@ post_install() {
 	vinstall misc/auto-completion/fish/nnn.fish 644 \
 		usr/share/fish/vendor_completions.d
 
+	PREFIX="$DESTDIR/usr" make install-desktop
+
 	vlicense LICENSE
 }

Re: nnn: add desktop entry

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/31204#issuecomment-850814998

Comment:
This looks kinda wrong, it respects both `PREFIX` and `DESTDIR`, should probably just use `make_install_target="install install-desktop"` instead.

Re: [PR PATCH] [Updated] nnn: add desktop entry

[anubhavkini]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

There is an updated pull request by anubhavkini against master on the void-packages repository

https://github.com/anubhavkini/void-packages nnn
https://github.com/void-linux/void-packages/pull/31204

nnn: add desktop entry
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31204.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-31204.patch --]
[-- Type: text/x-diff, Size: 717 bytes --]

From 34b6339e90f9d14bcff36f6c7e24e3d5282e703a Mon Sep 17 00:00:00 2001
From: Anubhav Kini <anubhavkini@gmail.com>
Date: Sat, 29 May 2021 17:25:27 +0530
Subject: [PATCH] nnn: add desktop entry

---
 srcpkgs/nnn/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index 467ad2ec0dea..7d905198b749 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,8 +1,9 @@
 # Template file for 'nnn'
 pkgname=nnn
 version=4.0
-revision=1
+revision=2
 build_style=gnu-makefile
+make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
 makedepends="ncurses-devel readline-devel"
 short_desc="Missing terminal file browser for X"

Re: nnn: add desktop entry

[anubhavkini]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by anubhavkini on void-packages repository

https://github.com/void-linux/void-packages/pull/31204#issuecomment-850822251

Comment:
Yeah, I've changed it now.

Re: [PR PATCH] [Merged]: nnn: add desktop entry

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

There's a merged pull request on the void-packages repository

nnn: add desktop entry
https://github.com/void-linux/void-packages/pull/31204

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->