Re: python3-dotenv: update to 0.17.1.

Re: python3-dotenv: update to 0.17.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31470#issuecomment-861792886

Comment:
> The only package that depends on this is docker-compose. I don't think it needs to be rebuilt since it's a python3 module. Am I correct?

yes :)

Do you have `ci-skip` somewhere?

Re: python3-dotenv: update to 0.17.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31470#issuecomment-861793074

Comment:
I assume you've tested docker-compose with this?

Re: python3-dotenv: update to 0.17.1.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 2186 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/31470#issuecomment-862026550

Comment:
@ericonr

I didn't use ci-skip anywhere. Will force push a commit and see if it triggers the builds.


I have tested it. I use it on my machine for development. Here is a short example:

```
~/docker-compose-test
❯ xbps-query python3-dotenv | grep ver
pkgver: python3-dotenv-0.17.1_1

~/docker-compose-test
❯ cat docker-compose.yml
version: "3.9"

services:
  hello:
    container_name: ${NAME}
    image: hello-world:latest

~/docker-compose-test
❯ cat .env
NAME=hello-world-container

~/docker-compose-test
❯ sudo docker-compose up
Starting hello-world-container ... done
Attaching to hello-world-container
hello-world-container |
hello-world-container | Hello from Docker!
hello-world-container | This message shows that your installation appears to be working correctly.
hello-world-container |
hello-world-container | To generate this message, Docker took the following steps:
hello-world-container |  1. The Docker client contacted the Docker daemon.
hello-world-container |  2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
hello-world-container |     (amd64)
hello-world-container |  3. The Docker daemon created a new container from that image which runs the
hello-world-container |     executable that produces the output you are currently reading.
hello-world-container |  4. The Docker daemon streamed that output to the Docker client, which sent it
hello-world-container |     to your terminal.
hello-world-container |
hello-world-container | To try something more ambitious, you can run an Ubuntu container with:
hello-world-container |  $ docker run -it ubuntu bash
hello-world-container |
hello-world-container | Share images, automate workflows, and more with a free Docker ID:
hello-world-container |  https://hub.docker.com/
hello-world-container |
hello-world-container | For more examples and ideas, visit:
hello-world-container |  https://docs.docker.com/get-started/
hello-world-container |
hello-world-container exited with code 0
```

Re: python3-dotenv: update to 0.17.1.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/31470#issuecomment-862035041

Comment:
@ericonr So some of the tests are failing because the test suite is using `python3-sh` to call `dotenv` which is an executable installed by this package which is not found. I am guessing it's not installed or it's not in the $PATH. Any idea what I can do about this?

Re: python3-dotenv: update to 0.17.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31470#issuecomment-862876928

Comment:
If you can figure out a way to skip those tests, I think we can push the package with tests enabled (might be missing `python3-ipython` in `checkdepends` though.

Otherwise, `make_check=no` with a comment is a good hammer to disable tests.

Re: python3-dotenv: update to 0.17.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31470#issuecomment-864977609

Comment:
Assuming it works, it seems 0.18.0 is out D:

Re: python3-dotenv: update to 0.17.1.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/31470#issuecomment-866566838

Comment:
@ericonr I will update it to 0.18 in a bit.