From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: move update-check out of xbps-src
Date: Wed, 23 Jun 2021 19:35:07 +0200 [thread overview]
Message-ID: <20210623173507.XS9o1EjlNW8B9RpYlWtZu52GvXNVoIOg1CrFUo0zXyc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31602@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/31602#issuecomment-867029335
Comment:
> check only distfiles
homepage and site are important too
> remove all variable except pkgname and version from distfiles
There are templates that use wrksrc, _distver being custom transformation of version and more.
> update-check doesn't need xbps
It uses dewey version sort with `xbps-uhelper cmpver` and needs to use it more. Current [sort -Vu](https://github.com/void-linux/void-packages/blob/471c2d1dd4af758dcd5a450f498439dc25045e34/common/xbps-src/shutils/update_check.sh#L179) sorts beta releases as greater than final releases - so that xupdate updates templates that for some reasons are in `2beta1` version to `2beta2` rather than `2`.
> requires [...] XBPS_ALLOW_CHROOT_BREAKOUT
Is this problem?
> could speed things up a bit
Test was done on templates with `0.` prepended to version to force matches.
There are around 60 packages for which new versions are not detected after that change as for now, not counting R and ruby packages defining distfiles in build style.
Run time of void-updates -p 5 went down by 5min, from 2h 25min to 2h 20min. On same machine, `xbps-src show` for all packages takes around 10 min - limit of what can be expected to improve.
Roughly half of execution time was spent in void-updates' `get_date` - but this is not representative, as there are more found versions that usually.
My conclusion is that this is micro-optimization that doesn't touch real problem pointed by maldridge - templates being bash programs depending on lot of xbps-src code that are complex to really understand, hard or slow to process for all usecases, like cycle detection.
next prev parent reply other threads:[~2021-06-23 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 1:11 [PR PATCH] " sgn
2021-06-22 2:16 ` the-maldridge
2021-06-22 7:13 ` Gottox
2021-06-22 7:42 ` the-maldridge
2021-06-22 11:05 ` sgn
2021-06-23 16:36 ` [PR PATCH] [Updated] " sgn
2021-06-23 17:35 ` Chocimier [this message]
2022-05-23 2:12 ` github-actions
2022-06-06 2:14 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623173507.XS9o1EjlNW8B9RpYlWtZu52GvXNVoIOg1CrFUo0zXyc@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).