* [PR PATCH] foot: update to 1.8.0
@ 2021-06-27 2:50 cinerea0
2021-06-27 3:40 ` [PR REVIEW] " ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: cinerea0 @ 2021-06-27 2:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]
There is a new pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages foot
https://github.com/void-linux/void-packages/pull/31671
foot: update to 1.8.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31671.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-foot-31671.patch --]
[-- Type: text/x-diff, Size: 1569 bytes --]
From 216624b2a14f96c778c2769b1f0246efa77052b7 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Sat, 26 Jun 2021 22:48:43 -0400
Subject: [PATCH] foot: update to 1.8.0
---
| 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
--git a/srcpkgs/foot/template b/srcpkgs/foot/template
index c3b77f690e24..1258560d9fae 100644
--- a/srcpkgs/foot/template
+++ b/srcpkgs/foot/template
@@ -1,13 +1,13 @@
# Template file for 'foot'
pkgname=foot
-version=1.7.2
+version=1.8.0
revision=1
wrksrc=$pkgname
build_style=meson
configure_args="-Dwerror=false"
hostmakedepends="pkg-config scdoc wayland-devel"
-makedepends="fcft-devel libxkbcommon-devel ncurses-devel tllist wayland-devel
- wayland-protocols"
+makedepends="fcft-devel libutf8proc-devel libxkbcommon-devel ncurses-devel tllist
+ wayland-devel wayland-protocols"
depends="${pkgname}-terminfo>=${version}_${revision}"
short_desc="Fast, lightweight and minimalistic Wayland terminal emulator"
maintainer="Isaac Freund <ifreund@ifreund.xyz>"
@@ -15,7 +15,10 @@ license="MIT"
homepage="https://codeberg.org/dnkl/foot"
changelog="https://codeberg.org/dnkl/foot/src/branch/master/CHANGELOG.md"
distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=0c5fa72a315b65100dfb8b7343212535e75e990b2a9500e028c6078c7915eb8a
+checksum=9269acfbef40cb284590de3bf70fc67997ffb6361dec4b4dddae7cdbf4ad6490
+
+# FIXME: Not being set automatically
+CFLAGS+="-I$XBPS_CROSS_BASE/usr/include/libutf8proc"
post_install() {
rm -f ${DESTDIR}/usr/share/doc/foot/LICENSE
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] foot: update to 1.8.0
2021-06-27 2:50 [PR PATCH] foot: update to 1.8.0 cinerea0
@ 2021-06-27 3:40 ` ericonr
2021-06-27 3:57 ` ericonr
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-06-27 3:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31671#discussion_r659256441
Comment:
You can (and should) just set it to `CFLAGS`. And when using `+=` with such variables, remember to add the space: `+=" -I..."`
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] foot: update to 1.8.0
2021-06-27 2:50 [PR PATCH] foot: update to 1.8.0 cinerea0
2021-06-27 3:40 ` [PR REVIEW] " ericonr
@ 2021-06-27 3:57 ` ericonr
2021-06-27 4:14 ` [PR PATCH] [Updated] " cinerea0
2021-06-27 7:15 ` [PR PATCH] [Closed]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-06-27 3:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31671#discussion_r659257712
Comment:
The pkg config file has: `includedir=${prefix}/include`, which is either wrong or incompatible with what `foot` expects.
https://github.com/JuliaLang/julia/blob/d7d2b0c692eb6ad409d7193ba8d9d42972cbf182/src/flisp/julia_extensions.c#L6 uses it like foot does, so that's the "correct" usage. And we pass a similar arg in the Julia template: `UTF8PROC_INC='${XBPS_CROSS_BASE}/usr/include/libutf8proc'`
I will try to patch the pc file and see if our other packages don't break (they almost certainly won't, since `-I/usr/include` is a compiler default and any package doing `#include "libutf8proc/utf8proc.h"` will just keep working). From what I can see, it's our package that's doing broken stuff, since we move the header into a directory but didn't change what the pkg-config file does (the file is in `srcpkgs/libut8proc/files` ;)
https://github.com/JuliaStrings/utf8proc looks even more attractive now, since it ships with its own pc file.
Regarding this specific PR, for accuracy the comment should be `FIXME: our pkg-config file for utf8proc sets the wrong include dir`
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] foot: update to 1.8.0
2021-06-27 2:50 [PR PATCH] foot: update to 1.8.0 cinerea0
2021-06-27 3:40 ` [PR REVIEW] " ericonr
2021-06-27 3:57 ` ericonr
@ 2021-06-27 4:14 ` cinerea0
2021-06-27 7:15 ` [PR PATCH] [Closed]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: cinerea0 @ 2021-06-27 4:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages foot
https://github.com/void-linux/void-packages/pull/31671
foot: update to 1.8.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31671.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-foot-31671.patch --]
[-- Type: text/x-diff, Size: 1597 bytes --]
From db3f7a1d2da6d04d7dea8c7a4aeb636deaae9d09 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Sun, 27 Jun 2021 00:14:30 -0400
Subject: [PATCH] foot: update to 1.8.0
---
| 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
--git a/srcpkgs/foot/template b/srcpkgs/foot/template
index c3b77f690e24..b2a3fa1b5087 100644
--- a/srcpkgs/foot/template
+++ b/srcpkgs/foot/template
@@ -1,13 +1,13 @@
# Template file for 'foot'
pkgname=foot
-version=1.7.2
+version=1.8.0
revision=1
wrksrc=$pkgname
build_style=meson
configure_args="-Dwerror=false"
hostmakedepends="pkg-config scdoc wayland-devel"
-makedepends="fcft-devel libxkbcommon-devel ncurses-devel tllist wayland-devel
- wayland-protocols"
+makedepends="fcft-devel libutf8proc-devel libxkbcommon-devel ncurses-devel tllist
+ wayland-devel wayland-protocols"
depends="${pkgname}-terminfo>=${version}_${revision}"
short_desc="Fast, lightweight and minimalistic Wayland terminal emulator"
maintainer="Isaac Freund <ifreund@ifreund.xyz>"
@@ -15,7 +15,10 @@ license="MIT"
homepage="https://codeberg.org/dnkl/foot"
changelog="https://codeberg.org/dnkl/foot/src/branch/master/CHANGELOG.md"
distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=0c5fa72a315b65100dfb8b7343212535e75e990b2a9500e028c6078c7915eb8a
+checksum=9269acfbef40cb284590de3bf70fc67997ffb6361dec4b4dddae7cdbf4ad6490
+
+# FIXME: our pkg-config file for utf8proc sets the wrong include dir
+CFLAGS="-I$XBPS_CROSS_BASE/usr/include/libutf8proc"
post_install() {
rm -f ${DESTDIR}/usr/share/doc/foot/LICENSE
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: foot: update to 1.8.0
2021-06-27 2:50 [PR PATCH] foot: update to 1.8.0 cinerea0
` (2 preceding siblings ...)
2021-06-27 4:14 ` [PR PATCH] [Updated] " cinerea0
@ 2021-06-27 7:15 ` ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-06-27 7:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
There's a closed pull request on the void-packages repository
foot: update to 1.8.0
https://github.com/void-linux/void-packages/pull/31671
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-27 7:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-27 2:50 [PR PATCH] foot: update to 1.8.0 cinerea0
2021-06-27 3:40 ` [PR REVIEW] " ericonr
2021-06-27 3:57 ` ericonr
2021-06-27 4:14 ` [PR PATCH] [Updated] " cinerea0
2021-06-27 7:15 ` [PR PATCH] [Closed]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).