From: Logarithmus <Logarithmus@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: zam-plugins-3.14
Date: Sun, 27 Jun 2021 18:56:00 +0200 [thread overview]
Message-ID: <20210627165600.V09wb6rwH1Xkfx8jHswYOq-IaPAQw9uALkXEdnfnq6g@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31665@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039
Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.
There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push
> If there are too many submodules, reconsider if this is really packageable.
I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.
AFAIK this package has a single submodule, which makes your complaints even more irrelevant.
Yes, surely it's possibly to manually extract commit hashes of each submodule and hardcode them into `template` file and then also manually correct them after each new version is released, but why do this unneded manual work if you can just assign it to `git`?
And AFAIK GitHub doesn't allow you to download a tarball for an arbitrary commit, only for a tag.
next prev parent reply other threads:[~2021-06-27 16:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 16:00 [PR PATCH] " Logarithmus
2021-06-26 19:30 ` [PR REVIEW] " ericonr
2021-06-26 19:30 ` ericonr
2021-06-26 19:30 ` ericonr
2021-06-26 19:30 ` ericonr
2021-06-26 19:30 ` ericonr
2021-06-27 16:00 ` Logarithmus
2021-06-27 16:00 ` Logarithmus
2021-06-27 16:02 ` Logarithmus
2021-06-27 16:36 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 16:50 ` [PR REVIEW] " Logarithmus
2021-06-27 16:50 ` Logarithmus
2021-06-27 16:50 ` Logarithmus
2021-06-27 16:55 ` Logarithmus
2021-06-27 16:56 ` Logarithmus [this message]
2021-06-27 16:57 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 17:07 ` [PR REVIEW] " Logarithmus
2021-06-27 17:29 ` Logarithmus
2021-06-27 17:30 ` Logarithmus
2021-06-27 17:51 ` ericonr
2021-06-27 17:51 ` ericonr
2021-06-27 17:53 ` Logarithmus
2021-06-27 18:01 ` ericonr
2021-06-27 18:33 ` Logarithmus
2021-06-27 18:45 ` ericonr
2021-06-27 19:02 ` Duncaen
2021-06-27 19:04 ` Logarithmus
2021-06-27 19:23 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 19:56 ` Logarithmus
2021-06-27 20:35 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 21:15 ` Logarithmus
2021-06-27 21:32 ` Logarithmus
2021-06-27 21:37 ` Logarithmus
2021-06-27 21:50 ` Logarithmus
2021-06-27 21:59 ` Logarithmus
2021-06-28 0:21 ` Logarithmus
2022-05-23 2:12 ` github-actions
2022-06-06 2:14 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210627165600.V09wb6rwH1Xkfx8jHswYOq-IaPAQw9uALkXEdnfnq6g@z \
--to=logarithmus@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).