[PR PATCH] vips: update to 8.11.0.

[PR PATCH] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]

There is a new pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages vips
https://github.com/void-linux/void-packages/pull/31685

vips: update to 8.11.0.
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31685.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vips-31685.patch --]
[-- Type: text/x-diff, Size: 1493 bytes --]

From d8b0e0f9a98109b74ea34ada1fb51389685d89e5 Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Sun, 27 Jun 2021 20:32:35 +0200
Subject: [PATCH] vips: update to 8.11.0.

---
 srcpkgs/vips/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/vips/template b/srcpkgs/vips/template
index ccb0b01441ba..6a6dee350cf2 100644
--- a/srcpkgs/vips/template
+++ b/srcpkgs/vips/template
@@ -1,10 +1,14 @@
 # Template file for 'vips'
 pkgname=vips
-version=8.10.6
+version=8.11.0
 revision=1
 build_style=gnu-configure
 build_helper=gir
-configure_args="--enable-introspection=$(vopt_if gir yes no)"
+# TODO: As of version 8.11 vips supports loading its support for OpenSlide, #
+# libheif, Poppler and libMagick backends at rundtime using GModule. Consider
+# tacking advantage of this feature and shipping these modules as optional
+# subpackages.
+configure_args="--enable-introspection=$(vopt_if gir yes no) --disable-modules"
 hostmakedepends="pkgconf"
 makedepends="
  $(vopt_if hdf5 hdf5-devel)
@@ -33,7 +37,7 @@ maintainer="Isaac Freund <ifreund@ifreund.xyz>"
 license="LGPL-2.1-or-later"
 homepage="https://libvips.github.io/libvips/"
 distfiles="https://github.com/libvips/libvips/releases/download/v${version}/vips-${version}.tar.gz"
-checksum=2468088d958e0e2de1be2991ff8940bf45664a826c0dad12342e1804e2805a6e
+checksum=6351dfb99836274a0d74d8054506bf6dc9a8c38bacf208a9c566889dd1ebba0b
 python_version=3
 
 build_options="gir hdf5"

Re: [PR PATCH] [Updated] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

There is an updated pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages vips
https://github.com/void-linux/void-packages/pull/31685

vips: update to 8.11.0.
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31685.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vips-31685.patch --]
[-- Type: text/x-diff, Size: 1491 bytes --]

From 6df650508b115c9f9b75c4487a1745bd6191774d Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Sun, 27 Jun 2021 20:32:35 +0200
Subject: [PATCH] vips: update to 8.11.0.

---
 srcpkgs/vips/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/vips/template b/srcpkgs/vips/template
index ccb0b01441ba..24ede20a5f37 100644
--- a/srcpkgs/vips/template
+++ b/srcpkgs/vips/template
@@ -1,10 +1,14 @@
 # Template file for 'vips'
 pkgname=vips
-version=8.10.6
+version=8.11.0
 revision=1
 build_style=gnu-configure
 build_helper=gir
-configure_args="--enable-introspection=$(vopt_if gir yes no)"
+# TODO: As of version 8.11 vips supports loading its support for OpenSlide,
+# libheif, Poppler and libMagick backends at rundtime using GModule. Consider
+# tacking advantage of this feature and shipping these modules as optional
+# subpackages.
+configure_args="--enable-introspection=$(vopt_if gir yes no) --disable-modules"
 hostmakedepends="pkgconf"
 makedepends="
  $(vopt_if hdf5 hdf5-devel)
@@ -33,7 +37,7 @@ maintainer="Isaac Freund <ifreund@ifreund.xyz>"
 license="LGPL-2.1-or-later"
 homepage="https://libvips.github.io/libvips/"
 distfiles="https://github.com/libvips/libvips/releases/download/v${version}/vips-${version}.tar.gz"
-checksum=2468088d958e0e2de1be2991ff8940bf45664a826c0dad12342e1804e2805a6e
+checksum=6351dfb99836274a0d74d8054506bf6dc9a8c38bacf208a9c566889dd1ebba0b
 python_version=3
 
 build_options="gir hdf5"

Re: [PR REVIEW] vips: update to 8.11.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659827322

Comment:
```suggestion
# libheif, Poppler and libMagick backends at runtime using GModule. Consider
```

Re: [PR REVIEW] vips: update to 8.11.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659827446

Comment:
```suggestion
# taking advantage of this feature and shipping these modules as optional
```

Re: [PR REVIEW] vips: update to 8.11.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659828704

Comment:
Not sure how I feel about this; it would make installing a full vips harder (and would immediately degrade the experience for people who have `vips` installed, unless the core was shunted off to a `vips-core` package or similar). But I don't think the complexity is likely to be worth it.

Re: [PR PATCH] [Updated] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

There is an updated pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages vips
https://github.com/void-linux/void-packages/pull/31685

vips: update to 8.11.0.
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31685.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vips-31685.patch --]
[-- Type: text/x-diff, Size: 1489 bytes --]

From f0773c3bd42207bcddaabd46530c0a829c1c8205 Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Sun, 27 Jun 2021 20:32:35 +0200
Subject: [PATCH] vips: update to 8.11.0.

---
 srcpkgs/vips/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/vips/template b/srcpkgs/vips/template
index ccb0b01441ba..0f5af33dd010 100644
--- a/srcpkgs/vips/template
+++ b/srcpkgs/vips/template
@@ -1,10 +1,14 @@
 # Template file for 'vips'
 pkgname=vips
-version=8.10.6
+version=8.11.0
 revision=1
 build_style=gnu-configure
 build_helper=gir
-configure_args="--enable-introspection=$(vopt_if gir yes no)"
+# TODO: As of version 8.11 vips supports loading its support for OpenSlide,
+# libheif, Poppler and libMagick backends at runtime using GModule. Consider
+# taking advantage of this feature and shipping these modules as optional
+# subpackages.
+configure_args="--enable-introspection=$(vopt_if gir yes no) --disable-modules"
 hostmakedepends="pkgconf"
 makedepends="
  $(vopt_if hdf5 hdf5-devel)
@@ -33,7 +37,7 @@ maintainer="Isaac Freund <ifreund@ifreund.xyz>"
 license="LGPL-2.1-or-later"
 homepage="https://libvips.github.io/libvips/"
 distfiles="https://github.com/libvips/libvips/releases/download/v${version}/vips-${version}.tar.gz"
-checksum=2468088d958e0e2de1be2991ff8940bf45664a826c0dad12342e1804e2805a6e
+checksum=6351dfb99836274a0d74d8054506bf6dc9a8c38bacf208a9c566889dd1ebba0b
 python_version=3
 
 build_options="gir hdf5"

Re: [PR REVIEW] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659852088

Comment:
The `libMagick` dependency is currently not included because one of the major reasons to use vips over ImageMagick is that it is much smaller/cleaner/more auditable and more suited to use with untrusted image inputs.

From the vips readme's [ImageMagick section](https://github.com/libvips/libvips#imagemagick-or-optionally-graphicsmagick):
> If you are going to be using libvips with untrusted images, perhaps in a web server, for example, you should consider the security implications of enabling a package with such a large attack surface.

Re: [PR REVIEW] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659852088

Comment:
The `libMagick` dependency is not included in the vips package we currently ship because one of the major reasons to use vips over ImageMagick is that it is much smaller/cleaner/more auditable and more suited to use with untrusted image inputs.

From the vips readme's [ImageMagick section](https://github.com/libvips/libvips#imagemagick-or-optionally-graphicsmagick):
> If you are going to be using libvips with untrusted images, perhaps in a web server, for example, you should consider the security implications of enabling a package with such a large attack surface.

Re: [PR REVIEW] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659853949

Comment:
Anyhow, I haven't looked into the other libraries they now support loading as modules and I'm not running vips on untrusted images myself so I don't have a very strong opnion on this.

This also isn't likely to make it to the top of my TODO list anytime soon.

Re: [PR REVIEW] vips: update to 8.11.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659873904

Comment:
Can you make this clear in the comment, then? "The module approach would make enabling the imagemagick backend less of a compromise, it could maybe be the only one shunted off into its own subpackage" or somthing to that effect :)

Re: [PR PATCH] [Updated] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

There is an updated pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages vips
https://github.com/void-linux/void-packages/pull/31685

vips: update to 8.11.0.
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31685.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vips-31685.patch --]
[-- Type: text/x-diff, Size: 1825 bytes --]

From 3669b57f4b957d92e705d4284b04283a5c325442 Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Sun, 27 Jun 2021 20:32:35 +0200
Subject: [PATCH] vips: update to 8.11.0.

---
 srcpkgs/vips/template | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/vips/template b/srcpkgs/vips/template
index ccb0b01441ba..56049e393414 100644
--- a/srcpkgs/vips/template
+++ b/srcpkgs/vips/template
@@ -1,10 +1,20 @@
 # Template file for 'vips'
 pkgname=vips
-version=8.10.6
+version=8.11.0
 revision=1
 build_style=gnu-configure
 build_helper=gir
-configure_args="--enable-introspection=$(vopt_if gir yes no)"
+# TODO: As of version 8.11 vips supports loading its support for OpenSlide,
+# libheif, Poppler and libMagick backends at runtime using GModule. Consider
+# taking advantage of this feature and shipping these modules as optional
+# subpackages.
+#
+# In particular, this would make packaging the libMagick backend less of
+# a compromise: vips upstream explictly recommends against enabling it if
+# processing untrused image inputs and punting it to a subpackage would
+# allow void users to make that choice themselves without using this
+# template to build from source.
+configure_args="--enable-introspection=$(vopt_if gir yes no) --disable-modules"
 hostmakedepends="pkgconf"
 makedepends="
  $(vopt_if hdf5 hdf5-devel)
@@ -33,7 +43,7 @@ maintainer="Isaac Freund <ifreund@ifreund.xyz>"
 license="LGPL-2.1-or-later"
 homepage="https://libvips.github.io/libvips/"
 distfiles="https://github.com/libvips/libvips/releases/download/v${version}/vips-${version}.tar.gz"
-checksum=2468088d958e0e2de1be2991ff8940bf45664a826c0dad12342e1804e2805a6e
+checksum=6351dfb99836274a0d74d8054506bf6dc9a8c38bacf208a9c566889dd1ebba0b
 python_version=3
 
 build_options="gir hdf5"

Re: [PR REVIEW] vips: update to 8.11.0.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/31685#discussion_r659879072

Comment:
Done :+1: 

Re: [PR PATCH] [Merged]: vips: update to 8.11.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

There's a merged pull request on the void-packages repository

vips: update to 8.11.0.
https://github.com/void-linux/void-packages/pull/31685

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->