* [PR PATCH] deluge: set config dir to homedir
@ 2021-06-29 1:16 sgn
2021-06-29 1:18 ` [PR PATCH] [Updated] " sgn
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: sgn @ 2021-06-29 1:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]
There is a new pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages deluge-move-config
https://github.com/void-linux/void-packages/pull/31708
deluge: set config dir to homedir
While we're at it, drop priviledge early.
Fix: https://github.com/void-linux/void-packages/issues/31690
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31708.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-deluge-move-config-31708.patch --]
[-- Type: text/x-diff, Size: 848 bytes --]
From f705221785d426b93a98cd265f636178abfe638a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Tue, 29 Jun 2021 08:13:43 +0700
Subject: [PATCH] deluge: set config dir to homedir
While we're at it, drop priviledge early.
Fix: https://github.com/void-linux/void-packages/issues/31690
---
srcpkgs/deluge/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/deluge/template b/srcpkgs/deluge/template
index 283fcd62d7fd..ce2523384e40 100644
--- a/srcpkgs/deluge/template
+++ b/srcpkgs/deluge/template
@@ -1,7 +1,7 @@
# Template file for 'deluge'
pkgname=deluge
version=2.0.3
-revision=10
+revision=11
build_style=python3-module
# TODO package python3-slimit to minify javascript
hostmakedepends="intltool python3-setuptools python3-wheel"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] deluge: set config dir to homedir
2021-06-29 1:16 [PR PATCH] deluge: set config dir to homedir sgn
@ 2021-06-29 1:18 ` sgn
2021-06-29 1:45 ` ericonr
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2021-06-29 1:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages deluge-move-config
https://github.com/void-linux/void-packages/pull/31708
deluge: set config dir to homedir
While we're at it, drop priviledge early.
Fix: https://github.com/void-linux/void-packages/issues/31690
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31708.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-deluge-move-config-31708.patch --]
[-- Type: text/x-diff, Size: 1718 bytes --]
From 875023f4509b357eb7b2e4d16e52364eab8dd8be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Tue, 29 Jun 2021 08:13:43 +0700
Subject: [PATCH] deluge: set config dir to homedir
While we're at it, drop priviledge early.
Fix: https://github.com/void-linux/void-packages/issues/31690
---
srcpkgs/deluge/files/deluge-web/run | 2 +-
srcpkgs/deluge/files/deluged/run | 2 +-
srcpkgs/deluge/template | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/deluge/files/deluge-web/run b/srcpkgs/deluge/files/deluge-web/run
index b90477d7a458..06115d9252b3 100644
--- a/srcpkgs/deluge/files/deluge-web/run
+++ b/srcpkgs/deluge/files/deluge-web/run
@@ -1,3 +1,3 @@
#!/bin/sh
sv check deluged >/dev/null || exit 1
-exec chpst -u deluge:deluge deluge-web -d 2>&1
+exec chpst -u deluge:deluge deluge-web -d -c /var/lib/deluge 2>&1
diff --git a/srcpkgs/deluge/files/deluged/run b/srcpkgs/deluge/files/deluged/run
index 034de7241fd9..a2c8b80eaae5 100644
--- a/srcpkgs/deluge/files/deluged/run
+++ b/srcpkgs/deluge/files/deluged/run
@@ -1,3 +1,3 @@
#!/bin/sh
[ -r ./conf ] && . ./conf
-exec deluged -d -U deluge -g deluge ${OPTS} 2>&1
+exec chpst -u deluge:deluge deluged -d -c /var/lib/deluge ${OPTS} 2>&1
diff --git a/srcpkgs/deluge/template b/srcpkgs/deluge/template
index 283fcd62d7fd..ce2523384e40 100644
--- a/srcpkgs/deluge/template
+++ b/srcpkgs/deluge/template
@@ -1,7 +1,7 @@
# Template file for 'deluge'
pkgname=deluge
version=2.0.3
-revision=10
+revision=11
build_style=python3-module
# TODO package python3-slimit to minify javascript
hostmakedepends="intltool python3-setuptools python3-wheel"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: deluge: set config dir to homedir
2021-06-29 1:16 [PR PATCH] deluge: set config dir to homedir sgn
2021-06-29 1:18 ` [PR PATCH] [Updated] " sgn
@ 2021-06-29 1:45 ` ericonr
2021-07-01 1:38 ` [PR PATCH] [Updated] " sgn
2021-07-01 1:38 ` [PR PATCH] [Merged]: " sgn
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-06-29 1:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31708#issuecomment-870163034
Comment:
Looks pretty reasonable, especially since one of the run scripts already used chpst.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] deluge: set config dir to homedir
2021-06-29 1:16 [PR PATCH] deluge: set config dir to homedir sgn
2021-06-29 1:18 ` [PR PATCH] [Updated] " sgn
2021-06-29 1:45 ` ericonr
@ 2021-07-01 1:38 ` sgn
2021-07-01 1:38 ` [PR PATCH] [Merged]: " sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2021-07-01 1:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages deluge-move-config
https://github.com/void-linux/void-packages/pull/31708
deluge: set config dir to homedir
While we're at it, drop priviledge early.
Fix: https://github.com/void-linux/void-packages/issues/31690
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31708.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-deluge-move-config-31708.patch --]
[-- Type: text/x-diff, Size: 1257 bytes --]
From 8b3b2995aa0bb23d42136ea5c7b12d6a459a957c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Tue, 29 Jun 2021 08:13:43 +0700
Subject: [PATCH] deluge: set config dir to homedir
While we're at it, drop priviledge early.
Fix: https://github.com/void-linux/void-packages/issues/31690
---
srcpkgs/deluge/files/deluged/run | 2 +-
srcpkgs/deluge/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/deluge/files/deluged/run b/srcpkgs/deluge/files/deluged/run
index 034de7241fd9..ac0e7983fafc 100644
--- a/srcpkgs/deluge/files/deluged/run
+++ b/srcpkgs/deluge/files/deluged/run
@@ -1,3 +1,3 @@
#!/bin/sh
[ -r ./conf ] && . ./conf
-exec deluged -d -U deluge -g deluge ${OPTS} 2>&1
+exec chpst -u deluge:deluge deluged -d ${OPTS} 2>&1
diff --git a/srcpkgs/deluge/template b/srcpkgs/deluge/template
index 283fcd62d7fd..ce2523384e40 100644
--- a/srcpkgs/deluge/template
+++ b/srcpkgs/deluge/template
@@ -1,7 +1,7 @@
# Template file for 'deluge'
pkgname=deluge
version=2.0.3
-revision=10
+revision=11
build_style=python3-module
# TODO package python3-slimit to minify javascript
hostmakedepends="intltool python3-setuptools python3-wheel"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: deluge: set config dir to homedir
2021-06-29 1:16 [PR PATCH] deluge: set config dir to homedir sgn
` (2 preceding siblings ...)
2021-07-01 1:38 ` [PR PATCH] [Updated] " sgn
@ 2021-07-01 1:38 ` sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2021-07-01 1:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]
There's a merged pull request on the void-packages repository
deluge: set config dir to homedir
https://github.com/void-linux/void-packages/pull/31708
Description:
While we're at it, drop priviledge early.
Fix: https://github.com/void-linux/void-packages/issues/31690
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-01 1:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 1:16 [PR PATCH] deluge: set config dir to homedir sgn
2021-06-29 1:18 ` [PR PATCH] [Updated] " sgn
2021-06-29 1:45 ` ericonr
2021-07-01 1:38 ` [PR PATCH] [Updated] " sgn
2021-07-01 1:38 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).