Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qt5-speech: add other solibs to -devel depends.
@ 2021-06-29  7:36 fosslinux
  2021-06-29  9:30 ` [PR PATCH] [Merged]: " Johnnynator
  0 siblings, 1 reply; 2+ messages in thread
From: fosslinux @ 2021-06-29  7:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

There is a new pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages qt5-speech-devel-depends
https://github.com/void-linux/void-packages/pull/31709

qt5-speech: add other solibs to -devel depends.
The cmake file references them and so without this change it breaks
builds using qt5-speech-devel with cmake (eg knotifications,
ktextwidgets).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31709.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qt5-speech-devel-depends-31709.patch --]
[-- Type: text/x-diff, Size: 1657 bytes --]

From 0b90970cec003dd1f5ddb4d928a5d8ea5cfb6d51 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Tue, 29 Jun 2021 17:23:30 +1000
Subject: [PATCH] qt5-speech: add other solibs to -devel depends.

The cmake file references them and so without this change it breaks
builds using qt5-speech-devel with cmake (eg knotifications,
ktextwidgets).
---
 srcpkgs/qt5-speech/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/qt5-speech/template b/srcpkgs/qt5-speech/template
index de333523e551..24fd811e40a2 100644
--- a/srcpkgs/qt5-speech/template
+++ b/srcpkgs/qt5-speech/template
@@ -2,7 +2,7 @@
 pkgname=qt5-speech
 reverts="5.15.3+20210429_1 5.15.3+20210429_2"
 version=5.15.2
-revision=6
+revision=7
 wrksrc="qtspeech-everywhere-src-${version}"
 build_style=qmake
 configure_args="-- -flite -flite-alsa -speechd"
@@ -40,7 +40,9 @@ _cleanup_wrksrc_leak() {
 }
 
 qt5-speech-devel_package() {
-	depends="qt5-devel>=${version} ${sourcepkg}>=${version}_${revision}"
+	depends="qt5-devel>=${version} ${sourcepkg}>=${version}_${revision}
+		${sourcepkg}-plugin-speechd>=${version}_${revision}
+		${sourcepkg}-plugin-flite>=${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include
@@ -57,7 +59,6 @@ qt5-speech-plugin-speechd_package() {
 	short_desc+=" - Speech dispatcher Plugin"
 	pkg_install() {
 		vmove usr/lib/qt5/plugins/texttospeech/libqtexttospeech_speechd.so
-
 	}
 }
 
@@ -65,6 +66,5 @@ qt5-speech-plugin-flite_package() {
 	short_desc+=" - Flite Plugin"
 	pkg_install() {
 		vmove usr/lib/qt5/plugins/texttospeech/libqttexttospeech_flite.so
-
 	}
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: qt5-speech: add other solibs to -devel depends.
  2021-06-29  7:36 [PR PATCH] qt5-speech: add other solibs to -devel depends fosslinux
@ 2021-06-29  9:30 ` Johnnynator
  0 siblings, 0 replies; 2+ messages in thread
From: Johnnynator @ 2021-06-29  9:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

There's a merged pull request on the void-packages repository

qt5-speech: add other solibs to -devel depends.
https://github.com/void-linux/void-packages/pull/31709

Description:
The cmake file references them and so without this change it breaks
builds using qt5-speech-devel with cmake (eg knotifications,
ktextwidgets).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-29  9:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29  7:36 [PR PATCH] qt5-speech: add other solibs to -devel depends fosslinux
2021-06-29  9:30 ` [PR PATCH] [Merged]: " Johnnynator

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).