From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: upgrade docker-compose to 1.29.2
Date: Wed, 30 Jun 2021 12:02:28 +0200 [thread overview]
Message-ID: <20210630100228._47tf0eCq-EBKJxWhHYmJcYkI2Bu1FWbJ_EnPJHaEJ8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31721@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
New comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/31721#issuecomment-871266352
Comment:
@mitinarseny for reference why this PR does not follow the guidelines:
- you did not reset the revision to 1, which should be done on version bumps
- you did not update the checksum of the distfiles, which is why the build of the package would not have worked either way
- you did not test your changes, to make sure that they actually work.
I'd suggest reading the `Manual.md` file in this repository, it explains all these things in detail.
prev parent reply other threads:[~2021-06-30 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 9:44 [PR PATCH] " mitinarseny
2021-06-30 9:59 ` q66
2021-06-30 9:59 ` [PR PATCH] [Closed]: " q66
2021-06-30 10:02 ` jcgruenhage [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630100228._47tf0eCq-EBKJxWhHYmJcYkI2Bu1FWbJ_EnPJHaEJ8@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).