* [PR PATCH] upgrade docker-compose to 1.29.2
@ 2021-06-30 9:44 mitinarseny
2021-06-30 9:59 ` q66
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: mitinarseny @ 2021-06-30 9:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]
There is a new pull request by mitinarseny against master on the void-packages repository
https://github.com/mitinarseny/void-packages patch-1
https://github.com/void-linux/void-packages/pull/31721
upgrade docker-compose to 1.29.2
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31721.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-31721.patch --]
[-- Type: text/x-diff, Size: 669 bytes --]
From 3788e8ac58f340e2673d5c7ab92d61cf8b8480be Mon Sep 17 00:00:00 2001
From: Arseny Mitin <mitinarseny@gmail.com>
Date: Wed, 30 Jun 2021 12:43:36 +0300
Subject: [PATCH] upgrade docker-compose to 1.29.2
---
srcpkgs/docker-compose/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/docker-compose/template b/srcpkgs/docker-compose/template
index c5fcdb65a0ac..15f1632662d6 100644
--- a/srcpkgs/docker-compose/template
+++ b/srcpkgs/docker-compose/template
@@ -1,6 +1,6 @@
# Template file for 'docker-compose'
pkgname=docker-compose
-version=1.27.4
+version=1.29.2
revision=2
wrksrc="compose-${version}"
build_style=python3-module
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: upgrade docker-compose to 1.29.2
2021-06-30 9:44 [PR PATCH] upgrade docker-compose to 1.29.2 mitinarseny
@ 2021-06-30 9:59 ` q66
2021-06-30 9:59 ` [PR PATCH] [Closed]: " q66
2021-06-30 10:02 ` jcgruenhage
2 siblings, 0 replies; 4+ messages in thread
From: q66 @ 2021-06-30 9:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/31721#issuecomment-871263852
Comment:
try again when you actually properly test your changes and follow the proper guidelines
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Closed]: upgrade docker-compose to 1.29.2
2021-06-30 9:44 [PR PATCH] upgrade docker-compose to 1.29.2 mitinarseny
2021-06-30 9:59 ` q66
@ 2021-06-30 9:59 ` q66
2021-06-30 10:02 ` jcgruenhage
2 siblings, 0 replies; 4+ messages in thread
From: q66 @ 2021-06-30 9:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]
There's a closed pull request on the void-packages repository
upgrade docker-compose to 1.29.2
https://github.com/void-linux/void-packages/pull/31721
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: upgrade docker-compose to 1.29.2
2021-06-30 9:44 [PR PATCH] upgrade docker-compose to 1.29.2 mitinarseny
2021-06-30 9:59 ` q66
2021-06-30 9:59 ` [PR PATCH] [Closed]: " q66
@ 2021-06-30 10:02 ` jcgruenhage
2 siblings, 0 replies; 4+ messages in thread
From: jcgruenhage @ 2021-06-30 10:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
New comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/31721#issuecomment-871266352
Comment:
@mitinarseny for reference why this PR does not follow the guidelines:
- you did not reset the revision to 1, which should be done on version bumps
- you did not update the checksum of the distfiles, which is why the build of the package would not have worked either way
- you did not test your changes, to make sure that they actually work.
I'd suggest reading the `Manual.md` file in this repository, it explains all these things in detail.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-30 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 9:44 [PR PATCH] upgrade docker-compose to 1.29.2 mitinarseny
2021-06-30 9:59 ` q66
2021-06-30 9:59 ` [PR PATCH] [Closed]: " q66
2021-06-30 10:02 ` jcgruenhage
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).