* [PR PATCH] RNNoise
@ 2021-05-29 10:14 DBLouis
2021-05-29 10:17 ` [PR PATCH] [Updated] RNNoise DBLouis
` (12 more replies)
0 siblings, 13 replies; 14+ messages in thread
From: DBLouis @ 2021-05-29 10:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
There is a new pull request by DBLouis against master on the void-packages repository
https://github.com/DBLouis/void-packages rnnoise
https://github.com/void-linux/void-packages/pull/31203
RNNoise
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/31203.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rnnoise-31203.patch --]
[-- Type: text/x-diff, Size: 4480 bytes --]
From 62acf9cb6d9c81a6b71c5edfaec677808869d52d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 12:54:14 +0300
Subject: [PATCH 1/3] New package: rnnoise-0.4.1
---
common/shlibs | 1 +
srcpkgs/rnnoise-devel | 1 +
srcpkgs/rnnoise/template | 33 +++++++++++++++++++++++++++++++++
3 files changed, 35 insertions(+)
create mode 120000 srcpkgs/rnnoise-devel
create mode 100644 srcpkgs/rnnoise/template
diff --git a/common/shlibs b/common/shlibs
index 666da46e0481..fbeedc81bfee 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4006,3 +4006,4 @@ libbasu.so.0 basu-0.2.0_1
libXcomp.so.3 nx-libs-3.5.99.24_1
libXcompshad.so.3 nx-libs-3.5.99.24_1
libNX_X11.so.6 nx-libs-3.5.99.24_1
+librnnoise.so.0 rnnoise-0.4.1_1
diff --git a/srcpkgs/rnnoise-devel b/srcpkgs/rnnoise-devel
new file mode 120000
index 000000000000..fd3349ee491f
--- /dev/null
+++ b/srcpkgs/rnnoise-devel
@@ -0,0 +1 @@
+rnnoise
\ No newline at end of file
diff --git a/srcpkgs/rnnoise/template b/srcpkgs/rnnoise/template
new file mode 100644
index 000000000000..343102679764
--- /dev/null
+++ b/srcpkgs/rnnoise/template
@@ -0,0 +1,33 @@
+# Template file for 'rnnoise'
+pkgname=rnnoise
+_githash=1cbdbcf1283499bbb2230a6b0f126eb9b236defd
+version=0.4.1
+revision=1
+wrksrc="${pkgname}-${_githash}"
+build_style=gnu-configure
+hostmakedepends="automake libtool"
+short_desc="Recurrent neural network for audio noise reduction"
+maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
+license="custom:Mozilla"
+homepage="https://jmvalin.ca/demo/rnnoise/"
+distfiles="https://github.com/xiph/rnnoise/archive/${_githash}.tar.gz"
+checksum=68c7ab4e408426088603e19955e746bb2a412d84bb121b6f39834c60fc8068b7
+
+pre_configure() {
+ ./autogen.sh
+}
+
+post_install() {
+ vlicense COPYING
+}
+
+rnnoise-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
+}
From b00ef44a76f9d7b4a1aeece57e8804d94e3b3d16 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 13:11:50 +0300
Subject: [PATCH 2/3] Add support for RNNoise to PulseEffects
---
srcpkgs/pulseeffects/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index 3b94e3dc873b..7bfce52ceba8 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,13 +1,13 @@
# Template file for 'pulseeffects'
pkgname=pulseeffects
version=5.0.3
-revision=1
+revision=2
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
- libsndfile-devel libbs2b-devel"
+ libsndfile-devel libbs2b-devel rnnoise-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver
gstreamer1-pipewire"
From 5f24771614a3749b9e962c583b1d727bb9d0c4e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 13:12:14 +0300
Subject: [PATCH 3/3] Add support for RNNoise to PulseEffects (legacy)
---
srcpkgs/pulseeffects-legacy/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
index c38c8ef2d9ef..15c30aa3622f 100644
--- a/srcpkgs/pulseeffects-legacy/template
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -1,14 +1,14 @@
# Template file for 'pulseeffects-legacy'
pkgname=pulseeffects-legacy
version=4.8.5
-revision=1
+revision=2
wrksrc="pulseeffects-${version}"
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ libsndfile-devel rnnoise-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
short_desc="Sound effects for systems using PulseAudio (legacy)"
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
@ 2021-05-29 10:17 ` DBLouis
2021-05-29 11:32 ` [PR REVIEW] RNNoise paper42
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: DBLouis @ 2021-05-29 10:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
There is an updated pull request by DBLouis against master on the void-packages repository
https://github.com/DBLouis/void-packages rnnoise
https://github.com/void-linux/void-packages/pull/31203
RNNoise
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/31203.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rnnoise-31203.patch --]
[-- Type: text/x-diff, Size: 4468 bytes --]
From 14dccbbafd3a2045c663536d83e7f257f5c39490 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 12:54:14 +0300
Subject: [PATCH 1/3] New package: rnnoise-0.4.1
---
common/shlibs | 1 +
srcpkgs/rnnoise-devel | 1 +
srcpkgs/rnnoise/template | 33 +++++++++++++++++++++++++++++++++
3 files changed, 35 insertions(+)
create mode 120000 srcpkgs/rnnoise-devel
create mode 100644 srcpkgs/rnnoise/template
diff --git a/common/shlibs b/common/shlibs
index 666da46e0481..fbeedc81bfee 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4006,3 +4006,4 @@ libbasu.so.0 basu-0.2.0_1
libXcomp.so.3 nx-libs-3.5.99.24_1
libXcompshad.so.3 nx-libs-3.5.99.24_1
libNX_X11.so.6 nx-libs-3.5.99.24_1
+librnnoise.so.0 rnnoise-0.4.1_1
diff --git a/srcpkgs/rnnoise-devel b/srcpkgs/rnnoise-devel
new file mode 120000
index 000000000000..fd3349ee491f
--- /dev/null
+++ b/srcpkgs/rnnoise-devel
@@ -0,0 +1 @@
+rnnoise
\ No newline at end of file
diff --git a/srcpkgs/rnnoise/template b/srcpkgs/rnnoise/template
new file mode 100644
index 000000000000..27b3954af28e
--- /dev/null
+++ b/srcpkgs/rnnoise/template
@@ -0,0 +1,33 @@
+# Template file for 'rnnoise'
+pkgname=rnnoise
+_githash=1cbdbcf1283499bbb2230a6b0f126eb9b236defd
+version=0.4.1
+revision=1
+wrksrc="${pkgname}-${_githash}"
+build_style=gnu-configure
+hostmakedepends="automake libtool"
+short_desc="Recurrent neural network for audio noise reduction"
+maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
+license="custom:Mozilla"
+homepage="https://jmvalin.ca/demo/rnnoise/"
+distfiles="https://github.com/xiph/rnnoise/archive/${_githash}.tar.gz"
+checksum=68c7ab4e408426088603e19955e746bb2a412d84bb121b6f39834c60fc8068b7
+
+pre_configure() {
+ ./autogen.sh
+}
+
+post_install() {
+ vlicense COPYING
+}
+
+rnnoise-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
+}
From 71e120a313d5d10f9b5021aef88b910ac42a0e9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 13:11:50 +0300
Subject: [PATCH 2/3] Add support for RNNoise to PulseEffects
---
srcpkgs/pulseeffects/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index 3b94e3dc873b..7bfce52ceba8 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,13 +1,13 @@
# Template file for 'pulseeffects'
pkgname=pulseeffects
version=5.0.3
-revision=1
+revision=2
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
- libsndfile-devel libbs2b-devel"
+ libsndfile-devel libbs2b-devel rnnoise-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver
gstreamer1-pipewire"
From 61640d0646d722d632391866d82024bb3dc81f4a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 13:12:14 +0300
Subject: [PATCH 3/3] Add support for RNNoise to PulseEffects (legacy)
---
srcpkgs/pulseeffects-legacy/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
index c38c8ef2d9ef..15c30aa3622f 100644
--- a/srcpkgs/pulseeffects-legacy/template
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -1,14 +1,14 @@
# Template file for 'pulseeffects-legacy'
pkgname=pulseeffects-legacy
version=4.8.5
-revision=1
+revision=2
wrksrc="pulseeffects-${version}"
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ libsndfile-devel rnnoise-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
short_desc="Sound effects for systems using PulseAudio (legacy)"
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
2021-05-29 10:17 ` [PR PATCH] [Updated] RNNoise DBLouis
@ 2021-05-29 11:32 ` paper42
2021-05-29 11:57 ` DBLouis
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-05-29 11:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r641927129
Comment:
It should be BSD-3-Clause
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
2021-05-29 10:17 ` [PR PATCH] [Updated] RNNoise DBLouis
2021-05-29 11:32 ` [PR REVIEW] RNNoise paper42
@ 2021-05-29 11:57 ` DBLouis
2021-05-29 11:59 ` [PR PATCH] [Updated] RNNoise DBLouis
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: DBLouis @ 2021-05-29 11:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New review comment by DBLouis on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r641929580
Comment:
Thanks, I was not sure
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (2 preceding siblings ...)
2021-05-29 11:57 ` DBLouis
@ 2021-05-29 11:59 ` DBLouis
2021-05-29 13:26 ` [PR REVIEW] RNNoise ericonr
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: DBLouis @ 2021-05-29 11:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
There is an updated pull request by DBLouis against master on the void-packages repository
https://github.com/DBLouis/void-packages rnnoise
https://github.com/void-linux/void-packages/pull/31203
RNNoise
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/31203.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rnnoise-31203.patch --]
[-- Type: text/x-diff, Size: 4466 bytes --]
From 04b21829da7c23e365733424ecf22089511fd294 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 12:54:14 +0300
Subject: [PATCH 1/3] New package: rnnoise-0.4.1
---
common/shlibs | 1 +
srcpkgs/rnnoise-devel | 1 +
srcpkgs/rnnoise/template | 33 +++++++++++++++++++++++++++++++++
3 files changed, 35 insertions(+)
create mode 120000 srcpkgs/rnnoise-devel
create mode 100644 srcpkgs/rnnoise/template
diff --git a/common/shlibs b/common/shlibs
index 666da46e0481..fbeedc81bfee 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4006,3 +4006,4 @@ libbasu.so.0 basu-0.2.0_1
libXcomp.so.3 nx-libs-3.5.99.24_1
libXcompshad.so.3 nx-libs-3.5.99.24_1
libNX_X11.so.6 nx-libs-3.5.99.24_1
+librnnoise.so.0 rnnoise-0.4.1_1
diff --git a/srcpkgs/rnnoise-devel b/srcpkgs/rnnoise-devel
new file mode 120000
index 000000000000..fd3349ee491f
--- /dev/null
+++ b/srcpkgs/rnnoise-devel
@@ -0,0 +1 @@
+rnnoise
\ No newline at end of file
diff --git a/srcpkgs/rnnoise/template b/srcpkgs/rnnoise/template
new file mode 100644
index 000000000000..c7c05660b933
--- /dev/null
+++ b/srcpkgs/rnnoise/template
@@ -0,0 +1,33 @@
+# Template file for 'rnnoise'
+pkgname=rnnoise
+_githash=1cbdbcf1283499bbb2230a6b0f126eb9b236defd
+version=0.4.1
+revision=1
+wrksrc="${pkgname}-${_githash}"
+build_style=gnu-configure
+hostmakedepends="automake libtool"
+short_desc="Recurrent neural network for audio noise reduction"
+maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
+license="BSD-3-Clause"
+homepage="https://jmvalin.ca/demo/rnnoise/"
+distfiles="https://github.com/xiph/rnnoise/archive/${_githash}.tar.gz"
+checksum=68c7ab4e408426088603e19955e746bb2a412d84bb121b6f39834c60fc8068b7
+
+pre_configure() {
+ ./autogen.sh
+}
+
+post_install() {
+ vlicense COPYING
+}
+
+rnnoise-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
+}
From eb616b3256b903205fb6a0ff57e44ffe5345a499 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 13:11:50 +0300
Subject: [PATCH 2/3] Add support for RNNoise to PulseEffects
---
srcpkgs/pulseeffects/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index 3b94e3dc873b..7bfce52ceba8 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,13 +1,13 @@
# Template file for 'pulseeffects'
pkgname=pulseeffects
version=5.0.3
-revision=1
+revision=2
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
- libsndfile-devel libbs2b-devel"
+ libsndfile-devel libbs2b-devel rnnoise-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver
gstreamer1-pipewire"
From 7c1a6e3cf7c901fcc140a7bb8a55bf4c08f09ccc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?=
<louisdb@lespetitspedestres.org>
Date: Sat, 29 May 2021 13:12:14 +0300
Subject: [PATCH 3/3] Add support for RNNoise to PulseEffects (legacy)
---
srcpkgs/pulseeffects-legacy/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
index c38c8ef2d9ef..15c30aa3622f 100644
--- a/srcpkgs/pulseeffects-legacy/template
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -1,14 +1,14 @@
# Template file for 'pulseeffects-legacy'
pkgname=pulseeffects-legacy
version=4.8.5
-revision=1
+revision=2
wrksrc="pulseeffects-${version}"
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ libsndfile-devel rnnoise-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
short_desc="Sound effects for systems using PulseAudio (legacy)"
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (3 preceding siblings ...)
2021-05-29 11:59 ` [PR PATCH] [Updated] RNNoise DBLouis
@ 2021-05-29 13:26 ` ericonr
2021-05-29 17:13 ` DBLouis
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-05-29 13:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r641938462
Comment:
Where is this version number coming from? We don't usually package software without proper releases, and this just looks like you picked the latest commit...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (4 preceding siblings ...)
2021-05-29 13:26 ` [PR REVIEW] RNNoise ericonr
@ 2021-05-29 17:13 ` DBLouis
2021-06-26 0:54 ` Logarithmus
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: DBLouis @ 2021-05-29 17:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
New review comment by DBLouis on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r641962153
Comment:
This is the version number coming from the name of the .so. It must be set somewhere in the repo. I'll ask if the maintainer can add a proper release tag.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (5 preceding siblings ...)
2021-05-29 17:13 ` DBLouis
@ 2021-06-26 0:54 ` Logarithmus
2021-06-26 0:55 ` Logarithmus
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Logarithmus @ 2021-06-26 0:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r659096017
Comment:
@ericonr IMO we should make an exception out of the "proper releases" rule for this case. It's been about 10 months since @darix asked them to tag releases, but still no response from them.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (6 preceding siblings ...)
2021-06-26 0:54 ` Logarithmus
@ 2021-06-26 0:55 ` Logarithmus
2021-06-26 0:55 ` Logarithmus
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Logarithmus @ 2021-06-26 0:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r659096017
Comment:
@ericonr IMO we should make an exception out of the "proper releases" rule for this case. It's been about 10 months since @darix asked them to tag releases, but still no response from them. Arch folks just use commit hash (it's in main repo, not in AUR: https://github.com/archlinux/svntogit-community/blob/packages/rnnoise/trunk/PKGBUILD)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (7 preceding siblings ...)
2021-06-26 0:55 ` Logarithmus
@ 2021-06-26 0:55 ` Logarithmus
2021-06-26 0:56 ` Logarithmus
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Logarithmus @ 2021-06-26 0:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r659096017
Comment:
@ericonr IMO we should make an exception out of the "proper releases" rule for this case. It's been about 10 months since @darix asked them to tag releases, but still no response from them.
Arch folks just use commit hash (it's in main repo, not in AUR: https://github.com/archlinux/svntogit-community/blob/packages/rnnoise/trunk/PKGBUILD)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (8 preceding siblings ...)
2021-06-26 0:55 ` Logarithmus
@ 2021-06-26 0:56 ` Logarithmus
2021-07-02 20:53 ` [PR PATCH] [Closed]: RNNoise Johnnynator
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Logarithmus @ 2021-06-26 0:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#discussion_r659096017
Comment:
@ericonr IMO we should make an exception out of the "proper releases" rule for this case. It's been about 10 months since @darix asked them to tag releases, but still no response from them.
Arch folks just use commit hash (it's in main repo, not in AUR: https://github.com/archlinux/svntogit-community/blob/packages/rnnoise/trunk/PKGBUILD).
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Closed]: RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (9 preceding siblings ...)
2021-06-26 0:56 ` Logarithmus
@ 2021-07-02 20:53 ` Johnnynator
2021-07-03 6:34 ` RNNoise DBLouis
2021-07-03 6:40 ` RNNoise FollieHiyuki
12 siblings, 0 replies; 14+ messages in thread
From: Johnnynator @ 2021-07-02 20:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
There's a closed pull request on the void-packages repository
RNNoise
https://github.com/void-linux/void-packages/pull/31203
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (10 preceding siblings ...)
2021-07-02 20:53 ` [PR PATCH] [Closed]: RNNoise Johnnynator
@ 2021-07-03 6:34 ` DBLouis
2021-07-03 6:40 ` RNNoise FollieHiyuki
12 siblings, 0 replies; 14+ messages in thread
From: DBLouis @ 2021-07-03 6:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
New comment by DBLouis on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#issuecomment-873356170
Comment:
why close?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RNNoise
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
` (11 preceding siblings ...)
2021-07-03 6:34 ` RNNoise DBLouis
@ 2021-07-03 6:40 ` FollieHiyuki
12 siblings, 0 replies; 14+ messages in thread
From: FollieHiyuki @ 2021-07-03 6:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/31203#issuecomment-873356801
Comment:
> why close?
Merged https://github.com/void-linux/void-packages/commit/80166ea3bd406302faf41b4a5a133b55f8b599ee
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-07-03 6:40 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-29 10:14 [PR PATCH] RNNoise DBLouis
2021-05-29 10:17 ` [PR PATCH] [Updated] RNNoise DBLouis
2021-05-29 11:32 ` [PR REVIEW] RNNoise paper42
2021-05-29 11:57 ` DBLouis
2021-05-29 11:59 ` [PR PATCH] [Updated] RNNoise DBLouis
2021-05-29 13:26 ` [PR REVIEW] RNNoise ericonr
2021-05-29 17:13 ` DBLouis
2021-06-26 0:54 ` Logarithmus
2021-06-26 0:55 ` Logarithmus
2021-06-26 0:55 ` Logarithmus
2021-06-26 0:56 ` Logarithmus
2021-07-02 20:53 ` [PR PATCH] [Closed]: RNNoise Johnnynator
2021-07-03 6:34 ` RNNoise DBLouis
2021-07-03 6:40 ` RNNoise FollieHiyuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).