From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: zfs: upgrade to 2.1.0
Date: Sun, 04 Jul 2021 15:40:57 +0200 [thread overview]
Message-ID: <20210704134057.E3ipOMtG8L-p6920Zb7EROMWxrsqgNWPEuF3K2SgLDw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31771@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/31771#issuecomment-873593201
Comment:
The `/usr/src/zfs-2.x.y` directory is just a pristine version of the upstream source (except for any patches we've applied, especially the one that skips building user-space utilities that would just be thrown out by DKMS anyway).
1. If we start pruning tests, why not also prune contrib and all of the other utilities? We start down a slippery slope regarding where to stop removing pieces unnecessary for the kmods.
2. If the answer is that tests are obviously different because they are, well, tests; and the test suite is several times *larger* than the kmod source, which itself is about as large as the rest of the tree combined; then I wonder what value a tests subpackage has. Using the build-time test suite we ship in this package is not much easier than fetching an upstream source tarball and running them in a different place.
My take is that, if tests are special enough to want to eliminate, we just drop them. If somebody finds value in the tests, we should just keep the tree pristine.
next prev parent reply other threads:[~2021-07-04 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 2:48 [PR PATCH] " ahesford
2021-07-03 3:17 ` [PR PATCH] [Updated] " ahesford
2021-07-03 4:03 ` zdykstra
2021-07-03 4:12 ` [PR PATCH] [Updated] " ahesford
2021-07-03 4:17 ` ericonr
2021-07-04 4:39 ` Vaelatern
2021-07-04 13:40 ` ahesford [this message]
2021-07-04 19:29 ` ericonr
2021-07-04 23:06 ` Vaelatern
2021-07-08 14:00 ` ahesford
2021-07-08 14:00 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210704134057.E3ipOMtG8L-p6920Zb7EROMWxrsqgNWPEuF3K2SgLDw@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).