From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: zfs: upgrade to 2.1.0
Date: Thu, 08 Jul 2021 16:00:26 +0200 [thread overview]
Message-ID: <20210708140026.dkozfEJiFUJkateRHH9GoE5mzGkNzfVGEzi79k5Mwg4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31771@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/31771#issuecomment-876464929
Comment:
When building the module, DKMS runs the package's configure script; this references the `tests` tree and fails, preventing the module from building. I attempted to remove `tests` in `post_extract`, but this directory is listed as a requirement in both `Makefile.am` and `configure.ac`. While this is probably an easy fix (remove all `tests/*` file references in `configure.ac` and remove references to the `tests` directories in, *e.g.*, the `SUBDIRS` specification of `Makefile.am`), I'm not thrilled about carrying patches to the build system to support test removals, especially since there is some disagreement about whether the tests should just be removed or offered in a subpackage.
I'm merging as-is for now; anybody who wants to pick up the effort can do so.
next prev parent reply other threads:[~2021-07-08 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 2:48 [PR PATCH] " ahesford
2021-07-03 3:17 ` [PR PATCH] [Updated] " ahesford
2021-07-03 4:03 ` zdykstra
2021-07-03 4:12 ` [PR PATCH] [Updated] " ahesford
2021-07-03 4:17 ` ericonr
2021-07-04 4:39 ` Vaelatern
2021-07-04 13:40 ` ahesford
2021-07-04 19:29 ` ericonr
2021-07-04 23:06 ` Vaelatern
2021-07-08 14:00 ` ahesford [this message]
2021-07-08 14:00 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708140026.dkozfEJiFUJkateRHH9GoE5mzGkNzfVGEzi79k5Mwg4@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).