Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mdcat: update to 0.23.0
@ 2021-07-05 18:47 FollieHiyuki
  2021-07-05 19:08 ` [PR REVIEW] " ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: FollieHiyuki @ 2021-07-05 18:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

There is a new pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages mdcat-update
https://github.com/void-linux/void-packages/pull/31826

mdcat: update to 0.23.0
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31826.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mdcat-update-31826.patch --]
[-- Type: text/x-diff, Size: 1625 bytes --]

From ef1ecb6554844e9b7b1f2d700e516e429f61c964 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Mon, 5 Jul 2021 21:46:54 +0300
Subject: [PATCH] mdcat: update to 0.23.0

Add shell completions and the man page.
---
 srcpkgs/mdcat/template | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/mdcat/template b/srcpkgs/mdcat/template
index 869aecd1b4bb..59c4ba975d4f 100644
--- a/srcpkgs/mdcat/template
+++ b/srcpkgs/mdcat/template
@@ -1,15 +1,26 @@
 # Template file for 'mdcat'
 pkgname=mdcat
-reverts="0.22.2_1"
-version=0.22.1
-revision=3
+version=0.23.0
+revision=1
 wrksrc="${pkgname}-${pkgname}-${version}"
 build_style=cargo
-hostmakedepends="cmake pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="openssl-devel"
 short_desc="Cat for markdown"
 maintainer="Wilson Birney <wpb@360scada.com>"
 license="MPL-2.0"
 homepage="https://github.com/lunaryorn/mdcat"
 distfiles="https://github.com/lunaryorn/mdcat/archive/mdcat-${version}.tar.gz"
-checksum=b14846542fb8b60ac0235b399136372df7569aa59ed63f3faf88ff7a485abe5f
+checksum=9fba4fe06f8970a70ca75666f8245181583a6ba5fb11536ae7e572f74c9d1f4c
+
+post_install() {
+	bash_completion=$(find ${wrksrc}/target -name mdcat.bash -print -quit)
+	vcompletion ${bash_completion} bash
+	zsh_completion=$(find ${wrksrc}/target -name _mdcat -print -quit)
+	vcompletion ${zsh_completion} zsh
+	fish_completion=$(find ${wrksrc}/target -name mdcat.fish -print -quit)
+	vcompletion ${fish_completion} fish
+
+	man_page=$(find ${wrksrc}/target -name mdcat.1 -print -quit)
+	vman ${man_page}
+}

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] mdcat: update to 0.23.0
  2021-07-05 18:47 [PR PATCH] mdcat: update to 0.23.0 FollieHiyuki
@ 2021-07-05 19:08 ` ericonr
  2021-07-05 19:42 ` [PR PATCH] [Updated] " FollieHiyuki
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-07-05 19:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31826#discussion_r664094817

Comment:
Dirty deeds done dirt cheap :p

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] mdcat: update to 0.23.0
  2021-07-05 18:47 [PR PATCH] mdcat: update to 0.23.0 FollieHiyuki
  2021-07-05 19:08 ` [PR REVIEW] " ericonr
@ 2021-07-05 19:42 ` FollieHiyuki
  2021-07-05 19:43 ` [PR REVIEW] " FollieHiyuki
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: FollieHiyuki @ 2021-07-05 19:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages mdcat-update
https://github.com/void-linux/void-packages/pull/31826

mdcat: update to 0.23.0
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31826.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mdcat-update-31826.patch --]
[-- Type: text/x-diff, Size: 1735 bytes --]

From 7016170516cc51d9c47d9cac8a071373b4051737 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Mon, 5 Jul 2021 21:46:54 +0300
Subject: [PATCH] mdcat: update to 0.23.0

Add shell completions and the man page.
---
 srcpkgs/mdcat/template | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/mdcat/template b/srcpkgs/mdcat/template
index 869aecd1b4bb..1884073a0989 100644
--- a/srcpkgs/mdcat/template
+++ b/srcpkgs/mdcat/template
@@ -1,15 +1,31 @@
 # Template file for 'mdcat'
 pkgname=mdcat
-reverts="0.22.2_1"
-version=0.22.1
-revision=3
+version=0.23.0
+revision=1
 wrksrc="${pkgname}-${pkgname}-${version}"
 build_style=cargo
-hostmakedepends="cmake pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="openssl-devel"
 short_desc="Cat for markdown"
 maintainer="Wilson Birney <wpb@360scada.com>"
 license="MPL-2.0"
 homepage="https://github.com/lunaryorn/mdcat"
 distfiles="https://github.com/lunaryorn/mdcat/archive/mdcat-${version}.tar.gz"
-checksum=b14846542fb8b60ac0235b399136372df7569aa59ed63f3faf88ff7a485abe5f
+checksum=9fba4fe06f8970a70ca75666f8245181583a6ba5fb11536ae7e572f74c9d1f4c
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64*|i686*|arm*|aarch64*) ;;
+	*) broken="ftbfs in ring" ;;
+esac
+
+post_install() {
+	bash_completion=$(find ${wrksrc}/target -name mdcat.bash -print -quit)
+	vcompletion ${bash_completion} bash
+	zsh_completion=$(find ${wrksrc}/target -name _mdcat -print -quit)
+	vcompletion ${zsh_completion} zsh
+	fish_completion=$(find ${wrksrc}/target -name mdcat.fish -print -quit)
+	vcompletion ${fish_completion} fish
+
+	man_page=$(find ${wrksrc}/target -name mdcat.1 -print -quit)
+	vman ${man_page}
+}

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] mdcat: update to 0.23.0
  2021-07-05 18:47 [PR PATCH] mdcat: update to 0.23.0 FollieHiyuki
  2021-07-05 19:08 ` [PR REVIEW] " ericonr
  2021-07-05 19:42 ` [PR PATCH] [Updated] " FollieHiyuki
@ 2021-07-05 19:43 ` FollieHiyuki
  2021-07-05 19:44 ` FollieHiyuki
  2021-07-07  2:08 ` [PR PATCH] [Closed]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: FollieHiyuki @ 2021-07-05 19:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31826#discussion_r664105263

Comment:
It's cargo's fault to dump things deep inside /target/release/build xD

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: mdcat: update to 0.23.0
  2021-07-05 18:47 [PR PATCH] mdcat: update to 0.23.0 FollieHiyuki
                   ` (2 preceding siblings ...)
  2021-07-05 19:43 ` [PR REVIEW] " FollieHiyuki
@ 2021-07-05 19:44 ` FollieHiyuki
  2021-07-07  2:08 ` [PR PATCH] [Closed]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: FollieHiyuki @ 2021-07-05 19:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31826#issuecomment-874299847

Comment:
Added a broken block as you suggested.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: mdcat: update to 0.23.0
  2021-07-05 18:47 [PR PATCH] mdcat: update to 0.23.0 FollieHiyuki
                   ` (3 preceding siblings ...)
  2021-07-05 19:44 ` FollieHiyuki
@ 2021-07-07  2:08 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-07-07  2:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

There's a closed pull request on the void-packages repository

mdcat: update to 0.23.0
https://github.com/void-linux/void-packages/pull/31826

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-07  2:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-05 18:47 [PR PATCH] mdcat: update to 0.23.0 FollieHiyuki
2021-07-05 19:08 ` [PR REVIEW] " ericonr
2021-07-05 19:42 ` [PR PATCH] [Updated] " FollieHiyuki
2021-07-05 19:43 ` [PR REVIEW] " FollieHiyuki
2021-07-05 19:44 ` FollieHiyuki
2021-07-07  2:08 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).