* [PR PATCH] whipper: update to 0.10.0.
@ 2021-07-22 15:18 UsernameRandomlyGenerated
2021-07-23 1:23 ` [PR REVIEW] " ahesford
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: UsernameRandomlyGenerated @ 2021-07-22 15:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]
There is a new pull request by UsernameRandomlyGenerated against master on the void-packages repository
https://github.com/UsernameRandomlyGenerated/void-packages whipper010
https://github.com/void-linux/void-packages/pull/32140
whipper: update to 0.10.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32140.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-whipper010-32140.patch --]
[-- Type: text/x-diff, Size: 2892 bytes --]
From 51a61cfe46e4c46abee2a027c480de08513f7a5d Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 22 Jul 2021 17:17:11 +0200
Subject: [PATCH] whipper: update to 0.10.0.
---
.../patches/fix-failed-task-analyzetask.patch | 24 -------------------
srcpkgs/whipper/template | 13 ++++------
2 files changed, 4 insertions(+), 33 deletions(-)
delete mode 100644 srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
diff --git a/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch b/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
deleted file mode 100644
index 361af61042a3..000000000000
--- a/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
+++ /dev/null
@@ -1,24 +0,0 @@
-From 305678ec85568e9fdbc888078c11a1f7d4bc0100 Mon Sep 17 00:00:00 2001
-From: Merlijn Wajer <merlijn@wizzup.org>
-Date: Sat, 14 Dec 2019 18:16:30 +0800
-Subject: [PATCH] program/cdparanoia: fix failed() task of AnalyzeTask
-
----
- whipper/program/cdparanoia.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/whipper/program/cdparanoia.py b/whipper/program/cdparanoia.py
-index 636e6f5..f071674 100644
---- a/whipper/program/cdparanoia.py
-+++ b/whipper/program/cdparanoia.py
-@@ -603,7 +603,7 @@ class AnalyzeTask(ctask.PopenTask):
- def failed(self):
- # cdparanoia exits with return code 1 if it can't determine
- # whether it can defeat the audio cache
-- output = "".join(self._output)
-+ output = "".join(o.decode() for o in self._output)
- m = _WARNING_RE.search(output)
- if m or _ABORTING_RE.search(output):
- self.defeatsCache = False
---
-2.17.1
diff --git a/srcpkgs/whipper/template b/srcpkgs/whipper/template
index f25ab359c284..db0ea9b15654 100644
--- a/srcpkgs/whipper/template
+++ b/srcpkgs/whipper/template
@@ -1,22 +1,17 @@
# Template file for 'whipper'
pkgname=whipper
-version=0.9.0
-revision=3
+version=0.10.0
+revision=1
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
makedepends="libsndfile-devel python3-devel"
depends="libcdio-paranoia cdrdao python3-gobject python3-musicbrainzngs
python3-mutagen python3-requests python3-pycdio python3-discid
python3-ruamel.yaml flac sox"
+checkdepends="$depends python3-Twisted"
short_desc="Python CD-DA ripper preferring accuracy over speed"
maintainer="Stefano Ragni <st3r4g@protonmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/whipper-team/whipper"
distfiles="https://github.com/whipper-team/whipper/archive/v${version}.tar.gz"
-checksum=3caceeec7ca73c8b73147884b0f8eeacbe66af52900021b564118b88d23afbd2
-
-
-pre_build() {
-# Temporary workaround for https://github.com/whipper-team/whipper/issues/428
- echo "Version: ${version}" > PKG-INFO
-}
+checksum=a6fba11f4460854267c610f066c185e859d7177699b50ef584fc4f705962d356
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] whipper: update to 0.10.0.
2021-07-22 15:18 [PR PATCH] whipper: update to 0.10.0 UsernameRandomlyGenerated
@ 2021-07-23 1:23 ` ahesford
2021-07-26 7:40 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2021-07-23 1:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/32140#discussion_r675256336
Comment:
Please try adding `python3-pytest` to `checkdepends` as well, so the checks don't rely on deprecated setuptools functionality.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] whipper: update to 0.10.0.
2021-07-22 15:18 [PR PATCH] whipper: update to 0.10.0 UsernameRandomlyGenerated
2021-07-23 1:23 ` [PR REVIEW] " ahesford
@ 2021-07-26 7:40 ` UsernameRandomlyGenerated
2021-07-26 7:42 ` UsernameRandomlyGenerated
2021-07-26 10:45 ` [PR PATCH] [Merged]: " ahesford
3 siblings, 0 replies; 5+ messages in thread
From: UsernameRandomlyGenerated @ 2021-07-26 7:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]
There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository
https://github.com/UsernameRandomlyGenerated/void-packages whipper010
https://github.com/void-linux/void-packages/pull/32140
whipper: update to 0.10.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32140.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-whipper010-32140.patch --]
[-- Type: text/x-diff, Size: 2907 bytes --]
From 6f6fba9a3a82018030449d814630c4bac2a305d3 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 22 Jul 2021 17:17:11 +0200
Subject: [PATCH] whipper: update to 0.10.0.
---
.../patches/fix-failed-task-analyzetask.patch | 24 -------------------
srcpkgs/whipper/template | 13 ++++------
2 files changed, 4 insertions(+), 33 deletions(-)
delete mode 100644 srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
diff --git a/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch b/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
deleted file mode 100644
index 361af61042a3..000000000000
--- a/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
+++ /dev/null
@@ -1,24 +0,0 @@
-From 305678ec85568e9fdbc888078c11a1f7d4bc0100 Mon Sep 17 00:00:00 2001
-From: Merlijn Wajer <merlijn@wizzup.org>
-Date: Sat, 14 Dec 2019 18:16:30 +0800
-Subject: [PATCH] program/cdparanoia: fix failed() task of AnalyzeTask
-
----
- whipper/program/cdparanoia.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/whipper/program/cdparanoia.py b/whipper/program/cdparanoia.py
-index 636e6f5..f071674 100644
---- a/whipper/program/cdparanoia.py
-+++ b/whipper/program/cdparanoia.py
-@@ -603,7 +603,7 @@ class AnalyzeTask(ctask.PopenTask):
- def failed(self):
- # cdparanoia exits with return code 1 if it can't determine
- # whether it can defeat the audio cache
-- output = "".join(self._output)
-+ output = "".join(o.decode() for o in self._output)
- m = _WARNING_RE.search(output)
- if m or _ABORTING_RE.search(output):
- self.defeatsCache = False
---
-2.17.1
diff --git a/srcpkgs/whipper/template b/srcpkgs/whipper/template
index f25ab359c284..00bca3fea9bf 100644
--- a/srcpkgs/whipper/template
+++ b/srcpkgs/whipper/template
@@ -1,22 +1,17 @@
# Template file for 'whipper'
pkgname=whipper
-version=0.9.0
-revision=3
+version=0.10.0
+revision=1
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
makedepends="libsndfile-devel python3-devel"
depends="libcdio-paranoia cdrdao python3-gobject python3-musicbrainzngs
python3-mutagen python3-requests python3-pycdio python3-discid
python3-ruamel.yaml flac sox"
+checkdepends="$depends python3-pytest python3-Twisted"
short_desc="Python CD-DA ripper preferring accuracy over speed"
maintainer="Stefano Ragni <st3r4g@protonmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/whipper-team/whipper"
distfiles="https://github.com/whipper-team/whipper/archive/v${version}.tar.gz"
-checksum=3caceeec7ca73c8b73147884b0f8eeacbe66af52900021b564118b88d23afbd2
-
-
-pre_build() {
-# Temporary workaround for https://github.com/whipper-team/whipper/issues/428
- echo "Version: ${version}" > PKG-INFO
-}
+checksum=a6fba11f4460854267c610f066c185e859d7177699b50ef584fc4f705962d356
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] whipper: update to 0.10.0.
2021-07-22 15:18 [PR PATCH] whipper: update to 0.10.0 UsernameRandomlyGenerated
2021-07-23 1:23 ` [PR REVIEW] " ahesford
2021-07-26 7:40 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
@ 2021-07-26 7:42 ` UsernameRandomlyGenerated
2021-07-26 10:45 ` [PR PATCH] [Merged]: " ahesford
3 siblings, 0 replies; 5+ messages in thread
From: UsernameRandomlyGenerated @ 2021-07-26 7:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]
There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository
https://github.com/UsernameRandomlyGenerated/void-packages whipper010
https://github.com/void-linux/void-packages/pull/32140
whipper: update to 0.10.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32140.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-whipper010-32140.patch --]
[-- Type: text/x-diff, Size: 2907 bytes --]
From 13942285168beb73c6828ffe75b0ac9e039d3901 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 22 Jul 2021 17:17:11 +0200
Subject: [PATCH] whipper: update to 0.10.0.
---
.../patches/fix-failed-task-analyzetask.patch | 24 -------------------
srcpkgs/whipper/template | 13 ++++------
2 files changed, 4 insertions(+), 33 deletions(-)
delete mode 100644 srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
diff --git a/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch b/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
deleted file mode 100644
index 361af61042a3..000000000000
--- a/srcpkgs/whipper/patches/fix-failed-task-analyzetask.patch
+++ /dev/null
@@ -1,24 +0,0 @@
-From 305678ec85568e9fdbc888078c11a1f7d4bc0100 Mon Sep 17 00:00:00 2001
-From: Merlijn Wajer <merlijn@wizzup.org>
-Date: Sat, 14 Dec 2019 18:16:30 +0800
-Subject: [PATCH] program/cdparanoia: fix failed() task of AnalyzeTask
-
----
- whipper/program/cdparanoia.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/whipper/program/cdparanoia.py b/whipper/program/cdparanoia.py
-index 636e6f5..f071674 100644
---- a/whipper/program/cdparanoia.py
-+++ b/whipper/program/cdparanoia.py
-@@ -603,7 +603,7 @@ class AnalyzeTask(ctask.PopenTask):
- def failed(self):
- # cdparanoia exits with return code 1 if it can't determine
- # whether it can defeat the audio cache
-- output = "".join(self._output)
-+ output = "".join(o.decode() for o in self._output)
- m = _WARNING_RE.search(output)
- if m or _ABORTING_RE.search(output):
- self.defeatsCache = False
---
-2.17.1
diff --git a/srcpkgs/whipper/template b/srcpkgs/whipper/template
index f25ab359c284..00bca3fea9bf 100644
--- a/srcpkgs/whipper/template
+++ b/srcpkgs/whipper/template
@@ -1,22 +1,17 @@
# Template file for 'whipper'
pkgname=whipper
-version=0.9.0
-revision=3
+version=0.10.0
+revision=1
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
makedepends="libsndfile-devel python3-devel"
depends="libcdio-paranoia cdrdao python3-gobject python3-musicbrainzngs
python3-mutagen python3-requests python3-pycdio python3-discid
python3-ruamel.yaml flac sox"
+checkdepends="$depends python3-pytest python3-Twisted"
short_desc="Python CD-DA ripper preferring accuracy over speed"
maintainer="Stefano Ragni <st3r4g@protonmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/whipper-team/whipper"
distfiles="https://github.com/whipper-team/whipper/archive/v${version}.tar.gz"
-checksum=3caceeec7ca73c8b73147884b0f8eeacbe66af52900021b564118b88d23afbd2
-
-
-pre_build() {
-# Temporary workaround for https://github.com/whipper-team/whipper/issues/428
- echo "Version: ${version}" > PKG-INFO
-}
+checksum=a6fba11f4460854267c610f066c185e859d7177699b50ef584fc4f705962d356
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: whipper: update to 0.10.0.
2021-07-22 15:18 [PR PATCH] whipper: update to 0.10.0 UsernameRandomlyGenerated
` (2 preceding siblings ...)
2021-07-26 7:42 ` UsernameRandomlyGenerated
@ 2021-07-26 10:45 ` ahesford
3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2021-07-26 10:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
There's a merged pull request on the void-packages repository
whipper: update to 0.10.0.
https://github.com/void-linux/void-packages/pull/32140
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-26 10:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 15:18 [PR PATCH] whipper: update to 0.10.0 UsernameRandomlyGenerated
2021-07-23 1:23 ` [PR REVIEW] " ahesford
2021-07-26 7:40 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
2021-07-26 7:42 ` UsernameRandomlyGenerated
2021-07-26 10:45 ` [PR PATCH] [Merged]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).