* [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink
@ 2021-07-20 23:35 AluminumTank
2021-07-23 11:44 ` leahneukirchen
` (14 more replies)
0 siblings, 15 replies; 16+ messages in thread
From: AluminumTank @ 2021-07-20 23:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
New issue by AluminumTank on void-packages repository
https://github.com/void-linux/void-packages/issues/32076
Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### Affected packages:
At minimum, those that have `log/run` symlinked to `/usr/bin/vlogger`. Current list below.
* bluez
* caddy
* dhcp
* go-ipfs
* lldpd
* minidlna
* synapse
* vnstat
* yggdrasil
* znc
* moby
### Expected behavior
Package should include a symlink from `/etc/sv/<pkgname>/log/supervise` to `/run/runit/supervise.<pkgname>-log` if `log/run` is present in the service directory passed to vsv.
### Actual behavior
The `log/supervise` symlink is missing.
### Steps to reproduce the behavior
Just run `xls <pkgname>` on any of the packages in the list above and see that they are missing the `log/supervise` symlink.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
@ 2021-07-23 11:44 ` leahneukirchen
2021-08-02 16:49 ` AluminumTank
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: leahneukirchen @ 2021-07-23 11:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New comment by leahneukirchen on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-885582050
Comment:
In vsv:
```
if [ -r ${PKGDESTDIR}/etc/sv/${service}/log/run ]; then
```
should be `-e`.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
2021-07-23 11:44 ` leahneukirchen
@ 2021-08-02 16:49 ` AluminumTank
2021-08-02 17:34 ` AluminumTank
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: AluminumTank @ 2021-08-02 16:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
New comment by AluminumTank on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-891175228
Comment:
After doing some testing, I determined that the root cause is because the test is following the symlink and not finding `/usr/bin/vlogger`, not because we need `-e` instead of `-r` as @leahneukirchen mentioned. We could add a separate test specifically for symlinks that would work even if they are broken...
```
if [ -L ${PKGDESTDIR}/etc/sv/${service}/log/run ]; then
```
I think that templates that symlink `log/run` to `/usr/bin/vlogger` should be including `runit-void` in `hostmakedepends` and potentially `depends` as well.
Thoughts?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
2021-07-23 11:44 ` leahneukirchen
2021-08-02 16:49 ` AluminumTank
@ 2021-08-02 17:34 ` AluminumTank
2021-10-07 18:18 ` Duncaen
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: AluminumTank @ 2021-08-02 17:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
New comment by AluminumTank on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-891206686
Comment:
I should elaborate that including `runit-void` in `hostmakedepends` would fix this issue without having to modify vsv.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (2 preceding siblings ...)
2021-08-02 17:34 ` AluminumTank
@ 2021-10-07 18:18 ` Duncaen
2021-10-07 18:19 ` Duncaen
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Duncaen @ 2021-10-07 18:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-938041628
Comment:
I don't think adding `runit-void` to host or any dependencies is a good solution for that. There is no need to verify if the symlinks is there, we just need to fix the `xbps-src` to correctly detect symlinked run files as being a "valid" service.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (3 preceding siblings ...)
2021-10-07 18:18 ` Duncaen
@ 2021-10-07 18:19 ` Duncaen
2021-10-29 13:40 ` [ISSUE] [CLOSED] " leahneukirchen
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Duncaen @ 2021-10-07 18:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-938041628
Comment:
I don't think adding `runit-void` to host or any dependencies is a good solution for that, we just need to fix the `xbps-src` to correctly detect symlinked run files as being a "valid" service.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [ISSUE] [CLOSED] `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (4 preceding siblings ...)
2021-10-07 18:19 ` Duncaen
@ 2021-10-29 13:40 ` leahneukirchen
2021-10-29 13:44 ` leahneukirchen
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: leahneukirchen @ 2021-10-29 13:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Closed issue by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/issues/32076
Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### Affected packages:
At minimum, those that have `log/run` symlinked to `/usr/bin/vlogger`. Current list below.
* bluez
* caddy
* dhcp
* go-ipfs
* lldpd
* minidlna
* synapse
* vnstat
* yggdrasil
* znc
* moby
### Expected behavior
Package should include a symlink from `/etc/sv/<pkgname>/log/supervise` to `/run/runit/supervise.<pkgname>-log` if `log/run` is present in the service directory passed to vsv.
### Actual behavior
The `log/supervise` symlink is missing.
### Steps to reproduce the behavior
Just run `xls <pkgname>` on any of the packages in the list above and see that they are missing the `log/supervise` symlink.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (5 preceding siblings ...)
2021-10-29 13:40 ` [ISSUE] [CLOSED] " leahneukirchen
@ 2021-10-29 13:44 ` leahneukirchen
2021-10-29 15:14 ` dkwo
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: leahneukirchen @ 2021-10-29 13:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New comment by leahneukirchen on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954756756
Comment:
Bumped broken packages.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (6 preceding siblings ...)
2021-10-29 13:44 ` leahneukirchen
@ 2021-10-29 15:14 ` dkwo
2021-10-29 15:15 ` dkwo
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2021-10-29 15:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954824908
Comment:
Ehm, this actually breaks things for me
```
$ xi -S bluez
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ...
Name Action Version New version Download size
libical install - 3.0.10_1 -
bluez install - 5.62_2 -
Size required on disk: 5932KB
Space available on disk: 121GB
Do you want to continue? [Y/n]
[*] Verifying package integrity
libical-3.0.10_1: verifying RSA signature...
bluez-5.62_2: verifying RSA signature...
[*] Collecting package files
libical-3.0.10_1: collecting files...
bluez-5.62_2: collecting files...
[*] Unpacking packages
libical-3.0.10_1: unpacking ...
bluez-5.62_2: unpacking ...
ERROR: bluez-5.62_2: [unpack] failed to extract file `./etc/sv/bluetoothd/log/supervise': Directory not empty
ERROR: bluez-5.62_2: [unpack] failed to extract files: Directory not empty
ERROR: bluez-5.62_2: [unpack] failed to unpack files from archive: Directory not empty
Transaction failed! see above for errors.
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (7 preceding siblings ...)
2021-10-29 15:14 ` dkwo
@ 2021-10-29 15:15 ` dkwo
2021-10-29 15:20 ` TinfoilSubmarine
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2021-10-29 15:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954825342
Comment:
Am I doing something dumb?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (8 preceding siblings ...)
2021-10-29 15:15 ` dkwo
@ 2021-10-29 15:20 ` TinfoilSubmarine
2021-10-29 15:31 ` dkwo
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: TinfoilSubmarine @ 2021-10-29 15:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954828900
Comment:
You'll have to manually remove the `/etc/sv/$pkgname/log/supervise` since your system manually created it for you due to the error
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (9 preceding siblings ...)
2021-10-29 15:20 ` TinfoilSubmarine
@ 2021-10-29 15:31 ` dkwo
2021-10-29 15:32 ` TinfoilSubmarine
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2021-10-29 15:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954837007
Comment:
Thanks, but if I do `rm /etc/sv/bluetoothd/supervise`, I still get the same error upon installing bluez.
Did you mean something else?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (10 preceding siblings ...)
2021-10-29 15:31 ` dkwo
@ 2021-10-29 15:32 ` TinfoilSubmarine
2021-10-29 15:33 ` Duncaen
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: TinfoilSubmarine @ 2021-10-29 15:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954837738
Comment:
You need to remove `/etc/sv/bluetoothd/log/supervise`, not `/etc/sv/bluetoothd/supervise`
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (11 preceding siblings ...)
2021-10-29 15:32 ` TinfoilSubmarine
@ 2021-10-29 15:33 ` Duncaen
2021-10-29 15:33 ` Duncaen
2021-10-29 15:34 ` dkwo
14 siblings, 0 replies; 16+ messages in thread
From: Duncaen @ 2021-10-29 15:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954838142
Comment:
`/etc/sv/bluetoothd/supervise` is the wrong link, you might have this issues for both now.
Disable the service, delete both `/etc/sv/bluetoothd/supervise` and `/etc/sv/bluetoothd/supervise` and then do the update.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (12 preceding siblings ...)
2021-10-29 15:33 ` Duncaen
@ 2021-10-29 15:33 ` Duncaen
2021-10-29 15:34 ` dkwo
14 siblings, 0 replies; 16+ messages in thread
From: Duncaen @ 2021-10-29 15:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954838142
Comment:
`/etc/sv/bluetoothd/supervise` is wrong, you might have this issues for both now.
Disable the service, delete both `/etc/sv/bluetoothd/supervise` and `/etc/sv/bluetoothd/supervise` and then do the update.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: `vsv` not creating `log/supervise` when `log/run` is a symlink
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
` (13 preceding siblings ...)
2021-10-29 15:33 ` Duncaen
@ 2021-10-29 15:34 ` dkwo
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2021-10-29 15:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/issues/32076#issuecomment-954838975
Comment:
My bad, thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-10-29 15:34 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 23:35 [ISSUE] `vsv` not creating `log/supervise` when `log/run` is a symlink AluminumTank
2021-07-23 11:44 ` leahneukirchen
2021-08-02 16:49 ` AluminumTank
2021-08-02 17:34 ` AluminumTank
2021-10-07 18:18 ` Duncaen
2021-10-07 18:19 ` Duncaen
2021-10-29 13:40 ` [ISSUE] [CLOSED] " leahneukirchen
2021-10-29 13:44 ` leahneukirchen
2021-10-29 15:14 ` dkwo
2021-10-29 15:15 ` dkwo
2021-10-29 15:20 ` TinfoilSubmarine
2021-10-29 15:31 ` dkwo
2021-10-29 15:32 ` TinfoilSubmarine
2021-10-29 15:33 ` Duncaen
2021-10-29 15:33 ` Duncaen
2021-10-29 15:34 ` dkwo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).