[PR PATCH] xdg-utils: xdg-screensaver needs xset

[PR PATCH] xdg-utils: xdg-screensaver needs xset

[amak79]

[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]

There is a new pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages xdg-utils
https://github.com/void-linux/void-packages/pull/32282

xdg-utils: xdg-screensaver needs xset
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

`xdg-screensaver` will output the following when `xset` isn't installed manually or pulled in by another package.
```
/bin/xdg-screensaver: 900: xset: not found
/bin/xdg-screensaver: 908: [: Illegal number: 
/bin/xdg-screensaver: 647: xset: not found
```

A patch file from https://github.com/void-linux/void-packages/pull/32282.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xdg-utils-32282.patch --]
[-- Type: text/x-diff, Size: 834 bytes --]

From bfbef0efac9e689629c1ba67abc860b6a4f5ab13 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 1 Aug 2021 17:04:00 +1000
Subject: [PATCH] xdg-utils: xdg-screensaver needs xset

---
 srcpkgs/xdg-utils/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/xdg-utils/template b/srcpkgs/xdg-utils/template
index d4094a292126..578730c8fe72 100644
--- a/srcpkgs/xdg-utils/template
+++ b/srcpkgs/xdg-utils/template
@@ -1,11 +1,11 @@
 # Template file for 'xdg-utils'
 pkgname=xdg-utils
 version=1.1.3
-revision=3
+revision=4
 build_style=gnu-configure
 make_check_target=test
 hostmakedepends="xmlto lynx"
-depends="bash"
+depends="bash xset"
 short_desc="Tools to assist applications with various desktop integration tasks"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"

Re: xdg-utils: xdg-screensaver needs xset

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32282#issuecomment-891521107

Comment:
I wonder if we should instead count this as a warning printed, and users can manually install it; it brings 2 library deps in my system (maybe upstream should be fixed to error out properly too).

Anyhow, please uncomment the changelog field.

Re: [PR PATCH] [Updated] xdg-utils: xdg-screensaver needs xset

[amak79]

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]

There is an updated pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages xdg-utils
https://github.com/void-linux/void-packages/pull/32282

xdg-utils: xdg-screensaver needs xset
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

`xdg-screensaver` will output the following when `xset` isn't installed manually or pulled in by another package.
```
/bin/xdg-screensaver: 900: xset: not found
/bin/xdg-screensaver: 908: [: Illegal number: 
/bin/xdg-screensaver: 647: xset: not found
```

A patch file from https://github.com/void-linux/void-packages/pull/32282.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xdg-utils-32282.patch --]
[-- Type: text/x-diff, Size: 1207 bytes --]

From 696a97aa91931b45eaeb3b837ba6a6bf31ab3998 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 1 Aug 2021 17:04:00 +1000
Subject: [PATCH] xdg-utils: xdg-screensaver needs xset

---
 srcpkgs/xdg-utils/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/xdg-utils/template b/srcpkgs/xdg-utils/template
index d4094a292126..b2c323f8c311 100644
--- a/srcpkgs/xdg-utils/template
+++ b/srcpkgs/xdg-utils/template
@@ -1,16 +1,16 @@
 # Template file for 'xdg-utils'
 pkgname=xdg-utils
 version=1.1.3
-revision=3
+revision=4
 build_style=gnu-configure
 make_check_target=test
 hostmakedepends="xmlto lynx"
-depends="bash"
+depends="bash xset"
 short_desc="Tools to assist applications with various desktop integration tasks"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://www.freedesktop.org/wiki/Software/xdg-utils/"
-#changelog="https://cgit.freedesktop.org/xdg/xdg-utils/plain/ChangeLog"
+changelog="https://cgit.freedesktop.org/xdg/xdg-utils/plain/ChangeLog"
 distfiles="https://portland.freedesktop.org/download/${pkgname}-${version}.tar.gz"
 checksum=d798b08af8a8e2063ddde6c9fa3398ca81484f27dec642c5627ffcaa0d4051d9
 

Re: xdg-utils: xdg-screensaver needs xset

[amak79]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/32282#issuecomment-891527073

Comment:
> I wonder if we should instead count this as a warning printed, and users can manually install it; it brings 2 library deps in my system (maybe upstream should be fixed to error out properly too).

I added xset as a dep because that's what other distributions such Alpine, Arch and Gentoo are doing.

> Anyhow, please uncomment the changelog field.

Done.

Re: [PR PATCH] [Merged]: xdg-utils: xdg-screensaver needs xset

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

There's a merged pull request on the void-packages repository

xdg-utils: xdg-screensaver needs xset
https://github.com/void-linux/void-packages/pull/32282

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

`xdg-screensaver` will output the following when `xset` isn't installed manually or pulled in by another package.
```
/bin/xdg-screensaver: 900: xset: not found
/bin/xdg-screensaver: 908: [: Illegal number: 
/bin/xdg-screensaver: 647: xset: not found
```