[PR PATCH] gpodder: update to 3.10.21.

[PR PATCH] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages gpodder
https://github.com/void-linux/void-packages/pull/32401

gpodder: update to 3.10.21.
Also:
- disable tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32401.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-32401.patch --]
[-- Type: text/x-diff, Size: 1442 bytes --]

From 16ce30b1bfd56294cf532b29b9ec41b6608c794c Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sat, 7 Aug 2021 22:47:44 +0300
Subject: [PATCH] gpodder: update to 3.10.21.

Also:
- disable tests.
---
 srcpkgs/gpodder/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 5071875a0123..116437854a3a 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -1,21 +1,22 @@
 # Template file for 'gpodder'
 pkgname=gpodder
-version=3.10.17
+version=3.10.21
 revision=1
 wrksrc="gpodder-${version}"
 hostmakedepends="python3 intltool"
 depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
  python3-html5lib python3-mygpoclient python3-podcastparser"
-checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils"
 short_desc="Podcast client"
 maintainer="bra1nwave <bra1nwave@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/gpodder/gpodder"
 distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=36a04e4d6a81f50b50d1f7691955d4f460e72f71b9519dad42b805a987434210
+checksum=014e619de64d3e3dc8493929af8007b3caf09dd77e153bf778f1708d55946878
 
 do_check() {
-	make releasetest
+	: # unittest require pytest-localserver which is not in the repos,
+	  # had its latest release in 2018 and has a defunct bitbucket repo
+	  # as its source repo.
 }
 
 do_install() {

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684673885

Comment:
Could you link some sources to this? I can not find a single mention of pytest-localserver in the repository, do you mean pytest-httpserver? That one is quite active (last release 2 days ago) and I noticed it's quite common, so we could package it, but it will not be a requirement to merge this PR.

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684675255

Comment:
pytest-localserver : https://pypi.org/project/pytest-localserver/
If pytest-httpserver provides the same fixture I can package it :)

Re: [PR PATCH] [Updated] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages gpodder
https://github.com/void-linux/void-packages/pull/32401

gpodder: update to 3.10.21.
Also:
- disable tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32401.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-32401.patch --]
[-- Type: text/x-diff, Size: 2843 bytes --]

From d80c55bf522ba29ffb4c3cbfd9f4649f738ccfaf Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 00:09:04 +0300
Subject: [PATCH 1/2] New package: python3-pytest-httpserver-1.0.1

---
 srcpkgs/python3-pytest-httpserver/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/python3-pytest-httpserver/template

diff --git a/srcpkgs/python3-pytest-httpserver/template b/srcpkgs/python3-pytest-httpserver/template
new file mode 100644
index 000000000000..6d2c21a40bca
--- /dev/null
+++ b/srcpkgs/python3-pytest-httpserver/template
@@ -0,0 +1,15 @@
+# Template file for 'python3-pytest-httpserver'
+pkgname=python3-pytest-httpserver
+version=1.0.1
+revision=1
+wrksrc="pytest-httpserver-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-pytest python3-Werkzeug"
+short_desc="HTTP server for pytest"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://www.github.com/csernazs/pytest-httpserver"
+changelog="https://raw.githubusercontent.com/csernazs/pytest-httpserver/master/CHANGES.rst"
+distfiles="https://github.com/csernazs/pytest-httpserver/archive/refs/tags/${version}.tar.gz"
+checksum=c475d9c3c16fd8e5c49e1028f8ded2159a9afbb5ea7a2f5886cf534fc7c97e99

From 121a352f735d7afb14540ca24746d5ec4b3c2ee5 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 00:09:12 +0300
Subject: [PATCH 2/2] gpodder: update to 3.10.21.

Also:
- add which to hostmakedepends (needed by the test suite)
- add necessary checkdepends.
---
 srcpkgs/gpodder/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 5071875a0123..42cfc5c352ed 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -1,18 +1,19 @@
 # Template file for 'gpodder'
 pkgname=gpodder
-version=3.10.17
+version=3.10.21
 revision=1
 wrksrc="gpodder-${version}"
-hostmakedepends="python3 intltool"
+hostmakedepends="python3 intltool which"
 depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
  python3-html5lib python3-mygpoclient python3-podcastparser"
-checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils"
+checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils
+ python3-pytest python3-pytest-httpserver python3-pytest-cov python3-requests"
 short_desc="Podcast client"
 maintainer="bra1nwave <bra1nwave@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/gpodder/gpodder"
 distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=36a04e4d6a81f50b50d1f7691955d4f460e72f71b9519dad42b805a987434210
+checksum=014e619de64d3e3dc8493929af8007b3caf09dd77e153bf778f1708d55946878
 
 do_check() {
 	make releasetest

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684678311

Comment:
Done, thanks :)

Re: [PR PATCH] [Updated] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages gpodder
https://github.com/void-linux/void-packages/pull/32401

gpodder: update to 3.10.21.
Also:
- disable tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32401.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-32401.patch --]
[-- Type: text/x-diff, Size: 2876 bytes --]

From 775089ef02f303039608f341cea9d86ba9e3a527 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 00:17:15 +0300
Subject: [PATCH 1/2] gpodder: update to 3.10.21.

Also:
- add which to hostmakedepends (needed by the test suite)
- add necessary checkdepends.
---
 srcpkgs/gpodder/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 5071875a0123..42cfc5c352ed 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -1,18 +1,19 @@
 # Template file for 'gpodder'
 pkgname=gpodder
-version=3.10.17
+version=3.10.21
 revision=1
 wrksrc="gpodder-${version}"
-hostmakedepends="python3 intltool"
+hostmakedepends="python3 intltool which"
 depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
  python3-html5lib python3-mygpoclient python3-podcastparser"
-checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils"
+checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils
+ python3-pytest python3-pytest-httpserver python3-pytest-cov python3-requests"
 short_desc="Podcast client"
 maintainer="bra1nwave <bra1nwave@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/gpodder/gpodder"
 distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=36a04e4d6a81f50b50d1f7691955d4f460e72f71b9519dad42b805a987434210
+checksum=014e619de64d3e3dc8493929af8007b3caf09dd77e153bf778f1708d55946878
 
 do_check() {
 	make releasetest

From 77f86a722b698010f4023b543eb96185b3fa29ba Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 00:17:25 +0300
Subject: [PATCH 2/2] New package: python3-pytest-httpserver-1.0.1

---
 srcpkgs/python3-pytest-httpserver/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-pytest-httpserver/template

diff --git a/srcpkgs/python3-pytest-httpserver/template b/srcpkgs/python3-pytest-httpserver/template
new file mode 100644
index 000000000000..d866ff71c6df
--- /dev/null
+++ b/srcpkgs/python3-pytest-httpserver/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-pytest-httpserver'
+pkgname=python3-pytest-httpserver
+version=1.0.1
+revision=1
+wrksrc="pytest-httpserver-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-pytest python3-Werkzeug"
+short_desc="HTTP server for pytest"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="MIT"
+homepage="https://www.github.com/csernazs/pytest-httpserver"
+changelog="https://raw.githubusercontent.com/csernazs/pytest-httpserver/master/CHANGES.rst"
+distfiles="https://github.com/csernazs/pytest-httpserver/archive/refs/tags/${version}.tar.gz"
+checksum=c475d9c3c16fd8e5c49e1028f8ded2159a9afbb5ea7a2f5886cf534fc7c97e99
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684776520

Comment:
this is the default value of $wrksrc

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684776575

Comment:
Isn't which needed only for check?

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684776670

Comment:
we are not really interested in coverage statistics, how does check handle not having those dependencies?

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684776812

Comment:
Can we replace `${homepage}` with `https://github.com/gpodder/gpodder`?

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684776520

Comment:
this is the default value of $wrksrc, so we can drop this line

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684781214

Comment:
Yep, will add it to checkdepends.

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684781268

Comment:
It breaks unfortunatelly :(

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684781380

Comment:
Ok :)

Re: [PR PATCH] [Updated] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages gpodder
https://github.com/void-linux/void-packages/pull/32401

gpodder: update to 3.10.21.
Also:
- disable tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32401.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-32401.patch --]
[-- Type: text/x-diff, Size: 2925 bytes --]

From 8d4e5f8f3e8e550ce7cec1296c486471881a7277 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 17:18:44 +0300
Subject: [PATCH 1/2] gpodder: update to 3.10.21.

Also
- add necessary checkdepends
- clean the template.
---
 srcpkgs/gpodder/template | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 5071875a0123..24814787ae98 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -1,18 +1,19 @@
 # Template file for 'gpodder'
 pkgname=gpodder
-version=3.10.17
+version=3.10.21
 revision=1
-wrksrc="gpodder-${version}"
-hostmakedepends="python3 intltool"
+hostmakedepends="python3 intltool which"
 depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
  python3-html5lib python3-mygpoclient python3-podcastparser"
-checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils"
+checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils
+ python3-pytest python3-pytest-httpserver python3-pytest-cov python3-requests
+ which"
 short_desc="Podcast client"
 maintainer="bra1nwave <bra1nwave@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/gpodder/gpodder"
-distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=36a04e4d6a81f50b50d1f7691955d4f460e72f71b9519dad42b805a987434210
+distfiles="https://github.com/gpodder/gpodder/archive/${version}.tar.gz"
+checksum=014e619de64d3e3dc8493929af8007b3caf09dd77e153bf778f1708d55946878
 
 do_check() {
 	make releasetest

From 409d71c14f737a2c549f44ac3c170cfde97069bb Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 17:19:55 +0300
Subject: [PATCH 2/2] New package: python3-pytest-httpserver-1.0.1

---
 srcpkgs/python3-pytest-httpserver/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-pytest-httpserver/template

diff --git a/srcpkgs/python3-pytest-httpserver/template b/srcpkgs/python3-pytest-httpserver/template
new file mode 100644
index 000000000000..d866ff71c6df
--- /dev/null
+++ b/srcpkgs/python3-pytest-httpserver/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-pytest-httpserver'
+pkgname=python3-pytest-httpserver
+version=1.0.1
+revision=1
+wrksrc="pytest-httpserver-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-pytest python3-Werkzeug"
+short_desc="HTTP server for pytest"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="MIT"
+homepage="https://www.github.com/csernazs/pytest-httpserver"
+changelog="https://raw.githubusercontent.com/csernazs/pytest-httpserver/master/CHANGES.rst"
+distfiles="https://github.com/csernazs/pytest-httpserver/archive/refs/tags/${version}.tar.gz"
+checksum=c475d9c3c16fd8e5c49e1028f8ded2159a9afbb5ea7a2f5886cf534fc7c97e99
+
+post_install() {
+	vlicense LICENSE
+}

Re: gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#issuecomment-894805152

Comment:
@paper42  All done ;)

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684782665

Comment:
ΟΚ ;)

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684790300

Comment:
My point was that then which can be removed from hostmakedepends or does the build need it?

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684790641

Comment:
Only the test suite needs it, in order to find the python interpreter and possibly other stuff.

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684790993

Comment:
I think you forgot to drop it from hostmakedepends then.

Re: [PR PATCH] [Updated] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages gpodder
https://github.com/void-linux/void-packages/pull/32401

gpodder: update to 3.10.21.
Also:
- disable tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32401.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-32401.patch --]
[-- Type: text/x-diff, Size: 2889 bytes --]

From e51e9b88f141567251ec13b66d14f9f848892743 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 18:30:46 +0300
Subject: [PATCH 1/2] gpodder: update to 3.10.21.

Also
    - add necessary checkdepends
    - clean the template.
---
 srcpkgs/gpodder/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 5071875a0123..fcda9b9728b8 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -1,18 +1,19 @@
 # Template file for 'gpodder'
 pkgname=gpodder
-version=3.10.17
+version=3.10.21
 revision=1
-wrksrc="gpodder-${version}"
 hostmakedepends="python3 intltool"
 depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
  python3-html5lib python3-mygpoclient python3-podcastparser"
-checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils"
+checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils
+ python3-pytest python3-pytest-httpserver python3-pytest-cov python3-requests
+ which"
 short_desc="Podcast client"
 maintainer="bra1nwave <bra1nwave@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/gpodder/gpodder"
-distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=36a04e4d6a81f50b50d1f7691955d4f460e72f71b9519dad42b805a987434210
+distfiles="https://github.com/gpodder/gpodder/archive/${version}.tar.gz"
+checksum=014e619de64d3e3dc8493929af8007b3caf09dd77e153bf778f1708d55946878
 
 do_check() {
 	make releasetest

From e44649646f35b7925fdeee32943e0e0b88f2a773 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 18:31:29 +0300
Subject: [PATCH 2/2] New package: python3-pytest-httpserver-1.0.1

---
 srcpkgs/python3-pytest-httpserver/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-pytest-httpserver/template

diff --git a/srcpkgs/python3-pytest-httpserver/template b/srcpkgs/python3-pytest-httpserver/template
new file mode 100644
index 000000000000..d866ff71c6df
--- /dev/null
+++ b/srcpkgs/python3-pytest-httpserver/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-pytest-httpserver'
+pkgname=python3-pytest-httpserver
+version=1.0.1
+revision=1
+wrksrc="pytest-httpserver-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-pytest python3-Werkzeug"
+short_desc="HTTP server for pytest"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="MIT"
+homepage="https://www.github.com/csernazs/pytest-httpserver"
+changelog="https://raw.githubusercontent.com/csernazs/pytest-httpserver/master/CHANGES.rst"
+distfiles="https://github.com/csernazs/pytest-httpserver/archive/refs/tags/${version}.tar.gz"
+checksum=c475d9c3c16fd8e5c49e1028f8ded2159a9afbb5ea7a2f5886cf534fc7c97e99
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684791795

Comment:
You are right ofc. Fixed.

Re: [PR REVIEW] gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#discussion_r684795558

Comment:
Runtime dependencies are missing python3-mutagen, and python3-requests

Re: [PR PATCH] [Updated] gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages gpodder
https://github.com/void-linux/void-packages/pull/32401

gpodder: update to 3.10.21.
Also:
- disable tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32401.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-32401.patch --]
[-- Type: text/x-diff, Size: 2985 bytes --]

From 0c1733f5501c0a23d68f1518cd0596a2a5f32362 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 23:03:59 +0300
Subject: [PATCH 1/2] gpodder: update to 3.10.21.

Also:
- add necessary packages to depends and checkdepends.
---
 srcpkgs/gpodder/template | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 5071875a0123..caf54726953d 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -1,18 +1,20 @@
 # Template file for 'gpodder'
 pkgname=gpodder
-version=3.10.17
+version=3.10.21
 revision=1
-wrksrc="gpodder-${version}"
 hostmakedepends="python3 intltool"
 depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
- python3-html5lib python3-mygpoclient python3-podcastparser"
-checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils"
+ python3-html5lib python3-mygpoclient python3-podcastparser python3-mutagen
+ python3-requests"
+checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils
+ python3-pytest python3-pytest-httpserver python3-pytest-cov python3-requests
+ which"
 short_desc="Podcast client"
 maintainer="bra1nwave <bra1nwave@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/gpodder/gpodder"
-distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=36a04e4d6a81f50b50d1f7691955d4f460e72f71b9519dad42b805a987434210
+distfiles="https://github.com/gpodder/gpodder/archive/${version}.tar.gz"
+checksum=014e619de64d3e3dc8493929af8007b3caf09dd77e153bf778f1708d55946878
 
 do_check() {
 	make releasetest

From e875500f9bad7b888865cbc94e0789c9e08c79a0 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 8 Aug 2021 23:05:09 +0300
Subject: [PATCH 2/2] New package: python3-pytest-httpserver-1.0.1

---
 srcpkgs/python3-pytest-httpserver/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-pytest-httpserver/template

diff --git a/srcpkgs/python3-pytest-httpserver/template b/srcpkgs/python3-pytest-httpserver/template
new file mode 100644
index 000000000000..d866ff71c6df
--- /dev/null
+++ b/srcpkgs/python3-pytest-httpserver/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-pytest-httpserver'
+pkgname=python3-pytest-httpserver
+version=1.0.1
+revision=1
+wrksrc="pytest-httpserver-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-pytest python3-Werkzeug"
+short_desc="HTTP server for pytest"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="MIT"
+homepage="https://www.github.com/csernazs/pytest-httpserver"
+changelog="https://raw.githubusercontent.com/csernazs/pytest-httpserver/master/CHANGES.rst"
+distfiles="https://github.com/csernazs/pytest-httpserver/archive/refs/tags/${version}.tar.gz"
+checksum=c475d9c3c16fd8e5c49e1028f8ded2159a9afbb5ea7a2f5886cf534fc7c97e99
+
+post_install() {
+	vlicense LICENSE
+}

Re: gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#issuecomment-894851165

Comment:
Thank you for your help with improving the template :)

Re: [PR PATCH] [Merged]: gpodder: update to 3.10.21.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

There's a merged pull request on the void-packages repository

gpodder: update to 3.10.21.
https://github.com/void-linux/void-packages/pull/32401

Description:
Also:
- disable tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: gpodder: update to 3.10.21.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32401#issuecomment-894851480

Comment:
> Thank you for your help with improving the template :)

I am getting back to podcasts on my pc, so having a recent version of gpodder makes sense ;)
Congrats on joining the team :)