* Re: gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
@ 2021-08-25 7:26 ` dkwo
2021-08-25 14:36 ` tornaria
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: dkwo @ 2021-08-25 7:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#issuecomment-905252269
Comment:
Do you understand the i686 test failure?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
2021-08-25 7:26 ` dkwo
@ 2021-08-25 14:36 ` tornaria
2021-08-26 2:41 ` [PR PATCH] [Updated] " tornaria
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tornaria @ 2021-08-25 14:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#issuecomment-905557193
Comment:
> Do you understand the i686 test failure?
I didn't look into it, but I should point out that all these test failures on i686 were already present in gsl-2.6. In fact gsl-2.6 fails 4 tests and gsl-2.7 fails only 3 of them (multifit_nlinear, multilarge_nlinear, spmatrix)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
2021-08-25 7:26 ` dkwo
2021-08-25 14:36 ` tornaria
@ 2021-08-26 2:41 ` tornaria
2021-08-26 2:42 ` tornaria
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tornaria @ 2021-08-26 2:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
There is an updated pull request by tornaria against master on the void-packages repository
https://github.com/tornaria/void-packages gsl
https://github.com/void-linux/void-packages/pull/32657
gsl: update to 2.7.
I compiled and doctested sage-9.4 with this PR + other updates and new packages. All working fine.
A patch file from https://github.com/void-linux/void-packages/pull/32657.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gsl-32657.patch --]
[-- Type: text/x-diff, Size: 1240 bytes --]
From 75638b5b5da5d06798c8bab089965e7db0889fa4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 24 Aug 2021 18:16:32 -0300
Subject: [PATCH] gsl: update to 2.7.
---
srcpkgs/gsl/template | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gsl/template b/srcpkgs/gsl/template
index 1d6677032a30..58b97eeaae59 100644
--- a/srcpkgs/gsl/template
+++ b/srcpkgs/gsl/template
@@ -1,14 +1,19 @@
# Template file for 'gsl'
pkgname=gsl
-version=2.6
+version=2.7
revision=1
build_style=gnu-configure
-short_desc="A numerical library for C and C++ programmers"
+short_desc="Numerical library for C and C++ programmers"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="http://www.gnu.org/software/gsl/gsl.html"
distfiles="${GNU_SITE}/gsl/${pkgname}-${version}.tar.gz"
-checksum=b782339fc7a38fe17689cb39966c4d821236c28018b6593ddb6fd59ee40786a8
+checksum=efbbf3785da0e53038be7907500628b466152dbc3c173a87de1b5eba2e23602b
+
+if [ "$XBPS_TARGET_MACHINE" = "i686" ]; then
+ # avoid numerical noise caused by extended-precision of registers
+ CFLAGS=-ffloat-store
+fi
gsl-devel_package() {
depends="gsl>=${version}_${revision}"
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (2 preceding siblings ...)
2021-08-26 2:41 ` [PR PATCH] [Updated] " tornaria
@ 2021-08-26 2:42 ` tornaria
2021-08-26 7:19 ` dkwo
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tornaria @ 2021-08-26 2:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#issuecomment-906041671
Comment:
All test failures were caused by numerical noise due to extended-precision of 387 registers. Fixed by using `-ffloat-store`.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (3 preceding siblings ...)
2021-08-26 2:42 ` tornaria
@ 2021-08-26 7:19 ` dkwo
2021-08-27 18:13 ` [PR REVIEW] " ericonr
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: dkwo @ 2021-08-26 7:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#issuecomment-906158555
Comment:
Great!
LGTM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (4 preceding siblings ...)
2021-08-26 7:19 ` dkwo
@ 2021-08-27 18:13 ` ericonr
2021-08-27 20:12 ` [PR PATCH] [Updated] " tornaria
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-08-27 18:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#discussion_r697632332
Comment:
Do `case $XBPS_TARGET_MACHINE` and `i686*)` instead.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (5 preceding siblings ...)
2021-08-27 18:13 ` [PR REVIEW] " ericonr
@ 2021-08-27 20:12 ` tornaria
2021-08-27 20:13 ` [PR REVIEW] " tornaria
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tornaria @ 2021-08-27 20:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
There is an updated pull request by tornaria against master on the void-packages repository
https://github.com/tornaria/void-packages gsl
https://github.com/void-linux/void-packages/pull/32657
gsl: update to 2.7.
I compiled and doctested sage-9.4 with this PR + other updates and new packages. All working fine.
A patch file from https://github.com/void-linux/void-packages/pull/32657.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gsl-32657.patch --]
[-- Type: text/x-diff, Size: 1236 bytes --]
From 95d9fecf9da582b19051eb32cf9c339f2960f232 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 24 Aug 2021 18:16:32 -0300
Subject: [PATCH] gsl: update to 2.7.
---
srcpkgs/gsl/template | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gsl/template b/srcpkgs/gsl/template
index 1d6677032a30..ef355472eff7 100644
--- a/srcpkgs/gsl/template
+++ b/srcpkgs/gsl/template
@@ -1,14 +1,19 @@
# Template file for 'gsl'
pkgname=gsl
-version=2.6
+version=2.7
revision=1
build_style=gnu-configure
-short_desc="A numerical library for C and C++ programmers"
+short_desc="Numerical library for C and C++ programmers"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="http://www.gnu.org/software/gsl/gsl.html"
distfiles="${GNU_SITE}/gsl/${pkgname}-${version}.tar.gz"
-checksum=b782339fc7a38fe17689cb39966c4d821236c28018b6593ddb6fd59ee40786a8
+checksum=efbbf3785da0e53038be7907500628b466152dbc3c173a87de1b5eba2e23602b
+
+case $XBPS_TARGET_MACHINE in
+ # avoid numerical noise caused by extended-precision of registers
+ i686*) CFLAGS=-ffloat-store ;;
+esac
gsl-devel_package() {
depends="gsl>=${version}_${revision}"
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (6 preceding siblings ...)
2021-08-27 20:12 ` [PR PATCH] [Updated] " tornaria
@ 2021-08-27 20:13 ` tornaria
2021-08-27 20:59 ` ericonr
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tornaria @ 2021-08-27 20:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
New review comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#discussion_r697694565
Comment:
Done
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (7 preceding siblings ...)
2021-08-27 20:13 ` [PR REVIEW] " tornaria
@ 2021-08-27 20:59 ` ericonr
2021-08-27 20:59 ` [PR PATCH] [Merged]: " ericonr
2021-08-27 21:21 ` tornaria
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-08-27 20:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#issuecomment-907472697
Comment:
I wonder if you could be using sse2 here to avoid the float-store.
Well, if anyone complains about performance we can look into it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Merged]: gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (8 preceding siblings ...)
2021-08-27 20:59 ` ericonr
@ 2021-08-27 20:59 ` ericonr
2021-08-27 21:21 ` tornaria
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-08-27 20:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
There's a merged pull request on the void-packages repository
gsl: update to 2.7.
https://github.com/void-linux/void-packages/pull/32657
Description:
I compiled and doctested sage-9.4 with this PR + other updates and new packages. All working fine.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: gsl: update to 2.7.
2021-08-24 23:31 [PR PATCH] gsl: update to 2.7 tornaria
` (9 preceding siblings ...)
2021-08-27 20:59 ` [PR PATCH] [Merged]: " ericonr
@ 2021-08-27 21:21 ` tornaria
10 siblings, 0 replies; 12+ messages in thread
From: tornaria @ 2021-08-27 21:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/32657#issuecomment-907483389
Comment:
> I wonder if you could be using sse2 here to avoid the float-store.
I tried that and for some reason it didn't work.
Another fix would be to chase the noise and use "volatile" in the few places where it is needed, but It would be a lot of work and we'd never know it's enough. Not worth it IMO.
I assume if one cares about performance then x86_64 is the way to go. I worry much more that all our 64 bit binaries are SSE2 only.
^ permalink raw reply [flat|nested] 12+ messages in thread