From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] qmk: update to 1.0.0.
Date: Mon, 30 Aug 2021 20:07:29 +0200 [thread overview]
Message-ID: <20210830180729.7HzQ7lapUCihBOT9XpNzYv3dceCEP_g6z08lwpgauXs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32685@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/32685#discussion_r698697729
Comment:
Making dependencies different between cross- and natively build is wrong, this should be based on whether `$XBPS_TARGET_MACHINE`'s native gcc is able to compile for the hardware.
next prev parent reply other threads:[~2021-08-30 18:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 11:33 [PR PATCH] " reedts
2021-08-30 18:07 ` Chocimier [this message]
2021-08-30 18:35 ` [PR PATCH] [Updated] " reedts
2021-08-30 18:39 ` reedts
2021-08-30 18:41 ` reedts
2021-08-30 18:43 ` [PR REVIEW] " reedts
2021-08-30 19:30 ` Chocimier
2021-08-30 19:56 ` reedts
2021-08-30 19:57 ` reedts
2021-08-30 20:03 ` Chocimier
2022-03-12 22:38 ` [PR PATCH] [Closed]: " Johnnynator
2022-03-12 22:38 ` Johnnynator
2022-01-14 22:44 [PR PATCH] " ifreund
2022-01-15 10:36 ` [PR REVIEW] " paper42
2022-01-15 10:36 ` paper42
2022-01-15 10:36 ` paper42
2022-01-15 10:36 ` paper42
2022-01-15 11:28 ` ifreund
2022-01-15 11:28 ` ifreund
2022-01-15 11:30 ` ifreund
2022-01-15 12:53 ` ifreund
2022-01-20 0:53 ` paper42
2022-01-20 0:53 ` paper42
2022-01-20 0:53 ` paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830180729.7HzQ7lapUCihBOT9XpNzYv3dceCEP_g6z08lwpgauXs@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).