* [PR PATCH] wesnoth: update to 1.14.17
@ 2021-09-05 15:31 ninewise
2021-09-05 18:55 ` [PR REVIEW] " ericonr
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: ninewise @ 2021-09-05 15:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
There is a new pull request by ninewise against master on the void-packages repository
https://github.com/ninewise/void-packages-1 update/wesnoth
https://github.com/void-linux/void-packages/pull/32845
wesnoth: update to 1.14.17
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32845.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/wesnoth-32845.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]
From a48edd8dfb022292117d2791f590f86586e1a037 Mon Sep 17 00:00:00 2001
From: Felix Van der Jeugt <felix.vanderjeugt@posteo.net>
Date: Sun, 5 Sep 2021 17:30:01 +0200
Subject: [PATCH] wesnoth: update to 1.14.17
---
srcpkgs/wesnoth/template | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/wesnoth/template b/srcpkgs/wesnoth/template
index e79d37bf6b34..4d711c0e69ad 100644
--- a/srcpkgs/wesnoth/template
+++ b/srcpkgs/wesnoth/template
@@ -1,6 +1,6 @@
# Template file for 'wesnoth'
pkgname=wesnoth
-version=1.14.16
+version=1.14.17
revision=1
build_style=cmake
configure_args="-DENABLE_OMP=1"
@@ -14,9 +14,12 @@ maintainer="Philipp Hirsch <itself@hanspolo.net>"
license="GPL-2.0-or-later"
homepage="https://wesnoth.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-checksum=0f52d427e2fb58f4d1961847be4e3564a3c4ad78190042b6d04f83cedac030b5
+checksum=3646cba604e09c12d6900a733bcb78cbf05f2f75f05346630d6529c220f584e1
replaces="wesnoth-data>=0"
+CFLAGS+=" -UNDEBUG "
+CXXFLAGS+=" -UNDEBUG "
+
post_install() {
# runit service
vsv wesnothd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] wesnoth: update to 1.14.17
2021-09-05 15:31 [PR PATCH] wesnoth: update to 1.14.17 ninewise
@ 2021-09-05 18:55 ` ericonr
2021-09-05 19:10 ` [PR PATCH] [Updated] " ninewise
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-09-05 18:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32845#discussion_r702463151
Comment:
```suggestion
CFLAGS="-UNDEBUG"
CXXFLAGS="-UNDEBUG"
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] wesnoth: update to 1.14.17
2021-09-05 15:31 [PR PATCH] wesnoth: update to 1.14.17 ninewise
2021-09-05 18:55 ` [PR REVIEW] " ericonr
@ 2021-09-05 19:10 ` ninewise
2021-09-06 19:12 ` ericonr
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ninewise @ 2021-09-05 19:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
There is an updated pull request by ninewise against master on the void-packages repository
https://github.com/ninewise/void-packages-1 update/wesnoth
https://github.com/void-linux/void-packages/pull/32845
wesnoth: update to 1.14.17
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32845.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/wesnoth-32845.patch --]
[-- Type: text/x-diff, Size: 1107 bytes --]
From 9c7e47372bb0bb293f0b12c8f5578bfee4bfa8e3 Mon Sep 17 00:00:00 2001
From: Felix Van der Jeugt <felix.vanderjeugt@posteo.net>
Date: Sun, 5 Sep 2021 17:30:01 +0200
Subject: [PATCH] wesnoth: update to 1.14.17
---
srcpkgs/wesnoth/template | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/wesnoth/template b/srcpkgs/wesnoth/template
index e79d37bf6b34..0fcc09b29c10 100644
--- a/srcpkgs/wesnoth/template
+++ b/srcpkgs/wesnoth/template
@@ -1,6 +1,6 @@
# Template file for 'wesnoth'
pkgname=wesnoth
-version=1.14.16
+version=1.14.17
revision=1
build_style=cmake
configure_args="-DENABLE_OMP=1"
@@ -14,9 +14,12 @@ maintainer="Philipp Hirsch <itself@hanspolo.net>"
license="GPL-2.0-or-later"
homepage="https://wesnoth.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-checksum=0f52d427e2fb58f4d1961847be4e3564a3c4ad78190042b6d04f83cedac030b5
+checksum=3646cba604e09c12d6900a733bcb78cbf05f2f75f05346630d6529c220f584e1
replaces="wesnoth-data>=0"
+CFLAGS="-UNDEBUG"
+CXXFLAGS="-UNDEBUG"
+
post_install() {
# runit service
vsv wesnothd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] wesnoth: update to 1.14.17
2021-09-05 15:31 [PR PATCH] wesnoth: update to 1.14.17 ninewise
2021-09-05 18:55 ` [PR REVIEW] " ericonr
2021-09-05 19:10 ` [PR PATCH] [Updated] " ninewise
@ 2021-09-06 19:12 ` ericonr
2021-09-06 19:12 ` ericonr
2021-09-06 19:12 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-09-06 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ninewise/void-packages-1 update/wesnoth
https://github.com/void-linux/void-packages/pull/32845
wesnoth: update to 1.14.17
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32845.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/wesnoth-32845.patch --]
[-- Type: text/x-diff, Size: 1242 bytes --]
From 174bf5f9aac627cc5d5b6c2d4cb87d9e43056dd2 Mon Sep 17 00:00:00 2001
From: Felix Van der Jeugt <felix.vanderjeugt@posteo.net>
Date: Sun, 5 Sep 2021 17:30:01 +0200
Subject: [PATCH] wesnoth: update to 1.14.17
Add -UNDEBUG to compiler flags to override the cmake build style
default. Wesnoth's compilation errors out if assertions are disabled.
---
srcpkgs/wesnoth/template | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/wesnoth/template b/srcpkgs/wesnoth/template
index e79d37bf6b34..0fcc09b29c10 100644
--- a/srcpkgs/wesnoth/template
+++ b/srcpkgs/wesnoth/template
@@ -1,6 +1,6 @@
# Template file for 'wesnoth'
pkgname=wesnoth
-version=1.14.16
+version=1.14.17
revision=1
build_style=cmake
configure_args="-DENABLE_OMP=1"
@@ -14,9 +14,12 @@ maintainer="Philipp Hirsch <itself@hanspolo.net>"
license="GPL-2.0-or-later"
homepage="https://wesnoth.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-checksum=0f52d427e2fb58f4d1961847be4e3564a3c4ad78190042b6d04f83cedac030b5
+checksum=3646cba604e09c12d6900a733bcb78cbf05f2f75f05346630d6529c220f584e1
replaces="wesnoth-data>=0"
+CFLAGS="-UNDEBUG"
+CXXFLAGS="-UNDEBUG"
+
post_install() {
# runit service
vsv wesnothd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wesnoth: update to 1.14.17
2021-09-05 15:31 [PR PATCH] wesnoth: update to 1.14.17 ninewise
` (2 preceding siblings ...)
2021-09-06 19:12 ` ericonr
@ 2021-09-06 19:12 ` ericonr
2021-09-06 19:12 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-09-06 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32845#issuecomment-913818222
Comment:
Please include justification for choices in commit messages. I've done it this time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: wesnoth: update to 1.14.17
2021-09-05 15:31 [PR PATCH] wesnoth: update to 1.14.17 ninewise
` (3 preceding siblings ...)
2021-09-06 19:12 ` ericonr
@ 2021-09-06 19:12 ` ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-09-06 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
There's a merged pull request on the void-packages repository
wesnoth: update to 1.14.17
https://github.com/void-linux/void-packages/pull/32845
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-06 19:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 15:31 [PR PATCH] wesnoth: update to 1.14.17 ninewise
2021-09-05 18:55 ` [PR REVIEW] " ericonr
2021-09-05 19:10 ` [PR PATCH] [Updated] " ninewise
2021-09-06 19:12 ` ericonr
2021-09-06 19:12 ` ericonr
2021-09-06 19:12 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).