From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: pounce: update to 2.5.
Date: Sat, 25 Sep 2021 13:25:41 +0200 [thread overview]
Message-ID: <20210925112541.leTBApjs4KVVhF3HzH8nkjCda699ezraTe5_3xfNquM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33110@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33110#issuecomment-927107276
Comment:
> You may assume I'm using to some extend any pkg I'm submitting
that's why we have two possible options:
* I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
* I generally don't use the affected packages but briefly tested this PR
> although I don't see how this helps reviewers at all.
Merging a PR isn't just about clicking a button, the person who merges the PR should make sure it will not break anything (by looking at it, trusting the knowledge of the PR author about the specific package, seeing if the checks succeed, testing it before merging, etc.). The checkboxes might in some cases help with that.
> Unless there's an automated way to check that, I'm not going to go through every submission and manually tick checkboxes.
There is no automated way to check this. Real people **manually** review your PRs, so refusing to do something as simple as clicking on a checkbox isn't nice.
next prev parent reply other threads:[~2021-09-25 11:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 10:23 [PR PATCH] " ailiop-git
2021-09-25 10:58 ` paper42
2021-09-25 11:00 ` ailiop-git
2021-09-25 11:06 ` paper42
2021-09-25 11:09 ` ailiop-git
2021-09-25 11:25 ` paper42 [this message]
2021-09-25 11:27 ` Johnnynator
2021-09-25 11:41 ` ailiop-git
2021-09-25 11:58 ` ahesford
2021-09-25 12:03 ` paper42
2021-09-25 12:14 ` ailiop-git
2021-09-25 13:04 ` ahesford
2021-09-27 11:39 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925112541.leTBApjs4KVVhF3HzH8nkjCda699ezraTe5_3xfNquM@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).