Re: pounce: update to 2.5.

[paper42 <paper42@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2579 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927111547

Comment:
> > From our point of view, all commits look like untested low effort version bumps that might or might not be tested on a whole lot of 1 system.
> 
> That sounds about right. I do not see how submitters ticking on any of those boxes helps in changing this assumption. Whether I use it regularly or I "lightly tested it", should not influence a reviewer's decision, and it is anyway a completely vague statement with no content.

It is one of many metrics which go into reviewing and merging a PR. Sometimes it is valuable, so let's tick it, it's only one click.
 
> The "this is a new package" checkbox is also rather useless, given that this is obvious from the diff.

The purpose is to make people read the quality requirements if they missed them.

> > E.g. #32707 did break on x86_64-musl, you did never tried to fix it or ask someone to help with it.
> > Such PR's just make it look like you do not care about these updates.
> 
> Sorry, but I simply do not have the bandwidth to deal with all test failures and all archs. That also goes on to show how irrelevant those checkboxes are, especially given that travis will anyway build all targets. What difference would it make to any reviewer if I stated that I've built this on x86_64? It's obvious from the travis results what works and what not.

The "Does it build and run successfully?" section is commented out by default and makes sense to be filled only when CI is skipped.

> When skipping CI, uncomment and fill out the following section.

```
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

```

I agree that it's easy to miss and some people think they need to fill it in all PRs even when CI runs.