* Re: [PR REVIEW] parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
@ 2021-10-03 15:23 ` paper42
2021-10-03 15:23 ` paper42
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-10-03 15:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33295#discussion_r720844271
Comment:
Why do we need to install the config file when it only contains a comment?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR REVIEW] parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
2021-10-03 15:23 ` [PR REVIEW] " paper42
@ 2021-10-03 15:23 ` paper42
2021-10-03 15:23 ` paper42
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-10-03 15:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33295#discussion_r720844147
Comment:
this is the default value of $wrksrc, so please remove it
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
2021-10-03 15:23 ` [PR REVIEW] " paper42
2021-10-03 15:23 ` paper42
@ 2021-10-03 15:23 ` paper42
2021-10-03 17:40 ` [PR REVIEW] " ArsenArsen
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-10-03 15:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33295#issuecomment-932972827
Comment:
The commit message should be "New package: $pkgname-$version"
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR REVIEW] parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (2 preceding siblings ...)
2021-10-03 15:23 ` paper42
@ 2021-10-03 17:40 ` ArsenArsen
2021-10-03 17:41 ` [PR PATCH] [Updated] " ArsenArsen
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ArsenArsen @ 2021-10-03 17:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
New review comment by ArsenArsen on void-packages repository
https://github.com/void-linux/void-packages/pull/33295#discussion_r720862115
Comment:
The daemon won't start without it, and, IMO, it helps to have a blank/default configuration at least so that it's easily guessable by admins.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (3 preceding siblings ...)
2021-10-03 17:40 ` [PR REVIEW] " ArsenArsen
@ 2021-10-03 17:41 ` ArsenArsen
2021-10-06 9:49 ` ArsenArsen
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ArsenArsen @ 2021-10-03 17:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
There is an updated pull request by ArsenArsen against master on the void-packages repository
https://github.com/ArsenArsen/void-packages new-package-parpd
https://github.com/void-linux/void-packages/pull/33295
parpd: new package
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64
- [ ] aarch64-musl - does not appear to build on musl? I can't do further testing right now, but it's probably due to some glibc-specific transient header include.
A patch file from https://github.com/void-linux/void-packages/pull/33295.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-parpd-33295.patch --]
[-- Type: text/x-diff, Size: 1761 bytes --]
From 23307e74fdcceae875064f6b452e2a7b13824f89 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sun, 3 Oct 2021 15:03:40 +0200
Subject: [PATCH] New package: parpd-1.7
---
srcpkgs/parpd/files/parpd.conf | 1 +
srcpkgs/parpd/files/parpd/run | 3 +++
srcpkgs/parpd/template | 20 ++++++++++++++++++++
3 files changed, 24 insertions(+)
create mode 100644 srcpkgs/parpd/files/parpd.conf
create mode 100644 srcpkgs/parpd/files/parpd/run
create mode 100644 srcpkgs/parpd/template
diff --git a/srcpkgs/parpd/files/parpd.conf b/srcpkgs/parpd/files/parpd.conf
new file mode 100644
index 000000000000..926fc5f839d2
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd.conf
@@ -0,0 +1 @@
+# see parpd.conf(5)
diff --git a/srcpkgs/parpd/files/parpd/run b/srcpkgs/parpd/files/parpd/run
new file mode 100644
index 000000000000..029dfdac68dd
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+exec parpd ${OPTS:=-fl} 1>&2
diff --git a/srcpkgs/parpd/template b/srcpkgs/parpd/template
new file mode 100644
index 000000000000..0991d61360f8
--- /dev/null
+++ b/srcpkgs/parpd/template
@@ -0,0 +1,20 @@
+# Template file for 'parpd'
+pkgname=parpd
+version=1.7
+revision=1
+build_style=gnu-makefile
+make_install_args="BINDIR=/usr/bin"
+short_desc="RFC 1027 compliant Proxy ARP Daemon"
+maintainer="Arsen Arsenović <arsen@aarsen.me>"
+license="BSD-2-Clause"
+homepage="https://roy.marples.name/projects/parpd/"
+distfiles="https://roy.marples.name/downloads/parpd/parpd-${version}.tar.xz"
+checksum=f1f2ed753243b86205922ab0ec1cd0f426779e6b8c273206f0568e819a3fe3b4
+conf_files=/etc/parpd.conf
+
+post_install() {
+ vsv parpd
+ vlicense LICENSE
+
+ vconf "${FILESDIR}/parpd.conf"
+}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (4 preceding siblings ...)
2021-10-03 17:41 ` [PR PATCH] [Updated] " ArsenArsen
@ 2021-10-06 9:49 ` ArsenArsen
2021-10-06 9:53 ` ArsenArsen
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ArsenArsen @ 2021-10-06 9:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
There is an updated pull request by ArsenArsen against master on the void-packages repository
https://github.com/ArsenArsen/void-packages new-package-parpd
https://github.com/void-linux/void-packages/pull/33295
parpd: new package
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64
- [ ] aarch64-musl - does not appear to build on musl? I can't do further testing right now, but it's probably due to some glibc-specific transient header include.
A patch file from https://github.com/void-linux/void-packages/pull/33295.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-parpd-33295.patch --]
[-- Type: text/x-diff, Size: 2827 bytes --]
From f4b60bd6e2856d34fb88e2c3c94cea22920c0aab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sun, 3 Oct 2021 15:03:40 +0200
Subject: [PATCH] New package: parpd-1.7
---
srcpkgs/parpd/files/parpd.conf | 1 +
srcpkgs/parpd/files/parpd/run | 3 +++
.../patches/0001-fix-building-on-musl.patch | 24 +++++++++++++++++++
srcpkgs/parpd/template | 20 ++++++++++++++++
4 files changed, 48 insertions(+)
create mode 100644 srcpkgs/parpd/files/parpd.conf
create mode 100644 srcpkgs/parpd/files/parpd/run
create mode 100644 srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
create mode 100644 srcpkgs/parpd/template
diff --git a/srcpkgs/parpd/files/parpd.conf b/srcpkgs/parpd/files/parpd.conf
new file mode 100644
index 000000000000..926fc5f839d2
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd.conf
@@ -0,0 +1 @@
+# see parpd.conf(5)
diff --git a/srcpkgs/parpd/files/parpd/run b/srcpkgs/parpd/files/parpd/run
new file mode 100644
index 000000000000..029dfdac68dd
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+exec parpd ${OPTS:=-fl} 1>&2
diff --git a/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch b/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
new file mode 100644
index 000000000000..65799c0abf2e
--- /dev/null
+++ b/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
@@ -0,0 +1,24 @@
+From 466a788c7533b19f20f6d91514773e89e87f5f6e Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
+Date: Wed, 6 Oct 2021 11:37:14 +0200
+Subject: [PATCH] fix building on musl
+
+---
+ parpd.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/parpd.c b/parpd.c
+index a178696..19e266c 100644
+--- a/parpd.c
++++ b/parpd.c
+@@ -57,6 +57,7 @@ const char copyright[] = "Copyright (c) 2008-2017 Roy Marples";
+ #include <search.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <signal.h>
+ #include <string.h>
+ #include <syslog.h>
+ #include <unistd.h>
+--
+2.32.0
+
diff --git a/srcpkgs/parpd/template b/srcpkgs/parpd/template
new file mode 100644
index 000000000000..0991d61360f8
--- /dev/null
+++ b/srcpkgs/parpd/template
@@ -0,0 +1,20 @@
+# Template file for 'parpd'
+pkgname=parpd
+version=1.7
+revision=1
+build_style=gnu-makefile
+make_install_args="BINDIR=/usr/bin"
+short_desc="RFC 1027 compliant Proxy ARP Daemon"
+maintainer="Arsen Arsenović <arsen@aarsen.me>"
+license="BSD-2-Clause"
+homepage="https://roy.marples.name/projects/parpd/"
+distfiles="https://roy.marples.name/downloads/parpd/parpd-${version}.tar.xz"
+checksum=f1f2ed753243b86205922ab0ec1cd0f426779e6b8c273206f0568e819a3fe3b4
+conf_files=/etc/parpd.conf
+
+post_install() {
+ vsv parpd
+ vlicense LICENSE
+
+ vconf "${FILESDIR}/parpd.conf"
+}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (5 preceding siblings ...)
2021-10-06 9:49 ` ArsenArsen
@ 2021-10-06 9:53 ` ArsenArsen
2021-10-08 20:04 ` paper42
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ArsenArsen @ 2021-10-06 9:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by ArsenArsen on void-packages repository
https://github.com/void-linux/void-packages/pull/33295#issuecomment-935873079
Comment:
With that patch added, this builds on `{aarch64,x86_64}{,-musl}`. Tested via `for x in {aarch64,x86_64}{,-musl}; do ./xbps-src -a "$x" pkg parpd || break; done`.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (6 preceding siblings ...)
2021-10-06 9:53 ` ArsenArsen
@ 2021-10-08 20:04 ` paper42
2021-10-09 20:20 ` [PR PATCH] [Updated] " ArsenArsen
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-10-08 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33295#issuecomment-939086705
Comment:
It seems like they forgot to `#include <sys/uio.h>` in this release, but fixed it in https://roy.marples.name/git/parpd/commit/f126cdfe98d99d083b497fefc2a2cf0eef4ef0b6
```
=> parpd-1.7_1: running do_build ...
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -DSYSCONFDIR=\"/etc\" -c parpd.c -o parpd.o
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -DSYSCONFDIR=\"/etc\" -c eloop.c -o eloop.o
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -DSYSCONFDIR=\"/etc\" -c lpf.c -o lpf.o
sed -e 's:@SYSCONFDIR@:/etc:g' parpd.8.in >parpd.8
lpf.c: In function 'bpf_write':
lpf.c:126:9: warning: implicit declaration of function 'writev'; did you mean 'write'? [-Wimplicit-function-declaration]
126 | return writev(ifp->fd, iov, 2);
| ^~~~~~
| write
cc -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o parpd parpd.o eloop.o lpf.
```
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (7 preceding siblings ...)
2021-10-08 20:04 ` paper42
@ 2021-10-09 20:20 ` ArsenArsen
2021-10-09 20:20 ` ArsenArsen
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ArsenArsen @ 2021-10-09 20:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
There is an updated pull request by ArsenArsen against master on the void-packages repository
https://github.com/ArsenArsen/void-packages new-package-parpd
https://github.com/void-linux/void-packages/pull/33295
parpd: new package
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64
- [ ] aarch64-musl - does not appear to build on musl? I can't do further testing right now, but it's probably due to some glibc-specific transient header include.
A patch file from https://github.com/void-linux/void-packages/pull/33295.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-parpd-33295.patch --]
[-- Type: text/x-diff, Size: 4457 bytes --]
From 3482aa0c351fb95cc77339cd794abc94b4c687f2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sun, 3 Oct 2021 15:03:40 +0200
Subject: [PATCH] New package: parpd-1.7
---
srcpkgs/parpd/files/parpd.conf | 1 +
srcpkgs/parpd/files/parpd/run | 3 ++
.../patches/0001-fix-building-on-musl.patch | 24 +++++++++++
.../0002-Linux-File-compile-warnings.patch | 43 +++++++++++++++++++
srcpkgs/parpd/template | 20 +++++++++
5 files changed, 91 insertions(+)
create mode 100644 srcpkgs/parpd/files/parpd.conf
create mode 100644 srcpkgs/parpd/files/parpd/run
create mode 100644 srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
create mode 100644 srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch
create mode 100644 srcpkgs/parpd/template
diff --git a/srcpkgs/parpd/files/parpd.conf b/srcpkgs/parpd/files/parpd.conf
new file mode 100644
index 000000000000..926fc5f839d2
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd.conf
@@ -0,0 +1 @@
+# see parpd.conf(5)
diff --git a/srcpkgs/parpd/files/parpd/run b/srcpkgs/parpd/files/parpd/run
new file mode 100644
index 000000000000..029dfdac68dd
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+exec parpd ${OPTS:=-fl} 1>&2
diff --git a/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch b/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
new file mode 100644
index 000000000000..71d6efe01d33
--- /dev/null
+++ b/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
@@ -0,0 +1,24 @@
+From 466a788c7533b19f20f6d91514773e89e87f5f6e Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
+Date: Wed, 6 Oct 2021 11:37:14 +0200
+Subject: [PATCH 1/2] fix building on musl
+
+---
+ parpd.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/parpd.c b/parpd.c
+index a178696..19e266c 100644
+--- a/parpd.c
++++ b/parpd.c
+@@ -57,6 +57,7 @@ const char copyright[] = "Copyright (c) 2008-2017 Roy Marples";
+ #include <search.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <signal.h>
+ #include <string.h>
+ #include <syslog.h>
+ #include <unistd.h>
+--
+2.32.0
+
diff --git a/srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch b/srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch
new file mode 100644
index 000000000000..c57b45e19d51
--- /dev/null
+++ b/srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch
@@ -0,0 +1,43 @@
+From 5b32ed79ccc1c9bb9a5bd815c28c4a4730cd1cc5 Mon Sep 17 00:00:00 2001
+From: Roy Marples <roy@marples.name>
+Date: Mon, 7 Oct 2019 15:07:25 +0100
+Subject: [PATCH 2/2] Linux: File compile warnings
+
+---
+ lpf.c | 7 ++++---
+ 1 file changed, 4 insertions(+), 3 deletions(-)
+
+diff --git a/lpf.c b/lpf.c
+index 36cbd1c..cfd517b 100644
+--- a/lpf.c
++++ b/lpf.c
+@@ -27,6 +27,7 @@
+ #include <sys/types.h>
+ #include <sys/ioctl.h>
+ #include <sys/socket.h>
++#include <sys/uio.h>
+
+ #include <arpa/inet.h>
+ #include <net/if.h>
+@@ -91,7 +92,7 @@ bpf_open_arp(struct interface *ifp)
+ memset(&su, 0, sizeof(su));
+ su.sll.sll_family = PF_PACKET;
+ su.sll.sll_protocol = htons(ETH_P_ALL);
+- su.sll.sll_ifindex = if_nametoindex(ifp->ifname);
++ su.sll.sll_ifindex = (int)if_nametoindex(ifp->ifname);
+ if (bind(s, &su.sa, sizeof(su.sll)) == -1)
+ goto eexit;
+
+@@ -140,7 +141,7 @@ bpf_read(struct interface *ifp, void *data, size_t len)
+ }
+ bytes -= ETHER_HDR_LEN;
+ if ((size_t)bytes > len)
+- bytes = len;
+- memcpy(data, ifp->buffer + ETHER_HDR_LEN, bytes);
++ bytes = (ssize_t)len;
++ memcpy(data, ifp->buffer + ETHER_HDR_LEN, (size_t)bytes);
+ return bytes;
+ }
+--
+2.32.0
+
diff --git a/srcpkgs/parpd/template b/srcpkgs/parpd/template
new file mode 100644
index 000000000000..0991d61360f8
--- /dev/null
+++ b/srcpkgs/parpd/template
@@ -0,0 +1,20 @@
+# Template file for 'parpd'
+pkgname=parpd
+version=1.7
+revision=1
+build_style=gnu-makefile
+make_install_args="BINDIR=/usr/bin"
+short_desc="RFC 1027 compliant Proxy ARP Daemon"
+maintainer="Arsen Arsenović <arsen@aarsen.me>"
+license="BSD-2-Clause"
+homepage="https://roy.marples.name/projects/parpd/"
+distfiles="https://roy.marples.name/downloads/parpd/parpd-${version}.tar.xz"
+checksum=f1f2ed753243b86205922ab0ec1cd0f426779e6b8c273206f0568e819a3fe3b4
+conf_files=/etc/parpd.conf
+
+post_install() {
+ vsv parpd
+ vlicense LICENSE
+
+ vconf "${FILESDIR}/parpd.conf"
+}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (8 preceding siblings ...)
2021-10-09 20:20 ` [PR PATCH] [Updated] " ArsenArsen
@ 2021-10-09 20:20 ` ArsenArsen
2021-10-09 20:26 ` [PR PATCH] [Updated] " ArsenArsen
2021-10-11 22:00 ` [PR PATCH] [Merged]: " paper42
11 siblings, 0 replies; 13+ messages in thread
From: ArsenArsen @ 2021-10-09 20:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New comment by ArsenArsen on void-packages repository
https://github.com/void-linux/void-packages/pull/33295#issuecomment-939356575
Comment:
right, that fixes that warning
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (9 preceding siblings ...)
2021-10-09 20:20 ` ArsenArsen
@ 2021-10-09 20:26 ` ArsenArsen
2021-10-11 22:00 ` [PR PATCH] [Merged]: " paper42
11 siblings, 0 replies; 13+ messages in thread
From: ArsenArsen @ 2021-10-09 20:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
There is an updated pull request by ArsenArsen against master on the void-packages repository
https://github.com/ArsenArsen/void-packages new-package-parpd
https://github.com/void-linux/void-packages/pull/33295
parpd: new package
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64
- [ ] aarch64-musl - does not appear to build on musl? I can't do further testing right now, but it's probably due to some glibc-specific transient header include.
A patch file from https://github.com/void-linux/void-packages/pull/33295.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-parpd-33295.patch --]
[-- Type: text/x-diff, Size: 4457 bytes --]
From fa87815246277657959da359b42aa766e551c987 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sun, 3 Oct 2021 15:03:40 +0200
Subject: [PATCH] New package: parpd-1.7
---
srcpkgs/parpd/files/parpd.conf | 1 +
srcpkgs/parpd/files/parpd/run | 3 ++
.../patches/0001-fix-building-on-musl.patch | 24 +++++++++++
.../0002-Linux-File-compile-warnings.patch | 43 +++++++++++++++++++
srcpkgs/parpd/template | 20 +++++++++
5 files changed, 91 insertions(+)
create mode 100644 srcpkgs/parpd/files/parpd.conf
create mode 100644 srcpkgs/parpd/files/parpd/run
create mode 100644 srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
create mode 100644 srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch
create mode 100644 srcpkgs/parpd/template
diff --git a/srcpkgs/parpd/files/parpd.conf b/srcpkgs/parpd/files/parpd.conf
new file mode 100644
index 000000000000..926fc5f839d2
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd.conf
@@ -0,0 +1 @@
+# see parpd.conf(5)
diff --git a/srcpkgs/parpd/files/parpd/run b/srcpkgs/parpd/files/parpd/run
new file mode 100644
index 000000000000..029dfdac68dd
--- /dev/null
+++ b/srcpkgs/parpd/files/parpd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+exec parpd ${OPTS:=-fl} 1>&2
diff --git a/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch b/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
new file mode 100644
index 000000000000..71d6efe01d33
--- /dev/null
+++ b/srcpkgs/parpd/patches/0001-fix-building-on-musl.patch
@@ -0,0 +1,24 @@
+From 466a788c7533b19f20f6d91514773e89e87f5f6e Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
+Date: Wed, 6 Oct 2021 11:37:14 +0200
+Subject: [PATCH 1/2] fix building on musl
+
+---
+ parpd.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/parpd.c b/parpd.c
+index a178696..19e266c 100644
+--- a/parpd.c
++++ b/parpd.c
+@@ -57,6 +57,7 @@ const char copyright[] = "Copyright (c) 2008-2017 Roy Marples";
+ #include <search.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <signal.h>
+ #include <string.h>
+ #include <syslog.h>
+ #include <unistd.h>
+--
+2.32.0
+
diff --git a/srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch b/srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch
new file mode 100644
index 000000000000..c57b45e19d51
--- /dev/null
+++ b/srcpkgs/parpd/patches/0002-Linux-File-compile-warnings.patch
@@ -0,0 +1,43 @@
+From 5b32ed79ccc1c9bb9a5bd815c28c4a4730cd1cc5 Mon Sep 17 00:00:00 2001
+From: Roy Marples <roy@marples.name>
+Date: Mon, 7 Oct 2019 15:07:25 +0100
+Subject: [PATCH 2/2] Linux: File compile warnings
+
+---
+ lpf.c | 7 ++++---
+ 1 file changed, 4 insertions(+), 3 deletions(-)
+
+diff --git a/lpf.c b/lpf.c
+index 36cbd1c..cfd517b 100644
+--- a/lpf.c
++++ b/lpf.c
+@@ -27,6 +27,7 @@
+ #include <sys/types.h>
+ #include <sys/ioctl.h>
+ #include <sys/socket.h>
++#include <sys/uio.h>
+
+ #include <arpa/inet.h>
+ #include <net/if.h>
+@@ -91,7 +92,7 @@ bpf_open_arp(struct interface *ifp)
+ memset(&su, 0, sizeof(su));
+ su.sll.sll_family = PF_PACKET;
+ su.sll.sll_protocol = htons(ETH_P_ALL);
+- su.sll.sll_ifindex = if_nametoindex(ifp->ifname);
++ su.sll.sll_ifindex = (int)if_nametoindex(ifp->ifname);
+ if (bind(s, &su.sa, sizeof(su.sll)) == -1)
+ goto eexit;
+
+@@ -140,7 +141,7 @@ bpf_read(struct interface *ifp, void *data, size_t len)
+ }
+ bytes -= ETHER_HDR_LEN;
+ if ((size_t)bytes > len)
+- bytes = len;
+- memcpy(data, ifp->buffer + ETHER_HDR_LEN, bytes);
++ bytes = (ssize_t)len;
++ memcpy(data, ifp->buffer + ETHER_HDR_LEN, (size_t)bytes);
+ return bytes;
+ }
+--
+2.32.0
+
diff --git a/srcpkgs/parpd/template b/srcpkgs/parpd/template
new file mode 100644
index 000000000000..0991d61360f8
--- /dev/null
+++ b/srcpkgs/parpd/template
@@ -0,0 +1,20 @@
+# Template file for 'parpd'
+pkgname=parpd
+version=1.7
+revision=1
+build_style=gnu-makefile
+make_install_args="BINDIR=/usr/bin"
+short_desc="RFC 1027 compliant Proxy ARP Daemon"
+maintainer="Arsen Arsenović <arsen@aarsen.me>"
+license="BSD-2-Clause"
+homepage="https://roy.marples.name/projects/parpd/"
+distfiles="https://roy.marples.name/downloads/parpd/parpd-${version}.tar.xz"
+checksum=f1f2ed753243b86205922ab0ec1cd0f426779e6b8c273206f0568e819a3fe3b4
+conf_files=/etc/parpd.conf
+
+post_install() {
+ vsv parpd
+ vlicense LICENSE
+
+ vconf "${FILESDIR}/parpd.conf"
+}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Merged]: parpd: new package
2021-10-03 13:41 [PR PATCH] parpd: new package ArsenArsen
` (10 preceding siblings ...)
2021-10-09 20:26 ` [PR PATCH] [Updated] " ArsenArsen
@ 2021-10-11 22:00 ` paper42
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-10-11 22:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
There's a merged pull request on the void-packages repository
parpd: new package
https://github.com/void-linux/void-packages/pull/33295
Description:
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64
- [ ] aarch64-musl - does not appear to build on musl? I can't do further testing right now, but it's probably due to some glibc-specific transient header include.
^ permalink raw reply [flat|nested] 13+ messages in thread