* [PR PATCH] vifm: update to 0.12 @ 2021-10-07 11:17 FollieHiyuki 2021-10-07 11:19 ` FollieHiyuki ` (4 more replies) 0 siblings, 5 replies; 6+ messages in thread From: FollieHiyuki @ 2021-10-07 11:17 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 1570 bytes --] There is a new pull request by FollieHiyuki against master on the void-packages repository https://github.com/FollieHiyuki/void-packages vifm-update https://github.com/void-linux/void-packages/pull/33401 vifm: update to 0.12 <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/33401.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-vifm-update-33401.patch --] [-- Type: text/x-diff, Size: 2063 bytes --] From ef1db8b07c5d81e7f6e75441df64012dc181e3ab Mon Sep 17 00:00:00 2001 From: FollieHiyuki <folliekazetani@protonmail.com> Date: Thu, 7 Oct 2021 18:12:57 +0700 Subject: [PATCH] vifm: update to 0.12 --- .../vifm/patches/disable-failed-tests.patch | 21 +++++++++++++++++++ srcpkgs/vifm/template | 4 ++-- 2 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 srcpkgs/vifm/patches/disable-failed-tests.patch diff --git a/srcpkgs/vifm/patches/disable-failed-tests.patch b/srcpkgs/vifm/patches/disable-failed-tests.patch new file mode 100644 index 000000000000..0f31a4817d63 --- /dev/null +++ b/srcpkgs/vifm/patches/disable-failed-tests.patch @@ -0,0 +1,21 @@ +Index: tests/Makefile +==================================== +--- a/tests/Makefile ++++ b/tests/Makefile +@@ -67,14 +67,14 @@ B ?= + BUILD := $(B)bin/build/$(BINSUBDIR) + + # engine +-suites += abbrevs autocmds cmds commands completion keys options parsing ++suites += abbrevs autocmds cmds completion keys options parsing + suites += text_buffer variables + # io + suites += ioeta ionotif iop ior + # ui + suites += colmgr column_view viewcolumns_parser + # everything else +-suites += bmarks env escape fileops filetype filter lua misc undo utils ++suites += bmarks env escape filetype filter undo utils + + # these are built, but not automatically executed + apps := fuzz regs_shmem_app diff --git a/srcpkgs/vifm/template b/srcpkgs/vifm/template index a6d632d27e33..252d56ea96ef 100644 --- a/srcpkgs/vifm/template +++ b/srcpkgs/vifm/template @@ -1,6 +1,6 @@ # Template file for 'vifm' pkgname=vifm -version=0.11 +version=0.12 revision=1 build_style=gnu-configure configure_args="--without-gtk" @@ -12,7 +12,7 @@ maintainer="Alessio Sergi <al3hex@gmail.com>" license="GPL-2.0-or-later" homepage="https://vifm.info/" distfiles="${SOURCEFORGE_SITE}/vifm/vifm-${version}.tar.bz2" -checksum=d06f7e25f1ba0936f27f3d34401cc9eaa50ccc5a5e70ad5659e5014f04691e67 +checksum=33a9618f32b35b5b8c64483884f9ad09963ca8465b2935def79159028e27b2c0 CFLAGS="-fcommon" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: vifm: update to 0.12 2021-10-07 11:17 [PR PATCH] vifm: update to 0.12 FollieHiyuki @ 2021-10-07 11:19 ` FollieHiyuki 2021-10-08 13:20 ` ericonr ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: FollieHiyuki @ 2021-10-07 11:19 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 313 bytes --] New comment by FollieHiyuki on void-packages repository https://github.com/void-linux/void-packages/pull/33401#issuecomment-937697788 Comment: Reopen of #33187. Tests that are disabled are: - fileopts: failed on `chown` process - commands, lua: segmentation fault (don't know why) - misc: `$TERM` is not set ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: vifm: update to 0.12 2021-10-07 11:17 [PR PATCH] vifm: update to 0.12 FollieHiyuki 2021-10-07 11:19 ` FollieHiyuki @ 2021-10-08 13:20 ` ericonr 2021-10-08 13:59 ` FollieHiyuki ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: ericonr @ 2021-10-08 13:20 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 237 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/33401#issuecomment-938638442 Comment: Please document the failures in the commit message. Does setting `TERM` in `pre_check` help any? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: vifm: update to 0.12 2021-10-07 11:17 [PR PATCH] vifm: update to 0.12 FollieHiyuki 2021-10-07 11:19 ` FollieHiyuki 2021-10-08 13:20 ` ericonr @ 2021-10-08 13:59 ` FollieHiyuki 2021-10-08 14:05 ` [PR PATCH] [Updated] " FollieHiyuki 2021-10-08 14:09 ` [PR PATCH] [Merged]: " ericonr 4 siblings, 0 replies; 6+ messages in thread From: FollieHiyuki @ 2021-10-08 13:59 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 294 bytes --] New comment by FollieHiyuki on void-packages repository https://github.com/void-linux/void-packages/pull/33401#issuecomment-938666344 Comment: Setting `TERM` in `pre_check` makes the misc testsuite segfault as the other. I can disable just a part of fileopts testsuite and let the other run. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] vifm: update to 0.12 2021-10-07 11:17 [PR PATCH] vifm: update to 0.12 FollieHiyuki ` (2 preceding siblings ...) 2021-10-08 13:59 ` FollieHiyuki @ 2021-10-08 14:05 ` FollieHiyuki 2021-10-08 14:09 ` [PR PATCH] [Merged]: " ericonr 4 siblings, 0 replies; 6+ messages in thread From: FollieHiyuki @ 2021-10-08 14:05 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 1575 bytes --] There is an updated pull request by FollieHiyuki against master on the void-packages repository https://github.com/FollieHiyuki/void-packages vifm-update https://github.com/void-linux/void-packages/pull/33401 vifm: update to 0.12 <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/33401.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-vifm-update-33401.patch --] [-- Type: text/x-diff, Size: 2944 bytes --] From f23094ce4e25d8b7c19e5f8ffebc9cb1f5064c9c Mon Sep 17 00:00:00 2001 From: FollieHiyuki <folliekazetani@protonmail.com> Date: Thu, 7 Oct 2021 18:12:57 +0700 Subject: [PATCH] vifm: update to 0.12 Disable failed testsuites: - fileopts: disable tests for `chown` process with GID - commands, lua: segmentation fault - misc: fails because `TERM` is not set. But setting it to a random value, eg. `xterm-256color` makes it segmentation fault --- .../vifm/patches/disable-failed-tests.patch | 38 +++++++++++++++++++ srcpkgs/vifm/template | 4 +- 2 files changed, 40 insertions(+), 2 deletions(-) create mode 100644 srcpkgs/vifm/patches/disable-failed-tests.patch diff --git a/srcpkgs/vifm/patches/disable-failed-tests.patch b/srcpkgs/vifm/patches/disable-failed-tests.patch new file mode 100644 index 000000000000..f674a4be66d8 --- /dev/null +++ b/srcpkgs/vifm/patches/disable-failed-tests.patch @@ -0,0 +1,38 @@ +diff --git tests/Makefile tests/Makefile +index 1419a4edd..a213d70ef 100644 +--- a/tests/Makefile ++++ b/tests/Makefile +@@ -67,14 +67,14 @@ B ?= + BUILD := $(B)bin/build/$(BINSUBDIR) + + # engine +-suites += abbrevs autocmds cmds commands completion keys options parsing ++suites += abbrevs autocmds cmds completion keys options parsing + suites += text_buffer variables + # io + suites += ioeta ionotif iop ior + # ui + suites += colmgr column_view viewcolumns_parser + # everything else +-suites += bmarks env escape fileops filetype filter lua misc undo utils ++suites += bmarks env escape fileops filetype filter undo utils + + # these are built, but not automatically executed + apps := fuzz regs_shmem_app +diff --git tests/fileops/chown.c tests/fileops/chown.c +index ef7b1a405..cd2c33388 100644 +--- a/tests/fileops/chown.c ++++ b/tests/fileops/chown.c +@@ -65,12 +65,10 @@ TEST(file_group_is_changed, IF(has_more_than_one_group)) + mark_selection_or_current(curr_view); + fops_chown(0, 1, 0, gid1); + assert_success(os_stat("dir/chown-me", &s)); +- assert_true(s.st_gid == gid1); + + mark_selection_or_current(curr_view); + fops_chown(0, 1, 0, gid2); + assert_success(os_stat("dir/chown-me", &s)); +- assert_true(s.st_gid == gid2); + + assert_success(unlink("dir/chown-me")); + assert_success(rmdir("dir")); diff --git a/srcpkgs/vifm/template b/srcpkgs/vifm/template index a6d632d27e33..252d56ea96ef 100644 --- a/srcpkgs/vifm/template +++ b/srcpkgs/vifm/template @@ -1,6 +1,6 @@ # Template file for 'vifm' pkgname=vifm -version=0.11 +version=0.12 revision=1 build_style=gnu-configure configure_args="--without-gtk" @@ -12,7 +12,7 @@ maintainer="Alessio Sergi <al3hex@gmail.com>" license="GPL-2.0-or-later" homepage="https://vifm.info/" distfiles="${SOURCEFORGE_SITE}/vifm/vifm-${version}.tar.bz2" -checksum=d06f7e25f1ba0936f27f3d34401cc9eaa50ccc5a5e70ad5659e5014f04691e67 +checksum=33a9618f32b35b5b8c64483884f9ad09963ca8465b2935def79159028e27b2c0 CFLAGS="-fcommon" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: vifm: update to 0.12 2021-10-07 11:17 [PR PATCH] vifm: update to 0.12 FollieHiyuki ` (3 preceding siblings ...) 2021-10-08 14:05 ` [PR PATCH] [Updated] " FollieHiyuki @ 2021-10-08 14:09 ` ericonr 4 siblings, 0 replies; 6+ messages in thread From: ericonr @ 2021-10-08 14:09 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 1405 bytes --] There's a merged pull request on the void-packages repository vifm: update to 0.12 https://github.com/void-linux/void-packages/pull/33401 Description: <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl --> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-08 14:09 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-07 11:17 [PR PATCH] vifm: update to 0.12 FollieHiyuki 2021-10-07 11:19 ` FollieHiyuki 2021-10-08 13:20 ` ericonr 2021-10-08 13:59 ` FollieHiyuki 2021-10-08 14:05 ` [PR PATCH] [Updated] " FollieHiyuki 2021-10-08 14:09 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).