Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: ntfs2btrfs
@ 2021-10-07  2:59 foxlet
  2021-10-07  3:17 ` [PR REVIEW] " ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: foxlet @ 2021-10-07  2:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

There is a new pull request by foxlet against master on the void-packages repository

https://github.com/foxlet/void-packages ntfs2btrfs
https://github.com/void-linux/void-packages/pull/33396

New package: ntfs2btrfs
Filesystem conversion tool from NTFS to BTRFS (with rollback), useful for users migrating from Windows-based installations while preserving data.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/33396.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ntfs2btrfs-33396.patch --]
[-- Type: text/x-diff, Size: 1929 bytes --]

From b0351047b052b925d592bf615e53a67da5aae49e Mon Sep 17 00:00:00 2001
From: Foxlet <foxlet@furcode.co>
Date: Wed, 6 Oct 2021 22:56:31 -0400
Subject: [PATCH] New package: ntfs2btrfs-20210923

---
 srcpkgs/ntfs2btrfs/patches/installdirs.patch | 10 ++++++++++
 srcpkgs/ntfs2btrfs/template                  | 13 +++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 srcpkgs/ntfs2btrfs/patches/installdirs.patch
 create mode 100644 srcpkgs/ntfs2btrfs/template

diff --git a/srcpkgs/ntfs2btrfs/patches/installdirs.patch b/srcpkgs/ntfs2btrfs/patches/installdirs.patch
new file mode 100644
index 000000000000..a5ed5f87e2d3
--- /dev/null
+++ b/srcpkgs/ntfs2btrfs/patches/installdirs.patch
@@ -0,0 +1,10 @@
+--- a/CMakeLists.txt      2021-09-23 17:27:23.000000000 -0400
++++ b/CMakeLists.txt      2021-10-06 22:26:35.471832291 -0400
+@@ -89,5 +89,5 @@
+     target_compile_options(ntfs2btrfs PRIVATE -Wall -Wextra -Wno-address-of-packed-member -Wconversion -Wno-unknown-pragmas -Werror=pointer-arith)
+ endif()
+ 
+-install(TARGETS ntfs2btrfs DESTINATION sbin)
++install(TARGETS ntfs2btrfs DESTINATION bin)
+ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/ntfs2btrfs.8 DESTINATION ${CMAKE_INSTALL_MANDIR}/man8)
+ 
diff --git a/srcpkgs/ntfs2btrfs/template b/srcpkgs/ntfs2btrfs/template
new file mode 100644
index 000000000000..8e6b3d495ce7
--- /dev/null
+++ b/srcpkgs/ntfs2btrfs/template
@@ -0,0 +1,13 @@
+# Template file for 'ntfs2btrfs'
+pkgname=ntfs2btrfs
+version=20210923
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config"
+makedepends="fmt-devel zlib-devel lzo-devel libzstd-devel"
+short_desc="Filesystem converter for Microsoft's NTFS"
+maintainer="Foxlet <foxlet@furcode.co>"
+license="GPL-2.0-only"
+homepage="https://github.com/maharmstone/ntfs2btrfs"
+distfiles="https://github.com/maharmstone/ntfs2btrfs/archive/${version}.tar.gz"
+checksum=e07cc1cad634d59e58111bf993683f02a7504913fac1ef8dd33fd06ebf9140c1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] New package: ntfs2btrfs
  2021-10-07  2:59 [PR PATCH] New package: ntfs2btrfs foxlet
@ 2021-10-07  3:17 ` ericonr
  2021-10-07 22:45 ` [PR PATCH] [Updated] " foxlet
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-10-07  3:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33396#discussion_r723815761

Comment:
If you want to upstream this, there should be a Cmake var for this.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] New package: ntfs2btrfs
  2021-10-07  2:59 [PR PATCH] New package: ntfs2btrfs foxlet
  2021-10-07  3:17 ` [PR REVIEW] " ericonr
@ 2021-10-07 22:45 ` foxlet
  2021-10-08 14:45 ` ericonr
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: foxlet @ 2021-10-07 22:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

There is an updated pull request by foxlet against master on the void-packages repository

https://github.com/foxlet/void-packages ntfs2btrfs
https://github.com/void-linux/void-packages/pull/33396

New package: ntfs2btrfs
Filesystem conversion tool from NTFS to BTRFS (with rollback), useful for users migrating from Windows-based installations while preserving data.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/33396.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ntfs2btrfs-33396.patch --]
[-- Type: text/x-diff, Size: 2453 bytes --]

From 0f99f9060c573c918029a20299533a1d729cd1a9 Mon Sep 17 00:00:00 2001
From: Foxlet <foxlet@furcode.co>
Date: Wed, 6 Oct 2021 22:56:31 -0400
Subject: [PATCH] New package: ntfs2btrfs-20210923

---
 ...Use-GNUInstallDirs-to-determine-sbin.patch | 23 +++++++++++++++++++
 srcpkgs/ntfs2btrfs/template                   | 14 +++++++++++
 2 files changed, 37 insertions(+)
 create mode 100644 srcpkgs/ntfs2btrfs/patches/0001-Use-GNUInstallDirs-to-determine-sbin.patch
 create mode 100644 srcpkgs/ntfs2btrfs/template

diff --git a/srcpkgs/ntfs2btrfs/patches/0001-Use-GNUInstallDirs-to-determine-sbin.patch b/srcpkgs/ntfs2btrfs/patches/0001-Use-GNUInstallDirs-to-determine-sbin.patch
new file mode 100644
index 000000000000..4f3412240f52
--- /dev/null
+++ b/srcpkgs/ntfs2btrfs/patches/0001-Use-GNUInstallDirs-to-determine-sbin.patch
@@ -0,0 +1,23 @@
+From f97247434ecda2cd2c451da5c73c3af98dfaea35 Mon Sep 17 00:00:00 2001
+From: Mark Harmstone <mark@harmstone.com>
+Date: Thu, 7 Oct 2021 17:59:35 +0100
+Subject: [PATCH] CMakeLists.txt: use GNUInstallDirs to determine sbin location
+
+---
+ CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index cfaa571..17ded78 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -89,5 +89,5 @@ else()
+     target_compile_options(ntfs2btrfs PRIVATE -Wall -Wextra -Wno-address-of-packed-member -Wconversion -Wno-unknown-pragmas -Werror=pointer-arith)
+ endif()
+ 
+-install(TARGETS ntfs2btrfs DESTINATION sbin)
++install(TARGETS ntfs2btrfs DESTINATION ${CMAKE_INSTALL_SBINDIR})
+ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/ntfs2btrfs.8 DESTINATION ${CMAKE_INSTALL_MANDIR}/man8)
+-- 
+2.33.0
+
diff --git a/srcpkgs/ntfs2btrfs/template b/srcpkgs/ntfs2btrfs/template
new file mode 100644
index 000000000000..c87a81de187d
--- /dev/null
+++ b/srcpkgs/ntfs2btrfs/template
@@ -0,0 +1,14 @@
+# Template file for 'ntfs2btrfs'
+pkgname=ntfs2btrfs
+version=20210923
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_SBINDIR=bin"
+hostmakedepends="pkg-config"
+makedepends="fmt-devel zlib-devel lzo-devel libzstd-devel"
+short_desc="Filesystem converter for Microsoft's NTFS"
+maintainer="Foxlet <foxlet@furcode.co>"
+license="GPL-2.0-only"
+homepage="https://github.com/maharmstone/ntfs2btrfs"
+distfiles="https://github.com/maharmstone/ntfs2btrfs/archive/${version}.tar.gz"
+checksum=e07cc1cad634d59e58111bf993683f02a7504913fac1ef8dd33fd06ebf9140c1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: ntfs2btrfs
  2021-10-07  2:59 [PR PATCH] New package: ntfs2btrfs foxlet
  2021-10-07  3:17 ` [PR REVIEW] " ericonr
  2021-10-07 22:45 ` [PR PATCH] [Updated] " foxlet
@ 2021-10-08 14:45 ` ericonr
  2021-10-15  6:41 ` foxlet
  2021-10-24 16:14 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-10-08 14:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33396#issuecomment-938698921

Comment:
https://github.com/maharmstone/ntfs2btrfs/issues there are still a few issues, and merging it into distro repos counts as endorsement, even if slight. How comfortable are you with the tool?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: ntfs2btrfs
  2021-10-07  2:59 [PR PATCH] New package: ntfs2btrfs foxlet
                   ` (2 preceding siblings ...)
  2021-10-08 14:45 ` ericonr
@ 2021-10-15  6:41 ` foxlet
  2021-10-24 16:14 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: foxlet @ 2021-10-15  6:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

New comment by foxlet on void-packages repository

https://github.com/void-linux/void-packages/pull/33396#issuecomment-944041420

Comment:
> https://github.com/maharmstone/ntfs2btrfs/issues there are still a few issues, and merging it into distro repos counts as endorsement, even if slight. How comfortable are you with the tool?

Many of those issues are related to the Windows version or have been superseded by newer versions (with the original issuer not coming back to the thread). There will always be a risk to data without a backup (as with any tool), but I've used both this and its sister project WinBtrfs in production systems with no noticeable issues. 

FS changes are also reversible as the original NTFS metadata is preserved inside of a snapshot within new btrfs filesystem, so there is additional recourse there.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: New package: ntfs2btrfs
  2021-10-07  2:59 [PR PATCH] New package: ntfs2btrfs foxlet
                   ` (3 preceding siblings ...)
  2021-10-15  6:41 ` foxlet
@ 2021-10-24 16:14 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-10-24 16:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

There's a merged pull request on the void-packages repository

New package: ntfs2btrfs
https://github.com/void-linux/void-packages/pull/33396

Description:
Filesystem conversion tool from NTFS to BTRFS (with rollback), useful for users migrating from Windows-based installations while preserving data.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-24 16:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07  2:59 [PR PATCH] New package: ntfs2btrfs foxlet
2021-10-07  3:17 ` [PR REVIEW] " ericonr
2021-10-07 22:45 ` [PR PATCH] [Updated] " foxlet
2021-10-08 14:45 ` ericonr
2021-10-15  6:41 ` foxlet
2021-10-24 16:14 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).