Github messages for voidlinux
 help / color / mirror / Atom feed
From: tiemenwerkman <tiemenwerkman@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Add rockpro64 packages
Date: Sat, 09 Oct 2021 20:52:49 +0200	[thread overview]
Message-ID: <20211009185249.Ew8DLxQOZBQ--Dw1VIlIjtx3bAVKF4OQC8Yr-l73gIg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33444@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

New review comment by tiemenwerkman on void-packages repository

https://github.com/void-linux/void-packages/pull/33444#discussion_r725523323

Comment:
The RP64 has several leds, amoung which two related to power, a white and a red one. This patch enables them immediatlly at poweron, otherwise you have to wait until the os has fully loaded before the white led lights up. It's annoying without this patch because you have no way of seeing if a crash occurred or if it even booted.

  parent reply	other threads:[~2021-10-09 18:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 14:53 [PR PATCH] " tiemenwerkman
2021-10-09 18:13 ` [PR REVIEW] " CameronNemo
2021-10-09 18:14 ` CameronNemo
2021-10-09 18:17 ` CameronNemo
2021-10-09 18:18 ` CameronNemo
2021-10-09 18:20 ` [PR REVIEW] " CameronNemo
2021-10-09 18:49 ` tiemenwerkman
2021-10-09 18:52 ` tiemenwerkman [this message]
2021-10-09 19:03 ` tiemenwerkman
2021-10-09 19:05 ` tiemenwerkman
2021-10-10  7:53 ` [PR PATCH] [Updated] " tiemenwerkman
2021-10-10  8:07 ` tiemenwerkman
2021-10-10  8:08 ` [PR PATCH] [Closed]: " tiemenwerkman
2021-10-10  8:09 ` tiemenwerkman
2021-10-10 13:29 ` Duncaen
2021-10-10 13:30 ` Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211009185249.Ew8DLxQOZBQ--Dw1VIlIjtx3bAVKF4OQC8Yr-l73gIg@z \
    --to=tiemenwerkman@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).