Github messages for voidlinux
 help / color / mirror / Atom feed
From: tiemenwerkman <tiemenwerkman@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: Add rockpro64 packages
Date: Sun, 10 Oct 2021 10:08:12 +0200	[thread overview]
Message-ID: <20211010080812.aL9abQM8tNPnfmQi1HP2cGLxAdEM5Q5AIwkjClDpqYI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33444@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

There's a closed pull request on the void-packages repository

Add rockpro64 packages
https://github.com/void-linux/void-packages/pull/33444

Description:
#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [X] I built this PR locally for these architectures (if supported. mark crossbuilds): crossbuilds on amd64
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

This is my first pull request so I imagine there are probably a few things off with it.
I only started using git this week, I'm learning as I go.
I started putting these two packages together two weeks ago, I've tested mostly with emmc and sd cards and some usb thumb drives. I don't yet have pcie sata or nvme card to test.
I've also tested the usb-keyboard and HDMI output, the keyboard is fine and the HDMI output is mostly fine. HDMI immediately comes up but does not return by itself when loading the kernel (any version). It returns though when either the cable is reseated or the monitor is turned off and on again.
The nic works fine and so do the usb ports.
I opted not to create a kernel specific package as I think this makes it easier to update to newer versions, moreover it does not seem to be necessary. The only thing I ran into is that on versions 5.13 and 5.14 I am unable to build the zfs dkms module (no, I did not forget the headers).
Any feedback from testers would be welcome!   

  parent reply	other threads:[~2021-10-10  8:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 14:53 [PR PATCH] " tiemenwerkman
2021-10-09 18:13 ` [PR REVIEW] " CameronNemo
2021-10-09 18:14 ` CameronNemo
2021-10-09 18:17 ` CameronNemo
2021-10-09 18:18 ` CameronNemo
2021-10-09 18:20 ` [PR REVIEW] " CameronNemo
2021-10-09 18:49 ` tiemenwerkman
2021-10-09 18:52 ` tiemenwerkman
2021-10-09 19:03 ` tiemenwerkman
2021-10-09 19:05 ` tiemenwerkman
2021-10-10  7:53 ` [PR PATCH] [Updated] " tiemenwerkman
2021-10-10  8:07 ` tiemenwerkman
2021-10-10  8:08 ` tiemenwerkman [this message]
2021-10-10  8:09 ` tiemenwerkman
2021-10-10 13:29 ` Duncaen
2021-10-10 13:30 ` Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211010080812.aL9abQM8tNPnfmQi1HP2cGLxAdEM5Q5AIwkjClDpqYI@z \
    --to=tiemenwerkman@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).