[PR PATCH] gifsicle: subsume "Gifsicle"

[PR PATCH] gifsicle: subsume "Gifsicle"

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

There is a new pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages gif
https://github.com/void-linux/void-packages/pull/33674

gifsicle: subsume "Gifsicle"
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33674.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gif-33674.patch --]
[-- Type: text/x-diff, Size: 2192 bytes --]

From 87ca4848da221dfe7be2aa594d93b284e7ff42d6 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Thu, 21 Oct 2021 13:38:14 -0400
Subject: [PATCH] gifsicle: subsume "Gifsicle"

---
 srcpkgs/Gifsicle/template | 12 ++++--------
 srcpkgs/Gifsicle/update   |  2 --
 srcpkgs/gifsicle/template |  3 ++-
 3 files changed, 6 insertions(+), 11 deletions(-)
 delete mode 100644 srcpkgs/Gifsicle/update

diff --git a/srcpkgs/Gifsicle/template b/srcpkgs/Gifsicle/template
index 3bc86a181323..0bacd451e5bc 100644
--- a/srcpkgs/Gifsicle/template
+++ b/srcpkgs/Gifsicle/template
@@ -1,13 +1,9 @@
 # Template file for 'Gifsicle'
 pkgname=Gifsicle
 version=1.92
-revision=1
-wrksrc="gifsicle-${version}"
-build_style=gnu-configure
-makedepends="libX11-devel"
-short_desc="Command-line GIF manipulation tool"
-maintainer="ColdPhoenix <coldphoenix@interia.pl>"
+revision=2
+build_style=meta
+short_desc="Empty meta-package for Gifsicle"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
 license="GPL-2.0-only"
 homepage="https://www.lcdf.org/gifsicle"
-distfiles="${homepage}/gifsicle-${version}.tar.gz"
-checksum=5ab556c01d65fddf980749e3ccf50b7fd40de738b6df679999294cc5fabfce65
diff --git a/srcpkgs/Gifsicle/update b/srcpkgs/Gifsicle/update
deleted file mode 100644
index 53252e972a5b..000000000000
--- a/srcpkgs/Gifsicle/update
+++ /dev/null
@@ -1,2 +0,0 @@
-site="https://www.lcdf.org/gifsicle/changes.html"
-pattern='<b>\K[0-9\.]+(?=</b>)'
\ No newline at end of file
diff --git a/srcpkgs/gifsicle/template b/srcpkgs/gifsicle/template
index 50313417e864..01fe66148bb7 100644
--- a/srcpkgs/gifsicle/template
+++ b/srcpkgs/gifsicle/template
@@ -1,7 +1,7 @@
 # Template file for 'gifsicle'
 pkgname=gifsicle
 version=1.93
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="automake libtool pkg-config"
 short_desc="Command-line tool for information about GIF images"
@@ -10,6 +10,7 @@ license="GPL-2.0-or-later"
 homepage="http://www.lcdf.org/gifsicle/"
 distfiles="https://github.com/kohler/gifsicle/archive/refs/tags/v${version}.tar.gz"
 checksum=941c0b1c3ebc748949a0d14363f0fb3c9d2c06ee122b3548315b9233eb956d88
+replaces="Gifsicle>0"
 
 pre_configure() {
 	autoreconf -fi

Re: [PR REVIEW] gifsicle: subsume "Gifsicle"

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33674#discussion_r733926853

Comment:
`replaces=` is passive, ie. `Gifsicle` users would need to install `gifsicle` manually. Make `Gifsicle` a transitional package in `gifsicle` temlate instead.

Re: [PR REVIEW] gifsicle: subsume "Gifsicle"

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33674#discussion_r733935175

Comment:
I'm not sure how to do that. Can you give an example of a template that does this?

Re: gifsicle: subsume "Gifsicle"

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33674#issuecomment-948886242

Comment:
next -> nyxt is done right.

Re: [PR PATCH] [Updated] gifsicle: subsume "Gifsicle"

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages gif
https://github.com/void-linux/void-packages/pull/33674

gifsicle: subsume "Gifsicle"
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33674.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gif-33674.patch --]
[-- Type: text/x-diff, Size: 2318 bytes --]

From b19a134b8f459af8a53d10f25a7405da1a2f193f Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Thu, 21 Oct 2021 14:42:34 -0400
Subject: [PATCH] gifsicle: subsume "Gifsicle"

---
 srcpkgs/Gifsicle          |  1 +
 srcpkgs/Gifsicle/template | 13 -------------
 srcpkgs/Gifsicle/update   |  2 --
 srcpkgs/gifsicle/template |  8 +++++++-
 4 files changed, 8 insertions(+), 16 deletions(-)
 create mode 120000 srcpkgs/Gifsicle
 delete mode 100644 srcpkgs/Gifsicle/template
 delete mode 100644 srcpkgs/Gifsicle/update

diff --git a/srcpkgs/Gifsicle b/srcpkgs/Gifsicle
new file mode 120000
index 000000000000..a986d20bd79b
--- /dev/null
+++ b/srcpkgs/Gifsicle
@@ -0,0 +1 @@
+gifsicle
\ No newline at end of file
diff --git a/srcpkgs/Gifsicle/template b/srcpkgs/Gifsicle/template
deleted file mode 100644
index 3bc86a181323..000000000000
--- a/srcpkgs/Gifsicle/template
+++ /dev/null
@@ -1,13 +0,0 @@
-# Template file for 'Gifsicle'
-pkgname=Gifsicle
-version=1.92
-revision=1
-wrksrc="gifsicle-${version}"
-build_style=gnu-configure
-makedepends="libX11-devel"
-short_desc="Command-line GIF manipulation tool"
-maintainer="ColdPhoenix <coldphoenix@interia.pl>"
-license="GPL-2.0-only"
-homepage="https://www.lcdf.org/gifsicle"
-distfiles="${homepage}/gifsicle-${version}.tar.gz"
-checksum=5ab556c01d65fddf980749e3ccf50b7fd40de738b6df679999294cc5fabfce65
diff --git a/srcpkgs/Gifsicle/update b/srcpkgs/Gifsicle/update
deleted file mode 100644
index 53252e972a5b..000000000000
--- a/srcpkgs/Gifsicle/update
+++ /dev/null
@@ -1,2 +0,0 @@
-site="https://www.lcdf.org/gifsicle/changes.html"
-pattern='<b>\K[0-9\.]+(?=</b>)'
\ No newline at end of file
diff --git a/srcpkgs/gifsicle/template b/srcpkgs/gifsicle/template
index 50313417e864..d466886ae54e 100644
--- a/srcpkgs/gifsicle/template
+++ b/srcpkgs/gifsicle/template
@@ -1,7 +1,7 @@
 # Template file for 'gifsicle'
 pkgname=gifsicle
 version=1.93
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="automake libtool pkg-config"
 short_desc="Command-line tool for information about GIF images"
@@ -14,3 +14,9 @@ checksum=941c0b1c3ebc748949a0d14363f0fb3c9d2c06ee122b3548315b9233eb956d88
 pre_configure() {
 	autoreconf -fi
 }
+
+Gifsicle_package() {
+	depends="gifsicle"
+	short_desc+=" (transitional dummy package)"
+	build_style=meta
+}

Re: gifsicle: subsume "Gifsicle"

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33674#issuecomment-948932026

Comment:
Alright, I think that's correct.

Re: [PR PATCH] [Merged]: gifsicle: subsume "Gifsicle"

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]

There's a merged pull request on the void-packages repository

gifsicle: subsume "Gifsicle"
https://github.com/void-linux/void-packages/pull/33674

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->