From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [RFC]: .github: improve the PR template
Date: Sat, 23 Oct 2021 01:06:57 +0200 [thread overview]
Message-ID: <20211022230657.ZUmyPQqks-XlNpLlyNvErTtBdG0K3EclCu47zQwWkMc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33118@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33118#discussion_r734883407
Comment:
> Policy is just right, statement is kind of implied by previous one.
> not harsh and to the point.
I think I will leave it there even though it's implied by the first comment just to be explicit.
> how about something like *YES*|*NO* (in bolds) to make it both (even more) obvious to contributor that an answer is required and obvious to maintainer if it wasn't answered (like not checking any checkbox before).
Something like this?
```
#### Testing the changes
- I confirm this PR works for me: **YES**|**briefly**|**NO**
#### New package
- This new package conforms to the quality requirements: **YES**|**NO**
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
```
This way we can not differentiate between well tested and lightly tested PRs. The last section can not be adapted to this form, so it will be inconsistent with the rest of the PR template.
next prev parent reply other threads:[~2021-10-22 23:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 14:42 [PR PATCH] .github: clarify " paper42
2021-09-25 18:06 ` ericonr
2021-09-25 22:03 ` [PR PATCH] [Updated] " paper42
2021-09-25 22:08 ` [RFC]: .github: improve " paper42
2021-09-27 20:45 ` [PR REVIEW] " Chocimier
2021-09-27 20:45 ` Chocimier
2021-09-28 20:02 ` Piraty
2021-09-29 7:23 ` [PR PATCH] [Updated] " paper42
2021-09-29 7:25 ` [PR REVIEW] " paper42
2021-10-03 21:52 ` [PR PATCH] [Updated] " paper42
2021-10-03 21:56 ` [PR REVIEW] " paper42
2021-10-04 16:04 ` Chocimier
2021-10-05 19:17 ` Piraty
2021-10-14 16:32 ` Chocimier
2021-10-22 23:06 ` paper42 [this message]
2021-10-23 10:47 ` Gottox
2021-10-24 17:25 ` [PR PATCH] [Updated] " paper42
2021-10-25 17:42 ` [PR REVIEW] " Chocimier
2021-10-28 22:03 ` paper42
2021-10-29 15:28 ` Chocimier
2021-11-08 22:32 ` Piraty
2021-11-08 23:02 ` Vaelatern
2021-11-09 23:31 ` [PR PATCH] [Merged]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022230657.ZUmyPQqks-XlNpLlyNvErTtBdG0K3EclCu47zQwWkMc@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).