Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] .github: clarify the PR template
Date: Sat, 25 Sep 2021 16:42:29 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33118@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pr-template-clarify
https://github.com/void-linux/void-packages/pull/33118

.github: clarify the PR template
Filling out the "Does it run and build successfully" section is
necessary only when the CI is skipped, but this is easy to miss.
Separate it from the rest of the text to make it clearer.

cc @ailiop-git

A patch file from https://github.com/void-linux/void-packages/pull/33118.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr-template-clarify-33118.patch --]
[-- Type: text/x-diff, Size: 1231 bytes --]

From ee5d9f0f8e61af3ddf04ec89ae5f8ecab6cd4096 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 25 Sep 2021 14:56:06 +0200
Subject: [PATCH] .github: clarify the PR template

Filling out the "Does it run and build successfully" section is
necessary only when the CI is skipped, but this is easy to miss.
Separate it from the rest of the text to make it clearer.
---
 .github/pull_request_template.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 1fdf9e94ea93..fb7b26eb1e27 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -11,9 +11,10 @@
 If GitHub CI cannot be used to validate the build result (for example, if the
 build is likely to take several hours), make sure to
 [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
-When skipping CI, uncomment and fill out the following section.
 Note: for builds that are likely to complete in less than 2 hours, it is not
 acceptable to skip CI.
+
+When skipping CI, uncomment and fill out the following section.
 -->
 <!-- 
 #### Does it build and run successfully? 

             reply	other threads:[~2021-09-25 14:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25 14:42 paper42 [this message]
2021-09-25 18:06 ` ericonr
2021-09-25 22:03 ` [PR PATCH] [Updated] " paper42
2021-09-25 22:08 ` [RFC]: .github: improve " paper42
2021-09-27 20:45 ` [PR REVIEW] " Chocimier
2021-09-27 20:45 ` Chocimier
2021-09-28 20:02 ` Piraty
2021-09-29  7:23 ` [PR PATCH] [Updated] " paper42
2021-09-29  7:25 ` [PR REVIEW] " paper42
2021-10-03 21:52 ` [PR PATCH] [Updated] " paper42
2021-10-03 21:56 ` [PR REVIEW] " paper42
2021-10-04 16:04 ` Chocimier
2021-10-05 19:17 ` Piraty
2021-10-14 16:32 ` Chocimier
2021-10-22 23:06 ` paper42
2021-10-23 10:47 ` Gottox
2021-10-24 17:25 ` [PR PATCH] [Updated] " paper42
2021-10-25 17:42 ` [PR REVIEW] " Chocimier
2021-10-28 22:03 ` paper42
2021-10-29 15:28 ` Chocimier
2021-11-08 22:32 ` Piraty
2021-11-08 23:02 ` Vaelatern
2021-11-09 23:31 ` [PR PATCH] [Merged]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33118@inbox.vuxu.org \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).