[PR PATCH] g810-led: install udev rules

[PR PATCH] g810-led: install udev rules

[adigitoleo]

[-- Attachment #1: Type: text/plain, Size: 2165 bytes --]

There is a new pull request by adigitoleo against master on the void-packages repository

https://github.com/adigitoleo/void-packages fix-g810-led
https://github.com/void-linux/void-packages/pull/33900

g810-led: install udev rules
This installs the udev rules for the g810-led package, so that the profile in /etc/g810/profile is automatically applied. Noticed this when moving stuff over from Arch, which installs the rules by default.

I'm new to this, and not sure now to really test this. I can't see the rules file in `masterdir` so I'm a bit confused. However, I built it successfully for a few architectures and ran the xbps-src test for aarch64 which all seemed to come up clean.

Should I install the package from this my repo somehow, to test it? Sorry if I missed that part in the docs.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (aarch64)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/33900.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-g810-led-33900.patch --]
[-- Type: text/x-diff, Size: 976 bytes --]

From fd2b8b76cdf0abb5ae82180e91c0afb6b4f8c286 Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@dissimulo.com>
Date: Thu, 4 Nov 2021 19:37:39 +1100
Subject: [PATCH] g810-led: install udev rules

---
 srcpkgs/g810-led/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/g810-led/template b/srcpkgs/g810-led/template
index 57a8c4c124d9..a986fbda84a8 100644
--- a/srcpkgs/g810-led/template
+++ b/srcpkgs/g810-led/template
@@ -1,7 +1,7 @@
 # Template file for 'g810-led'
 pkgname=g810-led
 version=0.4.2
-revision=1
+revision=2
 build_style=gnu-makefile
 makedepends="hidapi-devel"
 short_desc="LED controller for Logitech G213,410,512,610,810,910,PRO keyboards"
@@ -18,6 +18,8 @@ do_install() {
 	done
 	vmkdir usr/lib
 	vcopy "lib/*.so.*" usr/lib
+	vmkdir usr/lib/udev/rules.d/70-g810-led.rules
+	vinstall udev/g810-led.rules 0644 usr/lib/udev/rules.d/70-g810-led.rules
 	vdoc README.md
 	vdoc INSTALL.md
 	for i in sample_profiles/*; do

Re: g810-led: install udev rules

[adigitoleo]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/33900#issuecomment-961165381

Comment:
Oh, found the built package in hostdir/binpkgs and was able to install.

Needs fixing :)

Re: [PR PATCH] [Closed]: g810-led: install udev rules

[adigitoleo]

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

There's a closed pull request on the void-packages repository

g810-led: install udev rules
https://github.com/void-linux/void-packages/pull/33900

Description:
This installs the udev rules for the g810-led package, so that the profile in /etc/g810/profile is automatically applied. Noticed this when moving stuff over from Arch, which installs the rules by default.

I'm new to this, and not sure now to really test this. I can't see the rules file in `masterdir` so I'm a bit confused. However, I built it successfully for a few architectures and ran the xbps-src test for aarch64 which all seemed to come up clean.

Should I install the package from this my repo somehow, to test it? Sorry if I missed that part in the docs.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (aarch64)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [ ] armv6l-musl

Re: g810-led: install udev rules

[adigitoleo]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/33900#issuecomment-961490333

Comment:
#33902

Re: g810-led: install udev rules

[misuchiru03]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by misuchiru03 on void-packages repository

https://github.com/void-linux/void-packages/pull/33902#issuecomment-962273445

Comment:
Checks out. Send it.

Re: g810-led: install udev rules

[abenson]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/33902#issuecomment-962259214

Comment:
@misuchiru03 

Re: g810-led: install udev rules

[adigitoleo]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/33902#issuecomment-961503904

Comment:
@Duncaen Thanks for the tip, I'll keep it in mind for next time :)

I should have read the README.md more carefully:

```
When you make changes to your pull request, please *do not close and reopen your pull request*. Instead, just [forcibly git push](#review), overwriting any old commits. Closing and opening your pull requests repeatedly spams the Void maintainers.
```

Re: g810-led: install udev rules

[adigitoleo]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/33902#issuecomment-961503904

Comment:
@Duncaen Thanks for the tip, I'll keep it in mind for next time :)

Re: g810-led: install udev rules

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/33902#issuecomment-961502089

Comment:
Instead of opening a new PR you can force push to the same branch to avoid the noise of opening and closing multiple PRs.