Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: nvtop-1.2.2
@ 2021-10-10 10:05 Daxot
  2021-11-05 23:12 ` [PR REVIEW] " abenson
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Daxot @ 2021-10-10 10:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

There is a new pull request by Daxot against master on the void-packages repository

https://github.com/Daxot/void-packages new-package-nvtop
https://github.com/void-linux/void-packages/pull/33460

New package: nvtop-1.2.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-nvtop-33460.patch --]
[-- Type: text/x-diff, Size: 991 bytes --]

From ba66025178c22694ddc067fe4d9cba5b2b5748b5 Mon Sep 17 00:00:00 2001
From: Daxot <filohin.pavel@gmail.com>
Date: Sun, 10 Oct 2021 12:57:44 +0300
Subject: [PATCH] New package: nvtop-1.2.2

---
 srcpkgs/nvtop/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/nvtop/template

diff --git a/srcpkgs/nvtop/template b/srcpkgs/nvtop/template
new file mode 100644
index 000000000000..c397b2628e54
--- /dev/null
+++ b/srcpkgs/nvtop/template
@@ -0,0 +1,14 @@
+# Template file for 'nvtop'
+pkgname=nvtop
+version=1.2.2
+revision=1
+archs="x86_64"
+build_style=cmake
+makedepends="ncurses-devel"
+depends="nvidia ncurses"
+short_desc="NVIDIA GPUs htop-like monitoring tool"
+maintainer="Filokhin Pavel <filohin.pavel@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Syllo/nvtop"
+distfiles="https://github.com/Syllo/nvtop/archive/$version/$pkgname-$version.tar.gz"
+checksum=d6ca7f467cc1048ebd1ebf7add753650c5d7c8868752c0c57ed2c85df62f5810

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] New package: nvtop-1.2.2
  2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
@ 2021-11-05 23:12 ` abenson
  2021-11-05 23:17 ` abenson
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: abenson @ 2021-11-05 23:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/33460#discussion_r744020538

Comment:
You don't need to list `ncurses` in `depends`, it will be detected.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] New package: nvtop-1.2.2
  2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
  2021-11-05 23:12 ` [PR REVIEW] " abenson
@ 2021-11-05 23:17 ` abenson
  2021-11-07 11:41 ` Daxot
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: abenson @ 2021-11-05 23:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/33460#discussion_r744021817

Comment:
Does this work with `nvidia390` as well? You could drop the `nvidia` requirement as well for those on older systems.  If you do that, set `archs="x86_64 i686"`.  

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] New package: nvtop-1.2.2
  2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
  2021-11-05 23:12 ` [PR REVIEW] " abenson
  2021-11-05 23:17 ` abenson
@ 2021-11-07 11:41 ` Daxot
  2021-11-07 11:43 ` [PR PATCH] [Updated] " Daxot
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Daxot @ 2021-11-07 11:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

New review comment by Daxot on void-packages repository

https://github.com/void-linux/void-packages/pull/33460#discussion_r744244305

Comment:
Hi, and thank you for review.
About `nvidia390`: nvtop uses NVML Library which comes with nvidia drivers and as developer stated in github readme:
"_The NVML library does not support some of the queries for GPUs coming before the Kepler microarchitecture. Anything starting at GeForce 600, GeForce 800M and successor should work fine_". 
So, i don't think that this package will be working correctly on `nvidia390` and their GPU models.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] New package: nvtop-1.2.2
  2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
                   ` (2 preceding siblings ...)
  2021-11-07 11:41 ` Daxot
@ 2021-11-07 11:43 ` Daxot
  2021-11-07 11:45 ` Daxot
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Daxot @ 2021-11-07 11:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is an updated pull request by Daxot against master on the void-packages repository

https://github.com/Daxot/void-packages new-package-nvtop
https://github.com/void-linux/void-packages/pull/33460

New package: nvtop-1.2.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-nvtop-33460.patch --]
[-- Type: text/x-diff, Size: 983 bytes --]

From 4939601f130c7113f6d5193a5a58c1fb605bc190 Mon Sep 17 00:00:00 2001
From: Daxot <filohin.pavel@gmail.com>
Date: Sun, 10 Oct 2021 12:57:44 +0300
Subject: [PATCH] New package: nvtop-1.2.2

---
 srcpkgs/nvtop/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/nvtop/template

diff --git a/srcpkgs/nvtop/template b/srcpkgs/nvtop/template
new file mode 100644
index 000000000000..149fdc8e7d1e
--- /dev/null
+++ b/srcpkgs/nvtop/template
@@ -0,0 +1,14 @@
+# Template file for 'nvtop'
+pkgname=nvtop
+version=1.2.2
+revision=1
+archs="x86_64"
+build_style=cmake
+makedepends="ncurses-devel"
+depends="nvidia"
+short_desc="NVIDIA GPUs htop-like monitoring tool"
+maintainer="Filokhin Pavel <filohin.pavel@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Syllo/nvtop"
+distfiles="https://github.com/Syllo/nvtop/archive/$version/$pkgname-$version.tar.gz"
+checksum=d6ca7f467cc1048ebd1ebf7add753650c5d7c8868752c0c57ed2c85df62f5810

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] New package: nvtop-1.2.2
  2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
                   ` (3 preceding siblings ...)
  2021-11-07 11:43 ` [PR PATCH] [Updated] " Daxot
@ 2021-11-07 11:45 ` Daxot
  2021-11-07 12:46 ` [PR REVIEW] " Daxot
  2021-11-07 17:26 ` [PR PATCH] [Closed]: " abenson
  6 siblings, 0 replies; 8+ messages in thread
From: Daxot @ 2021-11-07 11:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is an updated pull request by Daxot against master on the void-packages repository

https://github.com/Daxot/void-packages new-package-nvtop
https://github.com/void-linux/void-packages/pull/33460

New package: nvtop-1.2.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-nvtop-33460.patch --]
[-- Type: text/x-diff, Size: 983 bytes --]

From b62a09a32df9fd474f262de1bd48516b7fc92f9e Mon Sep 17 00:00:00 2001
From: Daxot <filohin.pavel@gmail.com>
Date: Sun, 10 Oct 2021 12:57:44 +0300
Subject: [PATCH] New package: nvtop-1.2.2

---
 srcpkgs/nvtop/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/nvtop/template

diff --git a/srcpkgs/nvtop/template b/srcpkgs/nvtop/template
new file mode 100644
index 000000000000..149fdc8e7d1e
--- /dev/null
+++ b/srcpkgs/nvtop/template
@@ -0,0 +1,14 @@
+# Template file for 'nvtop'
+pkgname=nvtop
+version=1.2.2
+revision=1
+archs="x86_64"
+build_style=cmake
+makedepends="ncurses-devel"
+depends="nvidia"
+short_desc="NVIDIA GPUs htop-like monitoring tool"
+maintainer="Filokhin Pavel <filohin.pavel@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Syllo/nvtop"
+distfiles="https://github.com/Syllo/nvtop/archive/$version/$pkgname-$version.tar.gz"
+checksum=d6ca7f467cc1048ebd1ebf7add753650c5d7c8868752c0c57ed2c85df62f5810

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] New package: nvtop-1.2.2
  2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
                   ` (4 preceding siblings ...)
  2021-11-07 11:45 ` Daxot
@ 2021-11-07 12:46 ` Daxot
  2021-11-07 17:26 ` [PR PATCH] [Closed]: " abenson
  6 siblings, 0 replies; 8+ messages in thread
From: Daxot @ 2021-11-07 12:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

New review comment by Daxot on void-packages repository

https://github.com/void-linux/void-packages/pull/33460#discussion_r744244305

Comment:
Hi, and thank you for review.
About `nvidia390`: nvtop uses NVML Library which comes with nvidia drivers and as developer stated in github readme:
"_The NVML library does not support some of the queries for GPUs coming before the Kepler microarchitecture. Anything starting at GeForce 600, GeForce 800M and successor should work fine_". 
So, i don't think that this package will be working correctly on `nvidia390` and their GPU series.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: New package: nvtop-1.2.2
  2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
                   ` (5 preceding siblings ...)
  2021-11-07 12:46 ` [PR REVIEW] " Daxot
@ 2021-11-07 17:26 ` abenson
  6 siblings, 0 replies; 8+ messages in thread
From: abenson @ 2021-11-07 17:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

There's a closed pull request on the void-packages repository

New package: nvtop-1.2.2
https://github.com/void-linux/void-packages/pull/33460

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-11-07 17:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-10 10:05 [PR PATCH] New package: nvtop-1.2.2 Daxot
2021-11-05 23:12 ` [PR REVIEW] " abenson
2021-11-05 23:17 ` abenson
2021-11-07 11:41 ` Daxot
2021-11-07 11:43 ` [PR PATCH] [Updated] " Daxot
2021-11-07 11:45 ` Daxot
2021-11-07 12:46 ` [PR REVIEW] " Daxot
2021-11-07 17:26 ` [PR PATCH] [Closed]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).