Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] procs: fix completion
@ 2021-11-08 21:55 TeddyDD
  2021-11-08 21:56 ` [PR PATCH] [Updated] " TeddyDD
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: TeddyDD @ 2021-11-08 21:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]

There is a new pull request by TeddyDD against master on the void-packages repository

https://github.com/TeddyDD/void-packages-1 fix-procs
https://github.com/void-linux/void-packages/pull/33967

procs: fix completion
Procs prepend generated completion with following string if stdout
of procs --completion is redirected to file:

    completion file is generated: ./procs.bash

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33967.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-procs-33967.patch --]
[-- Type: text/x-diff, Size: 1400 bytes --]

From bed6637c226964d78761008bd0a2a42933379695 Mon Sep 17 00:00:00 2001
From: Daniel Lewan <vision360.daniel@gmail.com>
Date: Mon, 8 Nov 2021 22:50:51 +0100
Subject: [PATCH] procs: fix completion

Procs prepend generated completion with following string if stdout
of procs --completion is redirected to file:

    completion file is generated: ./procs.bash
---
 srcpkgs/procs/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/procs/template b/srcpkgs/procs/template
index 8da431f119bb..499816c86fa2 100644
--- a/srcpkgs/procs/template
+++ b/srcpkgs/procs/template
@@ -1,7 +1,7 @@
 # Template file for 'procs'
 pkgname=procs
 version=0.11.10
-revision=1
+revision=2
 build_style=cargo
 build_helper=qemu
 short_desc="Modern replacement for ps written in Rust"
@@ -14,15 +14,15 @@ checksum=e6a869722181f2122a5a223517a2d1f6505d19b8b9d46ffd59c61fb02f472403
 
 post_build() {
 	PROCS="target/${RUST_TARGET}/release/procs"
-	vtargetrun ${PROCS} --completion bash > procs.bash
-	vtargetrun ${PROCS} --completion fish > procs.fish
-	vtargetrun ${PROCS} --completion zsh > procs.zsh
+	vtargetrun ${PROCS} --completion bash 
+	vtargetrun ${PROCS} --completion fish 
+	vtargetrun ${PROCS} --completion zsh
 }
 
 post_install() {
 	vcompletion procs.bash bash
 	vcompletion procs.fish fish
-	vcompletion procs.zsh zsh
+	vcompletion _procs zsh
 
 	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] procs: fix completion
  2021-11-08 21:55 [PR PATCH] procs: fix completion TeddyDD
@ 2021-11-08 21:56 ` TeddyDD
  2021-11-09 14:44 ` ericonr
  2021-11-09 14:44 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: TeddyDD @ 2021-11-08 21:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]

There is an updated pull request by TeddyDD against master on the void-packages repository

https://github.com/TeddyDD/void-packages-1 fix-procs
https://github.com/void-linux/void-packages/pull/33967

procs: fix completion
Procs prepend generated completion with following string if stdout
of `procs --completion` is redirected to file:

    completion file is generated: ./procs.bash

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33967.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-procs-33967.patch --]
[-- Type: text/x-diff, Size: 1398 bytes --]

From 68a1cf63c37222f3e60f60b4f16b3d0df95bf1bf Mon Sep 17 00:00:00 2001
From: Daniel Lewan <vision360.daniel@gmail.com>
Date: Mon, 8 Nov 2021 22:50:51 +0100
Subject: [PATCH] procs: fix completion

Procs prepend generated completion with following string if stdout
of procs --completion is redirected to file:

    completion file is generated: ./procs.bash
---
 srcpkgs/procs/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/procs/template b/srcpkgs/procs/template
index 8da431f119bb..b82f4ac4e004 100644
--- a/srcpkgs/procs/template
+++ b/srcpkgs/procs/template
@@ -1,7 +1,7 @@
 # Template file for 'procs'
 pkgname=procs
 version=0.11.10
-revision=1
+revision=2
 build_style=cargo
 build_helper=qemu
 short_desc="Modern replacement for ps written in Rust"
@@ -14,15 +14,15 @@ checksum=e6a869722181f2122a5a223517a2d1f6505d19b8b9d46ffd59c61fb02f472403
 
 post_build() {
 	PROCS="target/${RUST_TARGET}/release/procs"
-	vtargetrun ${PROCS} --completion bash > procs.bash
-	vtargetrun ${PROCS} --completion fish > procs.fish
-	vtargetrun ${PROCS} --completion zsh > procs.zsh
+	vtargetrun ${PROCS} --completion bash
+	vtargetrun ${PROCS} --completion fish
+	vtargetrun ${PROCS} --completion zsh
 }
 
 post_install() {
 	vcompletion procs.bash bash
 	vcompletion procs.fish fish
-	vcompletion procs.zsh zsh
+	vcompletion _procs zsh
 
 	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: procs: fix completion
  2021-11-08 21:55 [PR PATCH] procs: fix completion TeddyDD
  2021-11-08 21:56 ` [PR PATCH] [Updated] " TeddyDD
@ 2021-11-09 14:44 ` ericonr
  2021-11-09 14:44 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-11-09 14:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33967#issuecomment-964217435

Comment:
>     completion file is generated: ./procs.bash

Please file a bug about this, too :p That sounds broken.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: procs: fix completion
  2021-11-08 21:55 [PR PATCH] procs: fix completion TeddyDD
  2021-11-08 21:56 ` [PR PATCH] [Updated] " TeddyDD
  2021-11-09 14:44 ` ericonr
@ 2021-11-09 14:44 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-11-09 14:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

There's a merged pull request on the void-packages repository

procs: fix completion
https://github.com/void-linux/void-packages/pull/33967

Description:
Procs prepend generated completion with following string if stdout
of `procs --completion` is redirected to file:

    completion file is generated: ./procs.bash

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-09 14:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-08 21:55 [PR PATCH] procs: fix completion TeddyDD
2021-11-08 21:56 ` [PR PATCH] [Updated] " TeddyDD
2021-11-09 14:44 ` ericonr
2021-11-09 14:44 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).