* Re: [PR PATCH] [Closed]: bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
@ 2021-11-09 13:51 ` Bikutoso
2021-11-09 14:40 ` ericonr
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-09 13:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
There's a closed pull request on the void-packages repository
bacon: update to 4.4.
https://github.com/void-linux/void-packages/pull/33977
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
2021-11-09 13:51 ` [PR PATCH] [Closed]: " Bikutoso
@ 2021-11-09 14:40 ` ericonr
2021-11-09 15:18 ` Bikutoso
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-09 14:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#issuecomment-964213564
Comment:
Hi, why did you close this?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
2021-11-09 13:51 ` [PR PATCH] [Closed]: " Bikutoso
2021-11-09 14:40 ` ericonr
@ 2021-11-09 15:18 ` Bikutoso
2021-11-09 19:31 ` ericonr
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-09 15:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
New comment by Bikutoso on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#issuecomment-964249610
Comment:
> Hi, why did you close this?
Closed it due to the x86_64-musl build error. The problem is way above what I can do.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (2 preceding siblings ...)
2021-11-09 15:18 ` Bikutoso
@ 2021-11-09 19:31 ` ericonr
2021-11-09 21:54 ` [PR PATCH] [Updated] " Bikutoso
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-09 19:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#issuecomment-964468819
Comment:
Feel free to reopen! Add a comment that you need help to solve the problem.
I looked at the build log, you need at least:
```
if [ "$XBPS_TARGET_LIBC" = musl ]; then
makedepends+=" musl-fts-devel"
fi
```
If it errors out, I'd add `export LDLIBS="-lfts"` inside that block.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (3 preceding siblings ...)
2021-11-09 19:31 ` ericonr
@ 2021-11-09 21:54 ` Bikutoso
2021-11-09 22:25 ` Bikutoso
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-09 21:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
There is an updated pull request by Bikutoso against master on the void-packages repository
https://github.com/Bikutoso/void-packages bacon-update-4.4
https://github.com/void-linux/void-packages/pull/33977
bacon: update to 4.4.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33977.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bacon-update-4.4-33977.patch --]
[-- Type: text/x-diff, Size: 1199 bytes --]
From ff722c9d93215eb45cf7e6a5502a9573efa8e7a4 Mon Sep 17 00:00:00 2001
From: Bikutoso <10584311+Bikutoso@users.noreply.github.com>
Date: Tue, 9 Nov 2021 13:38:54 +0100
Subject: [PATCH] bacon: update to 4.4.
---
srcpkgs/bacon/template | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/bacon/template b/srcpkgs/bacon/template
index 08c0b782e6cd..a310cc3edf69 100644
--- a/srcpkgs/bacon/template
+++ b/srcpkgs/bacon/template
@@ -1,6 +1,6 @@
# Template file for 'bacon'
pkgname=bacon
-version=4.3.1
+version=4.4
revision=1
build_style=gnu-configure
configure_args="--with-bash --enable-gui-fltk"
@@ -12,10 +12,14 @@ license="MIT"
homepage="https://www.basic-converter.org"
changelog="https://www.basic-converter.org/stable/CHANGES"
distfiles="http://www.basic-converter.org/stable/bacon-${version}.tar.gz"
-checksum=96bbfeebb506018a6e208dc85e6daded49778ec8b4d037854bda721af890e501
+checksum=dbd7c983530743922c8ae21ef5c471df894ece9af12b4075564deb7e0659babf
disable_parallel_build=yes
nocross=yes
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ makedepends+=" musl-fts-devel"
+fi
+
post_install() {
rm -f ${DESTDIR}/usr/share/bacon/LICENSE
vlicense LICENSE
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (4 preceding siblings ...)
2021-11-09 21:54 ` [PR PATCH] [Updated] " Bikutoso
@ 2021-11-09 22:25 ` Bikutoso
2021-11-10 0:25 ` ericonr
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-09 22:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
There is an updated pull request by Bikutoso against master on the void-packages repository
https://github.com/Bikutoso/void-packages bacon-update-4.4
https://github.com/void-linux/void-packages/pull/33977
bacon: update to 4.4.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33977.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bacon-update-4.4-33977.patch --]
[-- Type: text/x-diff, Size: 1224 bytes --]
From 44fc6e46ef30e8b286ec6bd12a770e266ebe5999 Mon Sep 17 00:00:00 2001
From: Bikutoso <10584311+Bikutoso@users.noreply.github.com>
Date: Tue, 9 Nov 2021 13:38:54 +0100
Subject: [PATCH] bacon: update to 4.4.
---
srcpkgs/bacon/template | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/bacon/template b/srcpkgs/bacon/template
index 08c0b782e6cd..e35d0dc0cf04 100644
--- a/srcpkgs/bacon/template
+++ b/srcpkgs/bacon/template
@@ -1,6 +1,6 @@
# Template file for 'bacon'
pkgname=bacon
-version=4.3.1
+version=4.4
revision=1
build_style=gnu-configure
configure_args="--with-bash --enable-gui-fltk"
@@ -12,10 +12,15 @@ license="MIT"
homepage="https://www.basic-converter.org"
changelog="https://www.basic-converter.org/stable/CHANGES"
distfiles="http://www.basic-converter.org/stable/bacon-${version}.tar.gz"
-checksum=96bbfeebb506018a6e208dc85e6daded49778ec8b4d037854bda721af890e501
+checksum=dbd7c983530743922c8ae21ef5c471df894ece9af12b4075564deb7e0659babf
disable_parallel_build=yes
nocross=yes
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ makedepends+=" musl-fts-devel"
+ export LDLIBS="-lfts"
+fi
+
post_install() {
rm -f ${DESTDIR}/usr/share/bacon/LICENSE
vlicense LICENSE
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (5 preceding siblings ...)
2021-11-09 22:25 ` Bikutoso
@ 2021-11-10 0:25 ` ericonr
2021-11-10 0:46 ` [PR REVIEW] " ericonr
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-10 0:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#issuecomment-964665807
Comment:
I'm trying a local built to see if I can catch something
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (6 preceding siblings ...)
2021-11-10 0:25 ` ericonr
@ 2021-11-10 0:46 ` ericonr
2021-11-10 13:27 ` [PR PATCH] [Updated] " Bikutoso
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-10 0:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r746159797
Comment:
```suggestion
LDFLAGS="-lfts"
```
This is one ugly build system lol
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (7 preceding siblings ...)
2021-11-10 0:46 ` [PR REVIEW] " ericonr
@ 2021-11-10 13:27 ` Bikutoso
2021-11-10 13:47 ` [PR REVIEW] " Bikutoso
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-10 13:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
There is an updated pull request by Bikutoso against master on the void-packages repository
https://github.com/Bikutoso/void-packages bacon-update-4.4
https://github.com/void-linux/void-packages/pull/33977
bacon: update to 4.4.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33977.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bacon-update-4.4-33977.patch --]
[-- Type: text/x-diff, Size: 1218 bytes --]
From 8acf659a719aebe8d45ba5c9b902c12803c17f29 Mon Sep 17 00:00:00 2001
From: Bikutoso <10584311+Bikutoso@users.noreply.github.com>
Date: Tue, 9 Nov 2021 13:38:54 +0100
Subject: [PATCH] bacon: update to 4.4.
---
srcpkgs/bacon/template | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/bacon/template b/srcpkgs/bacon/template
index 08c0b782e6cd..2e077491f574 100644
--- a/srcpkgs/bacon/template
+++ b/srcpkgs/bacon/template
@@ -1,6 +1,6 @@
# Template file for 'bacon'
pkgname=bacon
-version=4.3.1
+version=4.4
revision=1
build_style=gnu-configure
configure_args="--with-bash --enable-gui-fltk"
@@ -12,10 +12,15 @@ license="MIT"
homepage="https://www.basic-converter.org"
changelog="https://www.basic-converter.org/stable/CHANGES"
distfiles="http://www.basic-converter.org/stable/bacon-${version}.tar.gz"
-checksum=96bbfeebb506018a6e208dc85e6daded49778ec8b4d037854bda721af890e501
+checksum=dbd7c983530743922c8ae21ef5c471df894ece9af12b4075564deb7e0659babf
disable_parallel_build=yes
nocross=yes
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ makedepends+=" musl-fts-devel"
+ LDFLAGS="-lfts"
+fi
+
post_install() {
rm -f ${DESTDIR}/usr/share/bacon/LICENSE
vlicense LICENSE
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (8 preceding siblings ...)
2021-11-10 13:27 ` [PR PATCH] [Updated] " Bikutoso
@ 2021-11-10 13:47 ` Bikutoso
2021-11-10 13:49 ` Bikutoso
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-10 13:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
New review comment by Bikutoso on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r746602641
Comment:
It seems to have passed.
Though I'm worried that it might fail to build later on.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (9 preceding siblings ...)
2021-11-10 13:47 ` [PR REVIEW] " Bikutoso
@ 2021-11-10 13:49 ` Bikutoso
2021-11-10 18:54 ` ericonr
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-10 13:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New review comment by Bikutoso on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r746602641
Comment:
It seems to have passed.
I'm a bit worried that it might fail to build later on.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (10 preceding siblings ...)
2021-11-10 13:49 ` Bikutoso
@ 2021-11-10 18:54 ` ericonr
2021-11-10 20:35 ` Bikutoso
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-10 18:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r746892010
Comment:
If you can tell me some simple steps to use it, I can test locally on musl.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (11 preceding siblings ...)
2021-11-10 18:54 ` ericonr
@ 2021-11-10 20:35 ` Bikutoso
2021-11-10 20:35 ` Bikutoso
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-10 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
New review comment by Bikutoso on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r746965547
Comment:
> If you can tell me some simple steps to use it, I can test locally on musl.
What I meant is that I'm worried that it might fail to build after being merged. As I tried to build it in a VM and it ended up with a segfault.
Using it is simple enough. Just run `bacon` (or `bacon.sh`?) with the file to make. e.g. `bacon hello.bac`
Their website has a bunch of [example](http://basic-converter.org/#examples) code.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (12 preceding siblings ...)
2021-11-10 20:35 ` Bikutoso
@ 2021-11-10 20:35 ` Bikutoso
2021-11-10 22:29 ` ericonr
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-10 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
New review comment by Bikutoso on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r746965547
Comment:
What I meant is that I'm worried that it might fail to build after being merged. As I tried to build it in a VM and it ended up with a segfault.
Using it is simple enough. Just run `bacon` (or `bacon.sh`?) with the file to make. e.g. `bacon hello.bac`
Their website has a bunch of [example](http://basic-converter.org/#examples) code.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (13 preceding siblings ...)
2021-11-10 20:35 ` Bikutoso
@ 2021-11-10 22:29 ` ericonr
2021-11-10 22:40 ` ericonr
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-10 22:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r747035824
Comment:
Just got a segfault now while trying to build the package D:
You shouldn't need a VM to test things on musl. Just `./xbps-src -m masterdir-musl binary-bootstrap x86_64-musl` is enough to create a musl masterdir.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (14 preceding siblings ...)
2021-11-10 22:29 ` ericonr
@ 2021-11-10 22:40 ` ericonr
2021-11-10 22:40 ` ericonr
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-10 22:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r747041632
Comment:
Well, if it segfaults during the build we can just try again, I have no idea where to even start with investigating it.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (15 preceding siblings ...)
2021-11-10 22:40 ` ericonr
@ 2021-11-10 22:40 ` ericonr
2021-11-10 23:07 ` [PR PATCH] [Updated] " Bikutoso
2021-11-11 0:22 ` [PR PATCH] [Merged]: " ericonr
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-10 22:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33977#discussion_r747041887
Comment:
```suggestion
makedepends+=" musl-fts-devel"
depends+=" musl-fts-devel"
LDFLAGS="-lfts"
```
It's needed for the files it generates!
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (16 preceding siblings ...)
2021-11-10 22:40 ` ericonr
@ 2021-11-10 23:07 ` Bikutoso
2021-11-11 0:22 ` [PR PATCH] [Merged]: " ericonr
18 siblings, 0 replies; 20+ messages in thread
From: Bikutoso @ 2021-11-10 23:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
There is an updated pull request by Bikutoso against master on the void-packages repository
https://github.com/Bikutoso/void-packages bacon-update-4.4
https://github.com/void-linux/void-packages/pull/33977
bacon: update to 4.4.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33977.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bacon-update-4.4-33977.patch --]
[-- Type: text/x-diff, Size: 1249 bytes --]
From be312419a2a173bd28b4783c4c760dad75c7284d Mon Sep 17 00:00:00 2001
From: Bikutoso <10584311+Bikutoso@users.noreply.github.com>
Date: Tue, 9 Nov 2021 13:38:54 +0100
Subject: [PATCH] bacon: update to 4.4.
---
srcpkgs/bacon/template | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/bacon/template b/srcpkgs/bacon/template
index 08c0b782e6cd..ce136cf91f89 100644
--- a/srcpkgs/bacon/template
+++ b/srcpkgs/bacon/template
@@ -1,6 +1,6 @@
# Template file for 'bacon'
pkgname=bacon
-version=4.3.1
+version=4.4
revision=1
build_style=gnu-configure
configure_args="--with-bash --enable-gui-fltk"
@@ -12,10 +12,16 @@ license="MIT"
homepage="https://www.basic-converter.org"
changelog="https://www.basic-converter.org/stable/CHANGES"
distfiles="http://www.basic-converter.org/stable/bacon-${version}.tar.gz"
-checksum=96bbfeebb506018a6e208dc85e6daded49778ec8b4d037854bda721af890e501
+checksum=dbd7c983530743922c8ae21ef5c471df894ece9af12b4075564deb7e0659babf
disable_parallel_build=yes
nocross=yes
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ makedepends+=" musl-fts-devel"
+ depends+=" musl-fts-devel"
+ LDFLAGS="-lfts"
+fi
+
post_install() {
rm -f ${DESTDIR}/usr/share/bacon/LICENSE
vlicense LICENSE
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Merged]: bacon: update to 4.4.
2021-11-09 13:00 [PR PATCH] bacon: update to 4.4 Bikutoso
` (17 preceding siblings ...)
2021-11-10 23:07 ` [PR PATCH] [Updated] " Bikutoso
@ 2021-11-11 0:22 ` ericonr
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-11-11 0:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
There's a merged pull request on the void-packages repository
bacon: update to 4.4.
https://github.com/void-linux/void-packages/pull/33977
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 20+ messages in thread