Re: [RFC] option to skip 03-rewrite-python-shebang

[ericonr <ericonr@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2316 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34053#issuecomment-968341587

Comment:
> Doesn't scanning and replacing all python shebangs cause issues in any other situations?

There used to be a bug with replacing it without taking into account the flags passed to the interpreter in the shebang, but that's been fixed.

> In particular this is NOT about hardcoding paths to the python interpreter but allowing it to run through env.

That is the exact purpose of the hook. It means system packages aren't affected by alternative `python` executables in `PATH`, and that the `xbps-alternatives` selected python doesn't change what's used for a given script. Since an alternative python will usually look for modules in a different place from `/usr/lib/python${py3_ver}` as well, this means that programs which depend on packaged modules continue working. (way back when, installing conda provided Python on ubuntu completely hosed a bunch of GUI programs for me, since they could no longer import `gi`, for example)

> It might be argued that rewriting "#! /usr/bin/env sage-python" is incorrect.

How does this break? Where is `sage-python` located?

> Also: for packages with lots of files (and/or huge text files?) this hook takes its time... AFAICT it's not only checking in /usr/bin or +x files but every single non-binary file is scanned.

Yup, there are packages with scripts under `/usr/share`, for example.

> A similar situation is 11-pkglint-elf-in-usrshare, but for that case we have "ignore_elf_dirs=".

`ignore_elf_dirs` is about policy: that directory can have ELF files because they aren't arch specific or because they *have* to go there. It's not about speedup, and it bothers me slightly that `pari-galpol` is using it for that purpose. The purpose of hooks is to always be there to catch things that we may miss; manually adding a bunch of skips for speed rather than policy feels wrong to me.

>  a. fix the pattern in 03-rewrite-python-shebang so it doesn't match "#!/usr/bin/env sage-python".

I can kinda see the case for that, since it isn't one of the two "official" python interpreters.

>  b. add an option "ignore_python_shebang_dirs" similar to "ignore_elf_dirs"

I don't think this is a valid option.