From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: [RFC] option to skip 03-rewrite-python-shebang
Date: Mon, 15 Nov 2021 02:45:25 +0100 [thread overview]
Message-ID: <20211115014525.Lch4P-WDnr3paSBYMo2SvKyPafUhjVYM_0gk9zNp94g@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34053@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
There's a closed pull request on the void-packages repository
[RFC] option to skip 03-rewrite-python-shebang
https://github.com/void-linux/void-packages/pull/34053
Description:
For #34030 we need to disable `pre-pkg/03-rewrite-python-shebang`, since sagemath ships its own python and rewriting shebangs breaks it (we will work on un-vendoring python, but that's a different story).
This PR adds an option `no_python_shebang=yes` to skip running this hook, similar to `nocross=yes`.
If this goes through, it will have to be added to `Manual.md` and to `xlint`, but I want to get feedback before.
Maybe, as an alternative, a way to skip hooks by name would be more generally useful? Something like `skip_hook="pre-pkg/03-rewrite-python-shebang"` with a space separated list of hooks to skip. That shouldn't be too hard to implement in `run_pkg_hooks()`.
next prev parent reply other threads:[~2021-11-15 1:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 11:20 [PR PATCH] " tornaria
2021-11-13 14:03 ` ericonr
2021-11-14 10:18 ` dkwo
2021-11-14 14:27 ` leahneukirchen
2021-11-14 14:48 ` tornaria
2021-11-14 18:31 ` ericonr
2021-11-15 1:45 ` tornaria [this message]
2021-11-15 1:45 ` tornaria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115014525.Lch4P-WDnr3paSBYMo2SvKyPafUhjVYM_0gk9zNp94g@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).