* [PR PATCH] New package: mailspring-1.9.2
@ 2021-11-14 14:41 fanyx
2021-11-14 14:51 ` [PR PATCH] [Updated] " fanyx
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: fanyx @ 2021-11-14 14:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
There is a new pull request by fanyx against master on the void-packages repository
https://github.com/fanyx/void-packages mailspring
https://github.com/void-linux/void-packages/pull/34076
New package: mailspring-1.9.2
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- Unable to build as of time of opening PR
- Needs assistance with fixing libcrypto.so.1.0.0 issue
A patch file from https://github.com/void-linux/void-packages/pull/34076.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mailspring-34076.patch --]
[-- Type: text/x-diff, Size: 2746 bytes --]
From c65f1038ac7f684363451abd363355c2b0139c4a Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Sun, 14 Nov 2021 15:36:29 +0100
Subject: [PATCH] New package: mailspring-1.9.2
---
.../mailspring/files/mailspring-wrapper.sh | 2 +
srcpkgs/mailspring/template | 47 +++++++++++++++++++
2 files changed, 49 insertions(+)
create mode 100755 srcpkgs/mailspring/files/mailspring-wrapper.sh
create mode 100644 srcpkgs/mailspring/template
diff --git a/srcpkgs/mailspring/files/mailspring-wrapper.sh b/srcpkgs/mailspring/files/mailspring-wrapper.sh
new file mode 100755
index 000000000000..75a01d3d6265
--- /dev/null
+++ b/srcpkgs/mailspring/files/mailspring-wrapper.sh
@@ -0,0 +1,2 @@
+#!/bin/sh
+LD_LIBRARY_PATH=/usr/lib/mailspring exec /usr/lib/mailspring/mailspring "$@"
diff --git a/srcpkgs/mailspring/template b/srcpkgs/mailspring/template
new file mode 100644
index 000000000000..6373bebff2c6
--- /dev/null
+++ b/srcpkgs/mailspring/template
@@ -0,0 +1,47 @@
+# Template file for 'mailspring'
+pkgname=mailspring
+version=1.9.2
+revision=1
+archs="x86_64"
+depends="glibc glib libgcc libstdc++ libX11 libxkbfile libsecret mit-krb5-libs libsasl libdb libXcomposite
+ libXcursor libXdamage libXext libXfixes libXi libXrender libXtst nss nspr dbus-libs gdk-pixbuf gtk+3 pango
+ atk cairo expat libXrandr libXScrnSaver alsa-lib at-spi2-atk at-spi2-core libcups libcrypto1.1"
+short_desc="Standalone Mail client with advanced feature set"
+maintainer="fanyx <fanyx@pm.me>"
+license="GPL-3.0+"
+homepage="https://getmailspring.com/"
+distfiles="https://github.com/Foundry376/Mailspring/releases/download/${version}/mailspring-${version}-amd64.deb"
+checksum="a3bc365c77791673d8b7d8fc2081b2e8e80ab5d78d6ffa99f848971849f43544"
+noshlibprovides=yes
+nopie_files="/usr/lib/mailspring/resources/app.asar.unpacked/mailsync.bin"
+
+do_extract() {
+ ar p "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-${version}-amd64.deb" data.tar.xz | bsdtar --extract --xz -f - -C .
+}
+
+do_install() {
+ vbin ${FILESDIR}/mailspring-wrapper.sh mailspring
+
+ vmkdir usr/lib/mailspring
+ vcopy usr/share/mailspring /usr/lib/
+
+ vmkdir usr/share
+ vcopy usr/share/applications usr/share/
+ vcopy usr/share/pixmaps /usr/share/
+ vcopy usr/share/icons /usr/share/
+ vcopy usr/share/lintian /usr/share/
+
+ vdoc usr/share/doc/mailspring/copyright
+
+ vlicense usr/share/mailspring/LICENSE
+ vlicense usr/share/mailspring/LICENSES.chromium.html
+}
+
+post_install() {
+ mkdir libsave
+ for lib in libffmpeg.so; do
+ mv ${DESTDIR}/usr/lib/mailspring/$lib libsave
+ done
+ find ${DESTDIR}/usr/lib/mailspring/ -name '*.so' -delete
+ mv libsave/* ${DESTDIR}/usr/lib/mailspring/
+}
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
@ 2021-11-14 14:51 ` fanyx
2021-11-14 15:03 ` fanyx
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: fanyx @ 2021-11-14 14:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
There is an updated pull request by fanyx against master on the void-packages repository
https://github.com/fanyx/void-packages mailspring
https://github.com/void-linux/void-packages/pull/34076
New package: mailspring-1.9.2
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- Unable to build as of time of opening PR
- Needs assistance with fixing libcrypto.so.1.0.0 issue
A patch file from https://github.com/void-linux/void-packages/pull/34076.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mailspring-34076.patch --]
[-- Type: text/x-diff, Size: 2754 bytes --]
From 75a6c6e01b85e9a409311ac3b889bdc7387ab9ab Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Sun, 14 Nov 2021 15:36:29 +0100
Subject: [PATCH] New package: mailspring-1.9.2
---
.../mailspring/files/mailspring-wrapper.sh | 2 +
srcpkgs/mailspring/template | 47 +++++++++++++++++++
2 files changed, 49 insertions(+)
create mode 100755 srcpkgs/mailspring/files/mailspring-wrapper.sh
create mode 100644 srcpkgs/mailspring/template
diff --git a/srcpkgs/mailspring/files/mailspring-wrapper.sh b/srcpkgs/mailspring/files/mailspring-wrapper.sh
new file mode 100755
index 000000000000..75a01d3d6265
--- /dev/null
+++ b/srcpkgs/mailspring/files/mailspring-wrapper.sh
@@ -0,0 +1,2 @@
+#!/bin/sh
+LD_LIBRARY_PATH=/usr/lib/mailspring exec /usr/lib/mailspring/mailspring "$@"
diff --git a/srcpkgs/mailspring/template b/srcpkgs/mailspring/template
new file mode 100644
index 000000000000..c70fa839ec34
--- /dev/null
+++ b/srcpkgs/mailspring/template
@@ -0,0 +1,47 @@
+# Template file for 'mailspring'
+pkgname=mailspring
+version=1.9.2
+revision=1
+archs="x86_64"
+depends="glibc glib libgcc libstdc++ libX11 libxkbfile libsecret mit-krb5-libs libsasl libdb libXcomposite
+ libXcursor libXdamage libXext libXfixes libXi libXrender libXtst nss nspr dbus-libs gdk-pixbuf gtk+3 pango
+ atk cairo expat libXrandr libXScrnSaver alsa-lib at-spi2-atk at-spi2-core libcups libcrypto1.1"
+short_desc="Standalone Mail client with advanced feature set"
+maintainer="fanyx <fanyx@pm.me>"
+license="GPL-3.0-or-later"
+homepage="https://getmailspring.com/"
+distfiles="https://github.com/Foundry376/Mailspring/releases/download/${version}/mailspring-${version}-amd64.deb"
+checksum="a3bc365c77791673d8b7d8fc2081b2e8e80ab5d78d6ffa99f848971849f43544"
+noshlibprovides=yes
+nopie_files="/usr/lib/mailspring/resources/app.asar.unpacked/mailsync.bin"
+
+do_extract() {
+ ar p "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-${version}-amd64.deb" data.tar.xz | bsdtar --extract --xz -f - -C .
+}
+
+do_install() {
+ vbin ${FILESDIR}/mailspring-wrapper.sh mailspring
+
+ vmkdir usr/lib/mailspring
+ vcopy usr/share/mailspring /usr/lib/
+
+ vmkdir usr/share
+ vcopy usr/share/applications usr/share/
+ vcopy usr/share/pixmaps /usr/share/
+ vcopy usr/share/icons /usr/share/
+ vcopy usr/share/lintian /usr/share/
+
+ vdoc usr/share/doc/mailspring/copyright
+
+ vlicense usr/share/mailspring/LICENSE
+ vlicense usr/share/mailspring/LICENSES.chromium.html
+}
+
+post_install() {
+ mkdir libsave
+ for lib in libffmpeg.so; do
+ mv ${DESTDIR}/usr/lib/mailspring/$lib libsave
+ done
+ find ${DESTDIR}/usr/lib/mailspring/ -name '*.so' -delete
+ mv libsave/* ${DESTDIR}/usr/lib/mailspring/
+}
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
2021-11-14 14:51 ` [PR PATCH] [Updated] " fanyx
@ 2021-11-14 15:03 ` fanyx
2021-11-14 15:12 ` Johnnynator
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: fanyx @ 2021-11-14 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
There is an updated pull request by fanyx against master on the void-packages repository
https://github.com/fanyx/void-packages mailspring
https://github.com/void-linux/void-packages/pull/34076
New package: mailspring-1.9.2
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- Unable to build as of time of opening PR
- Needs assistance with fixing libcrypto.so.1.0.0 issue
A patch file from https://github.com/void-linux/void-packages/pull/34076.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mailspring-34076.patch --]
[-- Type: text/x-diff, Size: 2698 bytes --]
From 9e8b9cce0e21709168709c094cece9f86283b64d Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Sun, 14 Nov 2021 15:36:29 +0100
Subject: [PATCH] New package: mailspring-1.9.2
---
.../mailspring/files/mailspring-wrapper.sh | 2 +
srcpkgs/mailspring/template | 47 +++++++++++++++++++
2 files changed, 49 insertions(+)
create mode 100755 srcpkgs/mailspring/files/mailspring-wrapper.sh
create mode 100644 srcpkgs/mailspring/template
diff --git a/srcpkgs/mailspring/files/mailspring-wrapper.sh b/srcpkgs/mailspring/files/mailspring-wrapper.sh
new file mode 100755
index 000000000000..75a01d3d6265
--- /dev/null
+++ b/srcpkgs/mailspring/files/mailspring-wrapper.sh
@@ -0,0 +1,2 @@
+#!/bin/sh
+LD_LIBRARY_PATH=/usr/lib/mailspring exec /usr/lib/mailspring/mailspring "$@"
diff --git a/srcpkgs/mailspring/template b/srcpkgs/mailspring/template
new file mode 100644
index 000000000000..bdc9498c8d68
--- /dev/null
+++ b/srcpkgs/mailspring/template
@@ -0,0 +1,47 @@
+# Template file for 'mailspring'
+pkgname=mailspring
+version=1.9.2
+revision=1
+archs="x86_64"
+depends="glibc glib libgcc libstdc++ libX11 libxkbfile libsecret mit-krb5-libs libsasl libdb libXcomposite
+ libXcursor libXdamage libXext libXfixes libXi libXrender libXtst nss nspr dbus-libs gdk-pixbuf gtk+3 pango
+ atk cairo expat libXrandr libXScrnSaver alsa-lib at-spi2-atk at-spi2-core libcups libcrypto1.1"
+short_desc="Standalone Mail client with advanced feature set"
+maintainer="fanyx <fanyx@pm.me>"
+license="custom:GPL-3.0-or-later"
+homepage="https://getmailspring.com/"
+distfiles="https://github.com/Foundry376/Mailspring/releases/download/${version}/mailspring-${version}-amd64.deb"
+checksum="a3bc365c77791673d8b7d8fc2081b2e8e80ab5d78d6ffa99f848971849f43544"
+noshlibprovides=yes
+nopie_files="/usr/lib/mailspring/resources/app.asar.unpacked/mailsync.bin"
+
+do_extract() {
+ ar p "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-${version}-amd64.deb" data.tar.xz | bsdtar --extract --xz -f - -C .
+}
+
+do_install() {
+ vbin ${FILESDIR}/mailspring-wrapper.sh mailspring
+
+ vmkdir usr/lib/mailspring
+ vcopy usr/share/mailspring /usr/lib/
+
+ vmkdir usr/share
+ vcopy usr/share/applications usr/share/
+ vcopy usr/share/pixmaps /usr/share/
+ vcopy usr/share/icons /usr/share/
+ vcopy usr/share/lintian /usr/share/
+
+ vdoc usr/share/doc/mailspring/copyright
+
+ vlicense usr/share/mailspring/LICENSE
+ vlicense usr/share/mailspring/LICENSES.chromium.html
+}
+
+post_install() {
+ mkdir libsave
+ for lib in libffmpeg.so; do
+ mv ${DESTDIR}/usr/lib/mailspring/$lib libsave
+ done
+ find ${DESTDIR}/usr/lib/mailspring/ -name '*.so' -delete
+ mv libsave/* ${DESTDIR}/usr/lib/mailspring/
+}
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
2021-11-14 14:51 ` [PR PATCH] [Updated] " fanyx
2021-11-14 15:03 ` fanyx
@ 2021-11-14 15:12 ` Johnnynator
2021-11-14 15:13 ` Johnnynator
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Johnnynator @ 2021-11-14 15:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/34076#issuecomment-968309060
Comment:
```
SONAME: libcrypto.so.1.0.0 <-> UNKNOWN PKG PLEASE FIX!
```
Some binary does link against OpenSSL 1.0, which is not shipped by Void, is long End of Life and should not be used anymore.
You could try building these parts from source against OpenSSL 1.1, but that might be a lot of pain if I remember correctly.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
` (2 preceding siblings ...)
2021-11-14 15:12 ` Johnnynator
@ 2021-11-14 15:13 ` Johnnynator
2021-11-14 15:15 ` fanyx
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Johnnynator @ 2021-11-14 15:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/34076#issuecomment-968309060
Comment:
OpenSSL 1.0, (libcrypto.so.1.0.0) is not shipped by Void, is long End of Life and should not be used anymore.
You could try building these parts from source against OpenSSL 1.1, but that might be a lot of pain if I remember correctly.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
` (3 preceding siblings ...)
2021-11-14 15:13 ` Johnnynator
@ 2021-11-14 15:15 ` fanyx
2021-11-14 20:35 ` [PR REVIEW] " ericonr
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: fanyx @ 2021-11-14 15:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
New comment by fanyx on void-packages repository
https://github.com/void-linux/void-packages/pull/34076#issuecomment-968309628
Comment:
Yeah, i feel like the libcrypto 1.0.0 linking should not be in the software itself. Will open an issue with mailspring itself to see if that can be fixed.
For the time being, is there a way to disable the automatic shlibs generation and include libcrypto1.1 as a dep manually?
The app is running just fine if i install the files to my system by hand.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
` (4 preceding siblings ...)
2021-11-14 15:15 ` fanyx
@ 2021-11-14 20:35 ` ericonr
2021-11-14 20:35 ` ericonr
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-11-14 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34076#discussion_r748904512
Comment:
Building from source should at least enable us to remove this.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
` (6 preceding siblings ...)
2021-11-14 20:35 ` ericonr
@ 2021-11-14 20:35 ` ericonr
2021-11-14 21:33 ` fanyx
2021-11-14 21:34 ` [PR PATCH] [Closed]: " fanyx
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-11-14 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34076#discussion_r748904462
Comment:
Most of these will be detected automatically by shlib scanning.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
` (5 preceding siblings ...)
2021-11-14 20:35 ` [PR REVIEW] " ericonr
@ 2021-11-14 20:35 ` ericonr
2021-11-14 20:35 ` ericonr
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-11-14 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34076#discussion_r748904606
Comment:
This should end up being PIE when built from source.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
` (7 preceding siblings ...)
2021-11-14 20:35 ` ericonr
@ 2021-11-14 21:33 ` fanyx
2021-11-14 21:34 ` [PR PATCH] [Closed]: " fanyx
9 siblings, 0 replies; 11+ messages in thread
From: fanyx @ 2021-11-14 21:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
New comment by fanyx on void-packages repository
https://github.com/void-linux/void-packages/pull/34076#issuecomment-968367551
Comment:
Agree.
I'll look into building it locally from source.
Closing this PR for now until i can successfully build it with OpenSSL 1.1.
Might just leave it out entirely, not a daily driver software anyways.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Closed]: New package: mailspring-1.9.2
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
` (8 preceding siblings ...)
2021-11-14 21:33 ` fanyx
@ 2021-11-14 21:34 ` fanyx
9 siblings, 0 replies; 11+ messages in thread
From: fanyx @ 2021-11-14 21:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
There's a closed pull request on the void-packages repository
New package: mailspring-1.9.2
https://github.com/void-linux/void-packages/pull/34076
Description:
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- Unable to build as of time of opening PR
- Needs assistance with fixing libcrypto.so.1.0.0 issue
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-11-14 21:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-14 14:41 [PR PATCH] New package: mailspring-1.9.2 fanyx
2021-11-14 14:51 ` [PR PATCH] [Updated] " fanyx
2021-11-14 15:03 ` fanyx
2021-11-14 15:12 ` Johnnynator
2021-11-14 15:13 ` Johnnynator
2021-11-14 15:15 ` fanyx
2021-11-14 20:35 ` [PR REVIEW] " ericonr
2021-11-14 20:35 ` ericonr
2021-11-14 20:35 ` ericonr
2021-11-14 21:33 ` fanyx
2021-11-14 21:34 ` [PR PATCH] [Closed]: " fanyx
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).