From: ivmai <ivmai@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] gc: update to 8.2.0, cleanup.
Date: Sun, 21 Nov 2021 09:21:49 +0100 [thread overview]
Message-ID: <20211121082149.16D2vhWbdw4EpBg7y-rzBGqi7BFHLe9d8Z-CEo_e0UM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34176@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
New comment by ivmai on void-packages repository
https://github.com/void-linux/void-packages/pull/34176#issuecomment-974774146
Comment:
> Cleanup 1: for musl, the current template sets CFLAGS='-D_GNU_SOURCE -DNO_GETCONTEXT -DSEARCH_FOR_DATA_START -DUSE_MMAP -DHAVE_DL_ITERATE_PHDR' but all of this seems noop except maybe -DSEARCH_FOR_DATA_START which I don't understand; it seems originally came from alpine which in fact doesn't use it anymore. In any case I'd argue for using the same CFLAGS for all archs and since this seems to be working without any...
Yes, I think most of them are no-op as you listed. As for SEARCH_FOR_DATA_START, I have several regular musl jobs on Travis (see (.travis.yml)[https://github.com/ivmai/bdwgc/blob/master/.travis.yml]) w/o this macro defined explicitly - the tests always pass. So, I don't know whether it is needed or not in practice. It look like both approaches are reliable - rely on __data_start or scanning of write-accessible space down from _end in case SEARCH_FOR_DATA_START, or rely on __environ otherwise (the default in upstream).
Up to you but my suggestion: to remove SEARCH_FOR_DATA_START and see if there any bug reports (or search for similar bugs in the past) , if yes then report the bug upstream.
next prev parent reply other threads:[~2021-11-21 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 22:48 [PR PATCH] " tornaria
2021-11-20 22:55 ` leahneukirchen
2021-11-21 8:08 ` ivmai
2021-11-21 8:21 ` ivmai [this message]
2021-11-21 8:30 ` ivmai
2021-11-21 8:38 ` ivmai
2021-11-21 12:55 ` [PR PATCH] [Closed]: " tornaria
2021-11-21 12:55 ` tornaria
2021-11-21 15:26 ` ivmai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211121082149.16D2vhWbdw4EpBg7y-rzBGqi7BFHLe9d8Z-CEo_e0UM@z \
--to=ivmai@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).