Re: [PR PATCH] [Closed]: [RFC] gc: update to 8.2.0, cleanup.

[tornaria <tornaria@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]

There's a closed pull request on the void-packages repository

[RFC] gc: update to 8.2.0, cleanup.
https://github.com/void-linux/void-packages/pull/34176

Description:
I was looking for out of date dependencies for sage so I updated `gc` to 8.2.0. After I had already finished I realized that 8.2.0 is experimental; it seems all the `*.*.0` releases are experimental so I added an ignore to the update file.

Even if this is not to merge now (although it might be useful to merge the ignore), I made some cleanup for some things that seem to be old and not needed anymore -- but since I'm not sure I'm asking for comments.

Cleanup 1: for musl, the current template sets `CFLAGS='-D_GNU_SOURCE -DNO_GETCONTEXT -DSEARCH_FOR_DATA_START -DUSE_MMAP -DHAVE_DL_ITERATE_PHDR'` but all of this seems noop except maybe `-DSEARCH_FOR_DATA_START` which I don't understand; it seems originally came from alpine which afaict doesn't use it anymore. In any case I'd argue for using the same CFLAGS for all archs and since this seems to be working without any...

Cleanup 2: there is a `post_install()` which installed headers, in fact it just copied all of the `include` dir in the source which also contains build artifacts. It seems to me the upstream make install works ok. It should be pointed out that some headers are not installed, seemingly those related to c++. But if c++ support is needed, passing `--enable-cplusplus` to configure seems the right way and then it will not only install those headers but also install a couple extra shared libraries so maybe installing just the .h is useless.

My test of the resulting packages (after the cleanup) is to compile and check ecl (using #34175) and while a small number of tests fail it doesn't seem to be the change in gc causing that (I tested on glibc and musl with both 8.0.6 and 8.2.0).

Maybe @ivmai can give us some feedback about these changes, and also please confirm that `*.*.0` is always experimental so it's safe to ignore in the update-check.