From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: godot: add LTO, export templates and headless
Date: Tue, 30 Nov 2021 18:12:49 +0100 [thread overview]
Message-ID: <20211130171249.xv_YNCmb8kOq8zszTV58oABC28mm6_jsONe0mjGPMR4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34226@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34226#issuecomment-982842975
Comment:
For the record, a response could have been: "it only adds 7 minutes to build time (which is very small compared to the full build) and, since the resulting binaries can be distributed to other people, it means squeezing out performance is worth it"
That justifies why enabling it makes sense, and shows how much it costs, while avoiding antagonizing those who are reviewing your PR.
next prev parent reply other threads:[~2021-11-30 17:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 12:41 [PR PATCH] godot: add client and server export templates curiousjunior
2021-11-24 14:16 ` [PR PATCH] [Updated] " curiousjunior
2021-11-24 14:17 ` curiousjunior
2021-11-24 14:20 ` curiousjunior
2021-11-24 15:53 ` [PR PATCH] [Updated] " curiousjunior
2021-11-24 18:16 ` curiousjunior
2021-11-26 1:17 ` curiousjunior
2021-11-26 1:35 ` curiousjunior
2021-11-26 1:50 ` curiousjunior
2021-11-26 1:53 ` curiousjunior
2021-11-26 2:44 ` curiousjunior
2021-11-29 19:36 ` [PR REVIEW] " ericonr
2021-11-29 19:36 ` ericonr
2021-11-29 19:36 ` ericonr
2021-11-29 19:36 ` ericonr
2021-11-29 19:36 ` ericonr
2021-11-29 19:36 ` ericonr
2021-11-29 19:58 ` curiousjunior
2021-11-29 19:59 ` curiousjunior
2021-11-29 20:00 ` curiousjunior
2021-11-29 20:13 ` curiousjunior
2021-11-29 20:22 ` curiousjunior
2021-11-29 21:37 ` [PR PATCH] [Updated] " curiousjunior
2021-11-29 21:43 ` curiousjunior
2021-11-29 21:49 ` curiousjunior
2021-11-29 21:59 ` curiousjunior
2021-11-29 22:13 ` [PR PATCH] [Updated] godot: add client and server export templates and headless editor curiousjunior
2021-11-30 4:58 ` [PR REVIEW] " ahesford
2021-11-30 6:23 ` [PR PATCH] [Updated] " curiousjunior
2021-11-30 6:27 ` [PR REVIEW] godot: add LTO, export templates and headless curiousjunior
2021-11-30 6:32 ` [PR PATCH] [Updated] " curiousjunior
2021-11-30 6:37 ` curiousjunior
2021-11-30 6:44 ` curiousjunior
2021-11-30 7:23 ` curiousjunior
2021-11-30 15:28 ` q66
2021-11-30 16:00 ` curiousjunior
2021-11-30 16:15 ` ahesford
2021-11-30 16:59 ` q66
2021-11-30 17:12 ` ericonr [this message]
2021-11-30 17:14 ` curiousjunior
2021-11-30 17:14 ` [PR REVIEW] " codingHahn
2021-11-30 17:14 ` q66
2021-11-30 17:15 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130171249.xv_YNCmb8kOq8zszTV58oABC28mm6_jsONe0mjGPMR4@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).